[PATCH] Bugfix for alignment of tag next to header name

[PATCH] Bugfix for alignment of tag next to header name

[Michael Brand]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

* org.el (org-align-tags-here): Correct calculation of alignment.

With org-tag-column set to e. g. 0 and before this change: Adding a
tag to an untagged heading placed the tag with a distance of 1 space
behind the heading name like expected. After editing the heading name
the distance was expected to remain 1 space but changed to 2 spaces.

TINYCHANGE

Michael

[-- Attachment #2: 0001-Bugfix-for-alignment-of-tag-next-to-header-name.patch --]
[-- Type: application/octet-stream, Size: 1102 bytes --]

From 1550174f1e8b4887f784d2352abb053b1ea00436 Mon Sep 17 00:00:00 2001
From: Michael Brand <michael.ch.brand@gmail.com>
Date: Sun, 5 Jun 2011 23:39:41 +0200
Subject: [PATCH] Bugfix for alignment of tag next to header name

* org.el (org-align-tags-here): Correct calculation of alignment.

With org-tag-column set to e. g. 0 and before this change: Adding a
tag to an untagged heading placed the tag with a distance of 1 space
behind the heading name like expected. After editing the heading name
the distance was expected to remain 1 space but changed to 2 spaces.

TINYCHANGE
---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 777850a..bb00573 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12896,7 +12896,7 @@ If ONOFF is `on' or `off', don't toggle but set to this state."
 	  (goto-char (match-beginning 1))
 	  (insert " ")
 	  (delete-region (point) (1+ (match-beginning 2)))
-	  (setq ncol (max (1+ (current-column))
+	  (setq ncol (max (current-column)
 			  (1+ col)
 			  (if (> to-col 0)
 			      to-col
-- 
1.7.4.2

Re: [PATCH] Bugfix for alignment of tag next to header name

[Michael Brand]

Hi all

This patch from me is still pending. Is something missing from my side
or is it acceptable?

Michael

On Sun, Jun 5, 2011 at 23:43, Michael Brand <michael.ch.brand@gmail.com> wrote:
> * org.el (org-align-tags-here): Correct calculation of alignment.
>
> With org-tag-column set to e. g. 0 and before this change: Adding a
> tag to an untagged heading placed the tag with a distance of 1 space
> behind the heading name like expected. After editing the heading name
> the distance was expected to remain 1 space but changed to 2 spaces.

Re: [PATCH] Bugfix for alignment of tag next to header name

[Carsten Dominik]

On Oct 6, 2011, at 8:58 AM, Michael Brand wrote:

> Hi all
> 
> This patch from me is still pending. Is something missing from my side
> or is it acceptable?

The patch looks good, but it did not show up on the patchwork server, probably because you did attach it with the wrong mime type.  I have applied it now, thanks.

- Carsten

> 
> Michael
> 
> On Sun, Jun 5, 2011 at 23:43, Michael Brand <michael.ch.brand@gmail.com> wrote:
>> * org.el (org-align-tags-here): Correct calculation of alignment.
>> 
>> With org-tag-column set to e. g. 0 and before this change: Adding a
>> tag to an untagged heading placed the tag with a distance of 1 space
>> behind the heading name like expected. After editing the heading name
>> the distance was expected to remain 1 space but changed to 2 spaces.
> 

Re: [PATCH] Bugfix for alignment of tag next to header name

[Michael Brand]

Hi Carsten

On Thu, Oct 6, 2011 at 09:45, Carsten Dominik <carsten.dominik@gmail.com>
> The patch looks good, but it did not show up on the patchwork server, probably because you did attach it with the wrong mime type.  I have applied it now, thanks.

Indeed: When attaching with the gmail web interface it seems that only
the file extension has an influence on the mime type. It uses
application/octet-stream for *.patch and text/plain for *.txt. For the
next patch I'll choose *.patch.txt when using the gmail web interface.

Michael