emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: Bastien <bzg@gnu.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH 2/2] Keep window position in agenda when changing todo states
Date: Sat, 14 Jun 2014 13:01:02 -0400	[thread overview]
Message-ID: <D133F1CC-93FB-4AFB-BEB3-4D083BF6A522@norang.ca> (raw)
In-Reply-To: <87fvj78p70.fsf@bzg.ath.cx>

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

Will check. Thanks. 

Bernt

> On Jun 14, 2014, at 11:51 AM, Bastien <bzg@gnu.org> wrote:
> 
> Hi Bernt,
> 
> Bernt Hansen <bernt@norang.ca> writes:
> 
>> Allow changing task state in agenda without moving point.  I
>> use this when reviewing projects weekly and I need to change the
>> state of some of the tasks.  I found jumping to the top of the
>> agenda after each state change especially annoying when it causes
>> the agenda to scroll.
> 
> I think the bug this patches is supposed to fix (i.e. point jumping
> at the top when changing the state of an agenda item) does not exist
> anymore, neither in the maint branch nor in the master one.
> 
> Can you double-check?
> 
> Also, `save-window-excursion' is sort of a brute-force approach when
> we only need to save the point position in a window.  There is a big
> warning in `save-window-excursion' docstring that I slowly learned to
> appreciate...
> 
> Anyway, I just looked at it quickly, maybe that's a correct fix.
> Thanks for further confirmation.
> 
> -- 
> Bastien

[-- Attachment #2: Type: text/html, Size: 1916 bytes --]

  reply	other threads:[~2014-06-14 17:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-14 14:46 Two patches I have been using for 6-12 months Bernt Hansen
2014-06-14 14:46 ` [PATCH 1/2] Remove striction when finding task by id Bernt Hansen
2014-06-14 15:12   ` Nicolas Goaziou
2014-06-14 15:25     ` Bernt Hansen
2014-06-15  2:50       ` [PATCH] Remove restriction when locating markers Bernt Hansen
2014-06-15  7:31         ` Nicolas Goaziou
2014-06-14 14:46 ` [PATCH 2/2] Keep window position in agenda when changing todo states Bernt Hansen
2014-06-14 15:51   ` Bastien
2014-06-14 17:01     ` Bernt Hansen [this message]
2014-06-14 17:45       ` Bernt Hansen
2014-06-15  7:34         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D133F1CC-93FB-4AFB-BEB3-4D083BF6A522@norang.ca \
    --to=bernt@norang.ca \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).