emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Morgan Smith <Morgan.J.Smith@outlook.com>
To: emacs-orgmode@gnu.org
Cc: Morgan Smith <Morgan.J.Smith@outlook.com>
Subject: [PATCH] org-make-tags-matcher: Compile returned function
Date: Sun, 28 Apr 2024 20:06:48 -0400	[thread overview]
Message-ID: <CH3PR84MB3424390023D1A552D57395FAC51B2@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM> (raw)

This should result in a nice performance boost when the function is
called repeatedly (as is often done).

* lisp/org.el (org-make-tags-matcher): Evaluate returned function to
compile it into a closure.
---

Hello!

All tests pass.

I don't have any rigorous benchmarks but this does make things significantly
faster.  This actually seems to have a bigger performance impact on
`org-clock-sum' then my rewrite of `org-clock-sum' I submitted earlier does.
Which is a little frustrating honestly.

It does involve using the `eval' function which I know is a little taboo.
Although in this case I don't believe it actually adds any danger.

Thanks,

Morgan

 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 084132fb3..80ffeeccf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11726,7 +11726,7 @@ See also `org-scan-tags'."
 		     (or tagsmatcher todomatcher t))))
       (when org--matcher-tags-todo-only
 	(setq matcher `(and (member todo org-not-done-keywords) ,matcher)))
-      (cons match0 `(lambda (todo tags-list level) ,matcher)))))
+      (cons match0 (eval `(lambda (todo tags-list level) ,matcher) t)))))
 
 (defun org--tags-expand-group (group tag-groups expanded)
   "Recursively expand all tags in GROUP, according to TAG-GROUPS.
-- 
2.41.0



             reply	other threads:[~2024-04-29  0:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  0:06 Morgan Smith [this message]
2024-04-29 16:52 ` [PATCH] org-make-tags-matcher: Compile returned function Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH3PR84MB3424390023D1A552D57395FAC51B2@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM \
    --to=morgan.j.smith@outlook.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).