From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id QNXPEAfqL2a1tAAAqHPOHw:P1 (envelope-from ) for ; Mon, 29 Apr 2024 20:42:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QNXPEAfqL2a1tAAAqHPOHw (envelope-from ) for ; Mon, 29 Apr 2024 20:42:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=GDZne4WT; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=outlook.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714416135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eQ4/JOSSeP1V6zg6TMHn3lZBmnODU77A0xJE9whY0tc=; b=E+qWbwNrmmzIC8m6+IYNdZT89ez8wDHfBuC8XsTBgDfPQBmsE3JzIsp0czCXIwE+jeP8eL nr0sS3TdKZuyuphCn3BIzlPwv+ApzlJbcf54eFnbgIyxk5zuJWdruzMVxUfFfXRe2O1bJx sqmZJ50buQgjZOYQ50bJmzeMOPtrij1qUw2DGpX14jz8pMW5pYiwQbR1bpECo+NnqNE4oc B5Kniy3HnAoZaHjr4Z8Am3EcNL5P0iRtzc+8KLhNTctxM5y6NV3BgT1IAjMTwlPAHssEoa ySxBNSH2ZXw8a0J1yarysja5WqnWJqwRAV/8/Y6242FjZ5iYFMp6Rrz2GAdudw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1714416135; a=rsa-sha256; cv=pass; b=aZWzshrlzOP+ZCUQ60NSMSrK6mtE/eYExGMjH2WlIsGlp2OWfxJ2r0FbLSVw4a1McJpFhV 7fSiapztUd1FMnrGtOV/+NTibB991uppgHx8WCkl1YSguS4ckExtUNb4ksNbNXm211sdPU EyBWtClvhsWWHzq8zwo/cHIC3s0t0z7PIDbgRI5RX64HQazpGGbb+XWBSIppZUddiEqOfv qp0UNUtWuf6qgc/HV/ePz0821T/87U2uBZnjYJEymkLk0s79qFzTJK0OuldkhKtw6JE6tE YUdbQIldVLU1w95LynFyRHWOAuKpdAcaUI/QzTkAT1RqyDWQwiX85/AFWnRaCA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=GDZne4WT; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=outlook.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AEE3765D26 for ; Mon, 29 Apr 2024 20:42:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1VwI-0002lX-GJ; Mon, 29 Apr 2024 14:41:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Vw8-0002jS-S9 for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 14:41:12 -0400 Received: from mail-bn8nam12olkn20801.outbound.protection.outlook.com ([2a01:111:f403:2c18::801] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Vw3-0007Ua-2z for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 14:41:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+OhlutGNGCVJsH5HVMEY5UOtYp1ol7rYEH0/6vrJm6Q88OCu+ZooLatF33ddlIRo4JfBH5fEwY3g2rDjikcZNjhdCkcnraJo+I58DfCRyLYf/4azl6W1p403vijXHqmpOxibiymYW0fhdI4MHekVNGVQDFLXQuXmXfHA7eh/zsGbCJ52xVJb/xSfzgH8lJSGg01893UCR1F4syEePR9kIktla31dwVSJVxQBYXWKWl74QCR31DwyoIckIzXu02mybgNiSmsreDvO5udrcpvQOM2EM+ZaBE/oMcei1NLVIGFa1B/uxmg768Q9gAlBkniftD7ystiJ50vBs4PNK5+RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQ4/JOSSeP1V6zg6TMHn3lZBmnODU77A0xJE9whY0tc=; b=cBGW75toEcth7jmUkm0nhVDxNqYw+9krBsIVSPncKvIPb6DPOxJ6X6/MK4gT5Mz+E+2WaemU4jGCYNx2LLBzl3UOZF1SRedI2FjAiTT8GhoYjR2eJ0qQ3bvKv2rILTDp4TFVd/VU8aD9qoRFSSCbSadhIm8K2kfCVwv8oEoV556Mk2aM/iGYOcZ8G2T1qcj1bVYSdxU0uXqEtp1YiES61hqYg2vdDUveGDajf/e+VlumZLIQ+gG86AFXzMKIn0o5+t+x5zOjt5r8qGbg4LrBAomm+JRLzqmWwbxK0/uGm+9zACKLWwmw4YnvE31raMqZWuc7JmxbS9jiJ3CeDtpkUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQ4/JOSSeP1V6zg6TMHn3lZBmnODU77A0xJE9whY0tc=; b=GDZne4WTCHZXu2uOgx+429dztbhqJk7fxDs8rTku7/XiBeW9GFPmRvACoCWXMkakJVkRBKKwfdO+77URDbLmBRaFwQouaii2uJNR5MKTxvMXHYON0VW45KsuByyBzNhgHVWrJHX+s1yYVjESEYRVhM/E+b3usLfv5vqkfVBPGu9xuneV1R0dh6Vgnuz/rTARGQocnSaCP4rIQqVeqEEzIR5RXlr0XZHgpQaFvk73lgVnafyEv3hksjp/AIC2wUg4BWEM5qZvqJmSikofGvCQFSfH9bvtSQUu39yTgOPV+YK3BiCbpaBducvHeX5IAEorZo/crRpfU3pl1L9Vw2kqbQ== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by LV8PR84MB3388.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1c5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Mon, 29 Apr 2024 18:36:01 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::178d:1518:8a49:2a45]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::178d:1518:8a49:2a45%6]) with mapi id 15.20.7519.031; Mon, 29 Apr 2024 18:36:01 +0000 From: Morgan Smith To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get' In-Reply-To: <87ttjkaywn.fsf@localhost> (Ihor Radchenko's message of "Mon, 29 Apr 2024 16:58:48 +0000") References: <87ttjkaywn.fsf@localhost> X-Hashcash: 1:20:240429:emacs-orgmode@gnu.org::LmzQbP4QWOfT0iVs:5tS X-Hashcash: 1:20:240429:yantar92@posteo.net::dvNA/jg1iL83n65W:2FJ7 Date: Mon, 29 Apr 2024 14:36:14 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-TMN: [0csGiHraAbm7l3iEf4UjCysAnS4oU1aT] X-ClientProxiedBy: YT2PR01CA0017.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:38::22) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <87wmogyq1t.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|LV8PR84MB3388:EE_ X-MS-Office365-Filtering-Correlation-Id: f8df7a63-c4d0-4a95-eeef-08dc687b37ef X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: 40HR9MQqsWvg2FdsgrMpbGpz5GEm+aiqiMJpRwsdB31zunfhsohoyKbcnmnE9t+BAPzalC/v1UkrmWIWzfycv9aR6+2BnGu61vHdJi/y/360TCUef4bGLu3zfXP0QspSWJrD5azBbrR68xKxC2JjqShT3sUOmmgrJFxm78cmuuvt6vqzLCTQNvaE44k/u9YmbVoZZukD+1un6XbHSRNqzh3JapfgYqkENLU2c0faEurQ8Nb2RLDndxv9OQyroz8moDGIvBF+SbZcDg4bMtjT8OEx5evIOJanljVxh60gpi5xEzqiq7dled2zxq2UZq7ZtGPbuhDkumKah8iMxtKv2yv5zRSdyrS+GHeAKLE2XXH/LGMF/xxb7yPsGKTNk5+L7sfymHJCjFot5qokBSbYRb19dCXEyrf61F4mC/9Wn8VN3sELuHKcepiL6iYp/Bd7FmIzT6hwYdlGIwkElBU6dTEExAjywMeT4W9YJRMI85X02hsaOUCLJ1JtJ2Rp68K0vPEt5usuPAOn7hEJCyi7LCZUPRyt/8+vTf6M/xOHwnZIfqEzrqnT/z78nqa79tcU X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?szn17oty09UxItJErja+v8RxpTc9WqO9KP9IjcKoaPuvEk7Cs2ZXags9y9bB?= =?us-ascii?Q?wBag767JUCgPXDnGqBoqnG8S45AxuhlGNWk5Q+OSTqcqu98L+RERscpEOOrl?= =?us-ascii?Q?ORm21D8zPbtbNvtgsnjtOdn/NEIsGj7qqqC4nm8LE8iJy9GZ7LxlQhMClLix?= =?us-ascii?Q?8na6WQjGBay02AgQaK2/+D3Ne2yZ3J5lipwriUWrCC0DCkyUz7+qHa0PW+yO?= =?us-ascii?Q?HWue8wpr1pxPEspLoXus9QbAJvpEU/6ziGVUsob5tb9H42Qvd1IR4cfuF8W6?= =?us-ascii?Q?5UnrfLhNLIHkjfYYvfl1Ul3SVNhJg+8r7KzMD0dht2W90cFCQsrzFkOmC/aT?= =?us-ascii?Q?wjVo3UuYVI6gqop/ovoWndLze1Ou+R0UNx8DRAgB5iSjMZVChY8BES/X3ST8?= =?us-ascii?Q?zP2Ty/E0MwKP54tu5jUwl9w68Q0vzhq6GpZ6iYlciPUJhdTMz1jogHqzEdrC?= =?us-ascii?Q?8adBQDuKfvjncVlx8HmNXw/o8kTFCdIaoYuxThMiPtRwpFJyeC8xfsDnb/Xv?= =?us-ascii?Q?h34oBconXgWBrUyY45+9v5TX4x5RAjiMOoEz4xkt+Gd9asU6Ha7HYBjzj1kz?= =?us-ascii?Q?ioF7o8d7adY2+lXTP82uaHBYTxZLwIXKJ2JU/z0P/XIE01lb7PbAUvn1kayE?= =?us-ascii?Q?LHBXl4Tt9r36K2HPWwdifl/SozXTOUkYMGsyG140VKmywX/V3j81Uiv2rEw/?= =?us-ascii?Q?haV919tIJFwV769FiFd06EQ1Mku1x12OU+OU6fupN+WZzfbU2rJu+wZHXqDs?= =?us-ascii?Q?q1ghqOt/wi8M9vuGw0ZgdrFX0eqd8U/mLjJPIaeBJTigah8K7aWkuIWzsi8w?= =?us-ascii?Q?60bUXMlUirmM1x1/uBBiRabsQGwwoibA3Msg9YdMq3zi0emFTI8UvIP45v0F?= =?us-ascii?Q?00mdibSAvTGP/yRburLVEdKnclZNVWIzIr5pH9nt05UGMq8nXRHi2fvFqzHc?= =?us-ascii?Q?JGTHsmkDfJt3BV3v7VHglIq0EmUuxuvtGusJfwVutZD/9Yhe5APF5m77q+7H?= =?us-ascii?Q?Ph/osUVttkjaJBCrSdWTsKp0RvTQ/odndcEo23f7hU/fxE/x+d5fmJ9F+SfN?= =?us-ascii?Q?v7NmwxToMvysYF8exl5cSGe3Mo/vYzoOxqHsVxEMXAyGuslE5Kh7n51T672Z?= =?us-ascii?Q?P51NUE9yFjSvx4m1edDdQ0yP+WC8JS4tBmA41OITbAT6FUK9H9eQsWAhJyOw?= =?us-ascii?Q?GROcvedJVgElV1aXCcCBSVE1jxiKn2eC9ZRwVx+fgDu0b2gUAjulvtVXj4Ow?= =?us-ascii?Q?/2IVW3as0IVeHK7eXF5y?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8df7a63-c4d0-4a95-eeef-08dc687b37ef X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 18:36:01.1218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR84MB3388 Received-SPF: pass client-ip=2a01:111:f403:2c18::801; envelope-from=morgan.j.smith@outlook.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.82 X-Spam-Score: -6.82 X-Migadu-Queue-Id: AEE3765D26 X-Migadu-Scanner: mx11.migadu.com X-TUID: 1xQr8ExWhFI3 Ihor Radchenko writes: > > > This function should yield speedups when matching special properties > like "CLOCKSUM", "CLOCKSUM_T", "TIMESTAMP", or "TIMESTAMP_IA". > > For example, when the requested match tests these properties multiple > times. > > We need a real-life justification, not a theoretical one. > > Canceled. I agree with all your points and I'm sorry for sending noise. However, I think I actually found a real-life justification. It turns out that by replacing `org-cached-entry-get' with `org-entry-get' the performance of my `org-clock-sum' calls got much better for my specific use case. Due to benchmarking with my local changes in place (sorry), I accidentally attributed this performance increase to byte-compiling the return of `org-make-tags-matcher'. These numbers are also with my `org-clock-sum' rewrite patch applied. They are in a 3M file of almost exclusivly clocking data. The filters I use are "CATEGORY={blah}" for one clock table and "-ignore-ITEM={foo}" for 9 others. org-cached-entry-get 1st run: 26.868990287 2nd run: 16.043983143 org-entry-get 1st run: 18.209056578 2nd run: 5.003186764