From: Nathaniel Flath <flat0103@gmail.com>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATH] Speedups to org-table-recalculate
Date: Sat, 25 Oct 2014 17:27:25 -0700 [thread overview]
Message-ID: <CAPrg3HCEd7VJyyo1z9860cHuqReQLsWrEWHgq7erLiEc4oTYxg@mail.gmail.com> (raw)
In-Reply-To: <CALn3zogsgiN9KkgkgGKH6wy6sO0g6U+MMAht252rviBDNh0YwQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3015 bytes --]
Hi Michael
On Mon, Oct 20, 2014 at 12:41 PM, Michael Brand <michael.ch.brand@gmail.com>
wrote:
> Hi Nathaniel
>
> On Mon, Oct 20, 2014 at 3:56 AM, Nathaniel Flath <flat0103@gmail.com>
> wrote:
> > Thanks for the review! Updated patches attached. I believe I've fixed
> > everything you mentioned -
>
> Yes, thank you. I tried them out.
>
> > let me know if I missed something.
>
> > Subject: [PATCH 1/2] org-table.el: Add early return check to
> > org-table-recalculate
>
> > Subject: [PATCH 2/2] org-table.el: Print far fewer messages when
> recalculating
> > tables.
>
> http://orgmode.org/worg/org-contribute.html
> says: Line 2 is an empty line.
>
> I try to limit my commit subjects to 50 chars which is a rule for some
> projects and helpful for e. g. git log with certain options.
>
OK, will fix these in next set of pathces.
>
> > + (and all (org-table-execute-once-per-second
> > + log-last-time
> > + (message
> > + "Re-applying formulas to full table...(line %d)"
> > + (setq cnt (1+ cnt)))))
>
> Before trying out I have overseen it, setq does not increment on each
> line any more so it has to move before
> org-table-execute-once-per-second. Now probably better wrapped in a
> `when' instead of the original `and' with an added `progn'.
>
OK, good catch
>
> > + (org-table-execute-once-per-second
> > + log-first-time
> > + (message "Re-applying formulas...done" cnt))
>
> cnt is superfluous.
>
OK.
>
> Only during trying out I noticed: This message could still be kept as
> a feedback at least for single row updates, like e. g. Tab on a row
> with "#" in the first column, by changing log-first-time to (when all
> log-first-time).
>
> Or more conservative why not leave this message unconditional to avoid
> that any user could complain for any use case that all feedback
> messages disappeared like it would be the case for e. g. the typical
> "C-c C-c" on TBLFM? I think that would be a simple, safe compromise.
>
I'm fine with adding the (when all log-first-time). I don't want to leave
it
unconditional because as we discussed before, one message in my case
significantly slows down the table recalculation - and if there has
been no feedback then we are dealing with a small case where it could be
significant.
>
> Otherwise the right but not so simple thing to do would be to log this
> message for a simple "C-c C-c" on TBLFM and to not log it for only
> those cases that throw after other feedback messages like e. g.
> sometimes "C-u C-u C-c C-c" on TBLFM ("Table was already stable"), M-x
> org-table-iterate-buffer-tables and more. These repetition intensive
> use cases are the only ones that can profit noticeable from the
> conditional removal of this last message, aren't they?
>
I got tired of having to force tables to be reformated, so I advised
org-cycle to always recalculate a table, so I notice whenever I'm in a
table.
>
> Michael
>
[-- Attachment #2: Type: text/html, Size: 4801 bytes --]
next prev parent reply other threads:[~2014-10-26 0:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 20:03 [PATH] Speedups to org-table-recalculate Nathaniel Flath
2014-07-29 21:30 ` Bastien
2014-07-29 21:35 ` Nathaniel Flath
2014-07-29 21:42 ` Bastien
2014-08-01 21:56 ` Michael Brand
2014-08-07 22:57 ` Nathaniel Flath
2014-08-17 13:39 ` Michael Brand
2014-10-10 5:56 ` Nathaniel Flath
2014-10-10 10:35 ` Michael Brand
2014-10-10 19:43 ` Nathaniel Flath
2014-10-11 16:16 ` Michael Brand
2014-10-18 5:11 ` Nathaniel Flath
2014-10-19 19:57 ` Michael Brand
2014-10-20 1:56 ` Nathaniel Flath
2014-10-20 19:41 ` Michael Brand
2014-10-26 0:27 ` Nathaniel Flath [this message]
2014-10-26 19:58 ` Michael Brand
2014-11-09 10:18 ` Nathaniel Flath
2014-11-09 15:42 ` Michael Brand
2014-11-12 11:51 ` Nathaniel Flath
2014-11-12 19:09 ` Michael Brand
2014-11-14 13:33 ` Nathaniel Flath
2014-11-14 17:40 ` Michael Brand
2014-11-14 18:00 ` Nathaniel Flath
2014-11-14 20:19 ` Michael Brand
2014-11-14 22:37 ` Nicolas Goaziou
2014-11-21 9:10 ` Nathaniel Flath
2014-11-21 23:30 ` Nicolas Goaziou
2014-12-01 6:02 ` Nathaniel Flath
2014-12-01 6:15 ` Nathaniel Flath
2014-12-05 23:57 ` Nicolas Goaziou
2014-12-08 7:35 ` Nathaniel Flath
2014-12-08 12:56 ` Michael Brand
2014-12-14 21:07 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPrg3HCEd7VJyyo1z9860cHuqReQLsWrEWHgq7erLiEc4oTYxg@mail.gmail.com \
--to=flat0103@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=michael.ch.brand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).