From: Anthony Lander <anthony@landerfamily.ca>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: John Wiegley <jwiegley@gmail.com>,
Daniil Frumin <difrumin@gmail.com>,
"emacs-orgmode@gnu.org Mode" <emacs-orgmode@gnu.org>,
Christopher Suckling <suckling.list@googlemail.com>
Subject: Re: ATTENTION: Incompatible change
Date: Thu, 5 Sep 2013 10:50:47 -0400 [thread overview]
Message-ID: <CAPgrogdnWRwtrbbw-1Qr9EXqr8zt5KokXA63mc1yGJoz8Qv3Sg@mail.gmail.com> (raw)
In-Reply-To: <FFF45C84-4BBE-46E9-8FD5-23C0E3F5CB1B@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]
Hi Carsten,
Sorry for the delay. For org-mac-link, here is a small cleanup patch to org
that changes the customize group name from 'org-mac-link-grabber to
'org-mac-link, and another patch which updates the documentation in worg.
Can you please review, and if OK apply to the repositories?
Thanks,
-Anthony
On Sat, Aug 31, 2013 at 9:37 AM, Carsten Dominik
<carsten.dominik@gmail.com>wrote:
> Hi all,
>
> I have now replaced both org-mac-message.el and org-mac-link-grabber.el
> with org-mac-link.el. So after the next pull, you will have to change your
> setup to use this module instead of the others and use the new commands as
> well. I would appreciate if you your try this soon, so that we can fix
> issue before the next release (very soon).
>
> Thank you, and in particular thanks to Anthony Lander for doing the work.
>
> - Carsten
>
> P.S. Anthony, you promised to update the documentation. It would be great
> if you could do that now.
>
> Thank you!
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 1480 bytes --]
[-- Attachment #2: org-mac-link-worg-patch.txt --]
[-- Type: text/plain, Size: 3208 bytes --]
diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
index 3f58616..1cc0f21 100644
--- a/org-contrib/org-mac-link.org
+++ b/org-contrib/org-mac-link.org
@@ -1,4 +1,4 @@
-#+TITLE: org-mac-link-grabber.el -- Grab links from open Mac applications
+#+TITLE: org-mac-link.el -- Grab links from open Mac applications
#+OPTIONS: ^:{} author:nil
#+STARTUP: odd
@@ -17,7 +17,7 @@
- Mail.app
- Address Book.app
- Safari.app
- - Skim.app [fn:: Supported in the latest version from Git]
+ - Skim.app [fn:: Supported in the latest version from Git]
- Firefox.app
- Firefox.app with the Vimperator plugin
- Google Chrome.app
@@ -26,26 +26,26 @@
* Installation
Customize the org group by typing =M-x customize-group RET org RET=, then
- expand the /Modules/ section, and enable =mac-link-grabber=.
+ expand the /Modules/ section, and enable =mac-link=.
You may also optionally bind a key to activate the link grabber menu, like
this:
: (add-hook 'org-mode-hook (lambda ()
- : (define-key org-mode-map (kbd "C-c g") 'omlg-grab-link)))
+ : (define-key org-mode-map (kbd "C-c g") 'org-mac-grab-link)))
-* Usage
+* Usage
- Activate the grabber by typing =C-c g= (or whatever key you decided
- to bind, as above), or type =M-x omlg-grab-link RET=. This will give
- you a menu in the modeline allowing you to select an application.
- The current selection in that application will be inserted at point
- as a hyperlink in your org-mode document.
+ Activate the grabber by typing =C-c g= (or whatever key you decided to bind,
+ as above), or type =M-x org-mac-grab-link RET=. This will give you a menu in
+ the modeline allowing you to select an application. The current selection in
+ that application will be inserted at point as a hyperlink in your org-mode
+ document.
* Customizing
- You may customize which applications appear in the grab menu by
- customizing the group /org-mac-link-grabber/. Changes take effect
- immediately. If you are using the latest org-mode from Git, you can
- also customize whether the =org-mac-link-grabber= should highlight
- the selected text when grabbing the link from Skim.app.
+ You may customize which applications appear in the grab menu by customizing
+ the group /org-mac-link/. Changes take effect immediately. If you are using
+ the latest org-mode from Git, you can also customize whether the
+ =org-mac-link= should highlight the selected text when grabbing the link from
+ Skim.app.
diff --git a/org-mac.org b/org-mac.org
index 074a85e..2015e02 100644
--- a/org-mac.org
+++ b/org-mac.org
@@ -28,7 +28,7 @@ applications other than Emacs...
** [[file:org-contrib/org-mac-iCal.org][org-mac-iCal]] -- import OS X iCal.app events into Emacs diary
Written by /Christopher Suckling/.
-** [[file:org-contrib/org-mac-link-grabber.org][org-mac-link-grabber]] -- Hyperlink to items in mac applications
+** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- Hyperlink to items in mac applications
grab the current link or selection from an open mac application and
insert it as a hyperlink at point in an org-mode document. Written
by /Anthony Lander/.
[-- Attachment #3: org-mac-link-patch.txt --]
[-- Type: text/plain, Size: 2956 bytes --]
diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index 8993919..0ab0354 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -81,58 +81,58 @@
(require 'org)
(require 'org-mac-message)
-(defgroup org-mac-link-grabber nil
+(defgroup org-mac-link nil
"Options concerning grabbing links from external Mac
applications and inserting them in org documents"
- :tag "Org Mac link grabber"
+ :tag "Org Mac link"
:group 'org-link)
(defcustom org-mac-grab-Finder-app-p t
"Enable menu option [F]inder to grab links from the Finder"
:tag "Grab Finder.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Mail-app-p t
"Enable menu option [m]ail to grab links from Mail.app"
:tag "Grab Mail.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Addressbook-app-p t
"Enable menu option [a]ddressbook to grab links from AddressBook.app"
:tag "Grab AddressBook.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Safari-app-p t
"Enable menu option [s]afari to grab links from Safari.app"
:tag "Grab Safari.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Firefox-app-p t
"Enable menu option [f]irefox to grab links from Firefox.app"
:tag "Grab Firefox.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Firefox+Vimperator-p nil
"Enable menu option [v]imperator to grab links from Firefox.app running the Vimperator plugin"
:tag "Grab Vimperator/Firefox.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Chrome-app-p t
"Enable menu option [f]irefox to grab links from Google Chrome.app"
:tag "Grab Google Chrome.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Together-app-p nil
"Enable menu option [t]ogether to grab links from Together.app"
:tag "Grab Together.app links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-grab-Skim-app-p
@@ -140,13 +140,13 @@ applications and inserting them in org documents"
"mdfind kMDItemCFBundleIdentifier == 'net.sourceforge.skim-app.skim'")))
"Enable menu option [S]kim to grab page links from Skim.app"
:tag "Grab Skim.app page links"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defcustom org-mac-Skim-highlight-selection-p nil
"Highlight (using notes) the selection (if present) when grabbing the a link from Skim.app"
:tag "Highlight selection in Skim.app"
- :group 'org-mac-link-grabber
+ :group 'org-mac-link
:type 'boolean)
(defgroup org-mac-flagged-mail nil
next prev parent reply other threads:[~2013-09-05 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 13:37 ATTENTION: Incompatible change Carsten Dominik
2013-09-05 14:50 ` Anthony Lander [this message]
2013-09-06 15:00 ` Mike McLean
2013-09-06 16:38 ` Carsten Dominik
2013-09-07 20:32 ` Mike McLean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgrogdnWRwtrbbw-1Qr9EXqr8zt5KokXA63mc1yGJoz8Qv3Sg@mail.gmail.com \
--to=anthony@landerfamily.ca \
--cc=carsten.dominik@gmail.com \
--cc=difrumin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jwiegley@gmail.com \
--cc=suckling.list@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).