From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Lander Subject: Re: small patch to org-mac-link (grab selected messages in Mail.app) Date: Fri, 6 Jun 2014 10:58:11 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d0435c0527e577e04fb2c198b Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsvbe-00072P-WC for emacs-orgmode@gnu.org; Fri, 06 Jun 2014 10:59:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsvba-0001X5-77 for emacs-orgmode@gnu.org; Fri, 06 Jun 2014 10:58:58 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:57420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsvbZ-0001Ww-AZ for emacs-orgmode@gnu.org; Fri, 06 Jun 2014 10:58:54 -0400 Received: by mail-wi0-f175.google.com with SMTP id f8so1143381wiw.14 for ; Fri, 06 Jun 2014 07:58:51 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Alan Schmitt Cc: emacs-orgmode --f46d0435c0527e577e04fb2c198b Content-Type: text/plain; charset=UTF-8 Hi Alan, Thanks for the patch. It looks OK to me - can you please go ahead and apply it to the file? Also, feel free to add your name to the contributor list at the top of the file. Thanks! -Anthony On Wed, Jun 4, 2014 at 6:15 AM, Alan Schmitt wrote: > Hello, > > Please find attached a small patch to org-mac-link.el for the functions > creating links to messages in Mail.app. > > The problem was that calling the org-mac-message-insert-selected would > always add a spurious first link with empty url and an escaped quote as > text. It would also leave another escaped quote at the end of the text > of the real link. > > The patch makes sure that no extra empty line is created during the > AppleScript call, and removes the escaped quotes around the whole value > returned from AppleScript. I have left the code that removes additional > quotes around individual links if they are there, but I don't think it's > needed (I don't see how they could occur there). > > Best, > > Alan > > --f46d0435c0527e577e04fb2c198b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Alan,

Thanks for the patch. It looks= OK to me - can you please go ahead and apply it to the file? Also, feel fr= ee to add your name to the contributor list at the top of the file.

Thanks!

=C2=A0 -Anthony
<= br>


On Wed, Jun 4, 2014 at 6:15 AM, Alan Schmitt <alan.schmitt@= polytechnique.org> wrote:
Hello,

Please find attached a small patch to org-mac-link.el for the functions
creating links to messages in Mail.app.

The problem was that calling the org-mac-message-insert-selected would
always add a spurious first link with empty url and an escaped quote as
text. It would also leave another escaped quote at the end of the text
of the real link.

The patch makes sure that no extra empty line is created during the
AppleScript call, and removes the escaped quotes around the whole value
returned from AppleScript. I have left the code that removes additional
quotes around individual links if they are there, but I don't think it&= #39;s
needed (I don't see how they could occur there).

Best,

Alan


--f46d0435c0527e577e04fb2c198b--