From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Wishon Subject: Re: Question about adding to inherited properties Date: Tue, 24 Apr 2012 19:13:04 -0700 Message-ID: References: <9494.1334894889@alphaville> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d040712075c662804be77694e Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMrjB-0001sY-QB for emacs-orgmode@gnu.org; Tue, 24 Apr 2012 22:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMrj9-0000q5-W7 for emacs-orgmode@gnu.org; Tue, 24 Apr 2012 22:13:09 -0400 Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:65279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMrj9-0000px-OB for emacs-orgmode@gnu.org; Tue, 24 Apr 2012 22:13:07 -0400 Received: by lagz14 with SMTP id z14so1196657lag.0 for ; Tue, 24 Apr 2012 19:13:05 -0700 (PDT) In-Reply-To: <9494.1334894889@alphaville> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: eric.schulte@gmail.com, emacs-orgmode@gnu.org --f46d040712075c662804be77694e Content-Type: text/plain; charset=ISO-8859-1 I think I fixed the problem, but in reading up on how to contribute I haven't gotten git setup yet or the FSF contribution form done. Should I do that first before sharing the patch with the group? Meanwhile is there some sort of test suite to ensure contributions don't break existing features? ~>Bill On Thu, Apr 19, 2012 at 9:08 PM, Nick Dokos wrote: > Eric Schulte (cc:ed) implemented accumulating properties with commit > 3af89e696a32afcc39f2e3bdb6132ac588d530ae. The commit adds a function > org-update-property-plist which takes care of the '+' case in property > names. But as you observed, it does not seem to work. I don't really > understand what should be happening: what I do know is that when > org-entry-get calls the above function, the props parameter is nil, > whereas the function expects it to contain the inherited sestting. So it > may be that the function is expecting something that is not going to > happen or org-entry-get passes it the wrong thing somehow. I don't know > which > one of these two is correct (or perhaps some other thing is wrong), but > in any case there does seem to be a disconnect. > > Nick > --f46d040712075c662804be77694e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I think I fixed the problem, but in reading up o= n how to contribute I haven't gotten git setup yet or the FSF contribut= ion form done.=A0 Should I do that first before sharing the patch with the = group?

Meanwhile is there some sort of test suite to ensure contributions don&= #39;t break existing features?

~>Bill

On Thu, Apr 19, 2012 at 9:08 PM, Nick Dokos <nicholas.dokos@hp.= com> wrote:
Eric Schulte (cc:ed) implem= ented accumulating properties with commit
3af89e696a32afcc39f2e3bdb6132ac588d530ae. The commit adds a function
org-update-property-plist which takes care of the '+' case in prope= rty
names. But as you observed, it does not seem to work. I don't really understand what should be happening: what I do know is that when
org-entry-get calls the above function, the props parameter is nil,
whereas the function expects it to contain the inherited sestting. So it may be that the function is expecting something that is not going to
happen or org-entry-get passes it the wrong thing somehow. I don't know= which
one of these two is correct (or perhaps some other thing is wrong), but
in any case there does seem to be a disconnect.

Nick

--f46d040712075c662804be77694e--