From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wJB1NBEYX1+XbAAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 07:13:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iHPQLhEYX181AgAA1q6Kng (envelope-from ) for ; Mon, 14 Sep 2020 07:13:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58C099402DA for ; Mon, 14 Sep 2020 07:13:21 +0000 (UTC) Received: from localhost ([::1]:34716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHifu-0004uw-NJ for larch@yhetil.org; Mon, 14 Sep 2020 03:13:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHifZ-0004uj-JT for emacs-orgmode@gnu.org; Mon, 14 Sep 2020 03:12:57 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:41968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHifX-0001Iv-Tf; Mon, 14 Sep 2020 03:12:57 -0400 Received: by mail-oi1-x243.google.com with SMTP id x69so16789124oia.8; Mon, 14 Sep 2020 00:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oPjB1i+bT0YhPhymu6NF1iULb2lTMb8we9ysidhpnAc=; b=B23YAxi1MrvOCYhV0UVcTuzJGDiPBp6QXW4gxRn/3M/6X2lAZqR5SI8WR31gM3a6jM SWyMRGs028y49OGs58IB0HjFhrEUAKBVsih0FAbzCV1vdY6Vdy7b/o2vzSsWweSjGJ72 d5WcOeoB85m/h7tcL5QcGPQqu9pHe8KdISwUkW+gakUJoa4aw56EuKtrdehx3GsJpAKn 59NhNJFkE9IywweWX8YRB9HtuPAxYMnl+lSqboynEDyUgLi/3SA7kChl7caJUKBNfLiA UGvMY7NrpkRX8uKWystJxf6wJlOSXVu/4UqXJeU3iE5eatTj/jHiLrfRisjoPz5Lk/1S gUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oPjB1i+bT0YhPhymu6NF1iULb2lTMb8we9ysidhpnAc=; b=heK7LN6K8qNJrgbZlAvnb07hKIMyHns9gTHSx+axQvtzVT7pE93ugieCDt7YB6gIhE ET8uZOdoWLQC4dvGaCcNICIRyuCRLWlLq+G5krcJ/xKPlOkLqChv6bUNaJT5iBmD6uIq pJHqySHhaZ4x2tr/1qB6blLH1dWypaASmlCo/G4QSCREoVOhGsbP168jJBUXvZUvpxqc VlEUoZjwdv+zxyZt0rXaVXP+H4l5IBkXJlqz+jXnI2H2CX4q+zIbuTFbR6Otf6uYiZLX 6kkBE6aqko5CMzSd2JBHxSPZUdQ9jLy9jxRYK9AUNzMS71DHWKK5vjNsBkcR00ybc28X VrGw== X-Gm-Message-State: AOAM530m7k6tdLurfCNcdAFzlWs6EoACMBUoj5ceXO0UZNPzisqv3ljG w641njtHZ0/KpPk8AaFUL4arfiUhw3gRGOOxLuw3JuRJIX9G X-Google-Smtp-Source: ABdhPJwe0W5UCvXEOV6bPB/x0c6YrnaPqHevJq8GrgwRRFWSCOugu+DmJAuXNIAb7rwYhMzv+8sbhmXDW7bMcHteMmA= X-Received: by 2002:a05:6808:1ce:: with SMTP id x14mr8065394oic.133.1600067573894; Mon, 14 Sep 2020 00:12:53 -0700 (PDT) MIME-Version: 1.0 References: <87363llhmw.fsf@gnu.org> In-Reply-To: <87363llhmw.fsf@gnu.org> From: Marlin Strub Date: Mon, 14 Sep 2020 09:12:42 +0200 Message-ID: Subject: Re: [PATCH] org.el: Adapt org-cycle to work with headlines with hidden stars To: Bastien Content-Type: multipart/alternative; boundary="0000000000005bd28905af40c3f9" Received-SPF: pass client-ip=2607:f8b0:4864:20::243; envelope-from=marlin.strub@gmail.com; helo=mail-oi1-x243.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=B23YAxi1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: W3iq8/iVgsit --0000000000005bd28905af40c3f9 Content-Type: text/plain; charset="UTF-8" Hi Bastien, Thanks for looking into this. I just tested with 9c31cba00 and org-cycle does not work reliably when org-starless-mode is enabled unless the patch is applied. Best, Marlin On Sun, 13 Sep 2020 at 19:18, Bastien wrote: > Hi Marlin, > > Marlin Strub writes: > > > I looked into using text properties to hide all the stars in org > > headings (with org-starless-mode [1]), > > and noticed that `org-cycle' didn't reliably cycle the visibility of > > headings anymore. > > there was a recent fix for this in the master branch: can you test > latest Org (from master) and see if your fix is still needed? > > Thanks a lot, > > -- > Bastien > --0000000000005bd28905af40c3f9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Bastien,

Thanks for looking int= o this. I just tested with=C2=A09c31cba00 and
org-cycle does not = work reliably when org-starless-mode is
enabled unless the patch = is applied.

Best,
Marlin

=
On Sun, 13= Sep 2020 at 19:18, Bastien <bzg@gnu.org<= /a>> wrote:
H= i Marlin,

Marlin Strub <
marlin.strub@gmail.com> writes:

> I looked into using text properties to hide all the stars in org
> headings (with org-starless-mode [1]),
> and noticed that `org-cycle' didn't reliably cycle the visibil= ity of
> headings anymore.

there was a recent fix for this in the master branch: can you test
latest Org (from master) and see if your fix is still needed?

Thanks a lot,

--
=C2=A0Bastien
--0000000000005bd28905af40c3f9--