From: Bhavin Gandhi <bhavin7392@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note
Date: Sun, 3 Jul 2022 22:40:12 +0530 [thread overview]
Message-ID: <CAOn=hbdvjjJP04Tv2MtdjtEMhHCZmfXJ+ACGKrZWk=KaNoCC8A@mail.gmail.com> (raw)
In-Reply-To: <87y1xdk2a7.fsf@localhost>
On Fri, 1 Jul 2022 at 07:43, Ihor Radchenko <yantar92@gmail.com> wrote:
> > Currently, when we call `org-auto-repeat-maybe', it adds
> > `org-add-log-note' to post-command-hook using `org-add-log-setup'. As
> > soon as we reach the question about 10 repeater intervals (the call to
> > `y-or-n-p' from `org-auto-repeat-maybe'), the post-command-hook gets
> > executed.[1]
>
> Bhavin, did you have a chance to send a bug report on this to Emacs
> devs?
Haven't done that yet. But it seems like we will have to find a fix to make
sure `delete-other-windows' is not called for the minibuffer.
My modified example:
(defvar my-hook-counter)
(defun my-test-command ()
(interactive)
(message "my-test-command: setting post-command-hook")
(setq my-hook-counter 3)
(add-hook 'post-command-hook 'my-own-hook)
(y-or-n-p "Some question: ")
(message "my-test-command: message after setting the hook")
)
(defun my-own-hook ()
(print (format "hook: this: %s, real: %s, last: %s" this-command
real-this-command last-command))
(message "my-own-hook: hopefully executing at the end")
(setq my-hook-counter (- my-hook-counter 1))
(if (eq my-hook-counter 0)
(remove-hook 'post-command-hook 'my-own-hook))
)
While looking at the *Messages* buffer, I came across the command
y-or-n-p-insert-y. There are commands for n, and other keys. When we
press y, M-p etc, these commands get executed. So, even if we manage to
fix the initial example in Emacs, the hook will still run while one is
in the minibuffer.
--
Bhavin Gandhi (bhavin192) | https://geeksocket.in
next prev parent reply other threads:[~2022-07-03 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 15:48 Org Agenda Error Michael Powe
2022-06-12 17:46 ` Bhavin Gandhi
2022-06-13 3:29 ` Michael Powe
2022-06-13 17:31 ` Bhavin Gandhi
2022-06-18 18:00 ` [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note Bhavin Gandhi
2022-07-01 2:14 ` Ihor Radchenko
2022-07-03 17:10 ` Bhavin Gandhi [this message]
2022-07-04 12:03 ` Ihor Radchenko
2022-07-10 17:23 ` Bhavin Gandhi
2022-07-11 1:57 ` Ihor Radchenko
2022-07-14 15:22 ` Bhavin Gandhi
2022-07-16 9:21 ` Ihor Radchenko
2022-07-21 18:03 ` Bhavin Gandhi
2022-07-26 11:49 ` Ihor Radchenko
2022-08-16 18:17 ` Bhavin Gandhi
2022-08-17 9:45 ` Ihor Radchenko
2022-09-01 9:48 ` Bastien Guerry
2022-09-25 18:16 ` Bhavin Gandhi
2022-09-26 12:46 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOn=hbdvjjJP04Tv2MtdjtEMhHCZmfXJ+ACGKrZWk=KaNoCC8A@mail.gmail.com' \
--to=bhavin7392@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).