From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +BxzCQ020GIMUgAAbAwnHQ (envelope-from ) for ; Thu, 14 Jul 2022 17:28:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YNsRCA020GL6BgEAG6o9tA (envelope-from ) for ; Thu, 14 Jul 2022 17:28:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE011D498 for ; Thu, 14 Jul 2022 17:28:12 +0200 (CEST) Received: from localhost ([::1]:39266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC0l9-0000kr-VQ for larch@yhetil.org; Thu, 14 Jul 2022 11:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0ft-00034T-OH for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 11:22:46 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:46815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oC0fs-000342-4z for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 11:22:45 -0400 Received: by mail-ej1-x634.google.com with SMTP id ez10so3980592ejc.13 for ; Thu, 14 Jul 2022 08:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/q0E3UaSBwd+lI5q+UU5bnjc08fFGQ9Nr8DHy4extAg=; b=bYXg+UWNlgnB1xt4iou2ogWnoN4PQljuh6qOnuj8/LD3msAMAhWTLsd0BEDnMRPj9H o3Tbp2EDw7oQnExSp8yIhcC28jo1NngcNrPc2C1UVAHRMQYNCTXdMvWBEmf5L7u9wdbw TCoaiLBEtsAkWi00I+q/c0rZfabSBxoqCa1202IEqaaiNmcwlDLrZvOBeGopUQmj8w89 hAwh1kwUOfCEjqW07xpTckStQNUOORxmC6sCRX+8PfTHEnt9emxNceTGNKm+ZbJ0AFmU WZpkVDhyzbOKGGQlIZN/C+Jqq2mODPaxlU2CGf6uzDtTsTW65InuUqAurHxmKr/4UDfC junQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/q0E3UaSBwd+lI5q+UU5bnjc08fFGQ9Nr8DHy4extAg=; b=d37K9dLa/PHHj0xC2c+6GrbpqnO79udsxgk7FrYwpqDzBOsxsN3feG7R6yjGl6H0aK uV5bMUHuI+twmKJbvEJD2+xfzLVzfGLazMNVmDC1l5BNT/xn28L9dJAYPUk+1YP2onjD SXk8eCFCvHYa+2nQexttBsH/dpNQfenObaZEv20JmeO1mTIj+cXZLC99prBioN1BFhP0 OCjHzwF9GLxvD2LUmoXGslcBjFkbUCelVXkM9mfOw9FWLfbe2SATYei3u+LerfM760Kq +Ktj+220DnSMDH2nGXcZ8MqZFgV7uc70zuSSFM1xcM6E9BqlWhYx8zIl+uHryU7b/EiI LMfw== X-Gm-Message-State: AJIora/fjiRXS0ERtZerx5Mp3q+ljxJdL2ZyW08p3vPSy4Cu/GE5GINT 4KtAYCAMt+cManTgVtkvT90RMoullr4UrMx+9es= X-Google-Smtp-Source: AGRyM1v0/ZxC3Z9f7XNUMraJSGeGVZYjAGsWgsRDZ/spoa3KPdU7Y5GFkzy+4R/q2LhJB1ceKHlgbwqgV/xxmnMVCxs= X-Received: by 2002:a17:907:a042:b0:72b:4fac:1ddf with SMTP id gz2-20020a170907a04200b0072b4fac1ddfmr9519371ejc.285.1657812161323; Thu, 14 Jul 2022 08:22:41 -0700 (PDT) MIME-Version: 1.0 References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net> <87y1xdk2a7.fsf@localhost> <87bku5nkz2.fsf@localhost> <8735f8s96b.fsf@localhost> In-Reply-To: <8735f8s96b.fsf@localhost> From: Bhavin Gandhi Date: Thu, 14 Jul 2022 20:52:04 +0530 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BBUG=5D_org=2Dauto=2Drepeat=2Dmaybe=3A_error_=22Can=E2=80=99t_expa?= =?UTF-8?Q?nd_minibuffer_to_full_frame=22_and_missing_log_note?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=bhavin7392@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657812492; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/q0E3UaSBwd+lI5q+UU5bnjc08fFGQ9Nr8DHy4extAg=; b=Vs+AesujpfqcQImBrkx4nPgQObk0vckcBei+9XaFq7DXVJRmTXfcqRolURVrj0dMlWnoJa Hc7lsZmLYWuiJkv7SA/pwaSqAaHO4Z9BP6LuxMkS2xKGbsKMRZX3Hyf35r0Bcv9WpcrtjF UuKD7HXEDQYsBTaXJAQpkIU4DdDmiWuGoSRdt53lKmZoa6gTyocEuNrRQhAhXqFeHM5ZxS FdYBbT9v8DqtPDSNSPEdkSTwusDYQOBDv5JpDg366T/iCRHBwylSnGf5n/aSrbpcYWOJri rSoTvAr06YtJcQmECVmOqThRB8Iu0g37doiz9Be4trhuvxFHe0a41h4wGftQyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657812492; a=rsa-sha256; cv=none; b=f+H96VDh1zHlFp6ExMwqZBv8xj2jZkHo2Kxa0llP/jtSFWETN7sBCLJ8fb3SDQkJoqQTtG 1d4ylk77QXwynTqrFt3Kpwk7YiaZgbcePMLTO01VqQyHbxmyGjLmycRpshOJ9IQYs1kDjq u5o2UoTiMtqIQR/YdR6wJczX40kURrkIW/hJ/7ibFUKoFUnCLsPLGb6PXfJy2JyXNw8gom BGqlCvq/HuX3dt0aCB9etdfxjR2oXiqoZm8JPbWoIalcQSCEaRpmcRYNxvTPTbYZ7AdiS9 HJy0kGZxUUVGiljjH1ngPcE3MiHsM1cuA+5sRf88XbT8haWvF+HGdHnofwR1sQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bYXg+UWN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bYXg+UWN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BE011D498 X-Spam-Score: -8.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: iV8pLIpHCS81 On Mon, 11 Jul 2022 at 07:26, Ihor Radchenko wrote: > > Bhavin Gandhi writes: > > >> A better fix may relate to the fact that org-add-log-setup is usually > >> used to run org-add-log-note at the end of current command. y-or-n-p or > >> any other kind of command (e.g. added via advice) will break this > >> assumption we use. So, org-add-log-setup could also store > >> `this-command', say, in `org-log-note-this-command' and > >> `org-add-log-note' can then execute only when `this-command' is the same > >> with `org-log-note-this-command'. WDYT? > > > > I had something similar in my mind, something like we check if > > this-command is org-* (not very robust). Your idea makes sense to > > me. But this won't work when read-from-minibuffer is called as it > > doesn't seem to change this-command when it runs. > > Then, we will also need to save (recursion-depth) value and check for it > in addition to this-command. Thanks for the idea, I'm exploring (recursion-depth), (minibuffer-depth). I will come up with a patch to fix this bug. Seems like soon I will cross the TINYCHANGE limit, so I will get the FSF copyright assignment done. -- Bhavin Gandhi (bhavin192) | https://geeksocket.in