From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YFtKCSATrmJ6FwAAbAwnHQ (envelope-from ) for ; Sat, 18 Jun 2022 20:02:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MDLqCCATrmLyEAAAauVa8A (envelope-from ) for ; Sat, 18 Jun 2022 20:02:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A896221D06 for ; Sat, 18 Jun 2022 20:02:07 +0200 (CEST) Received: from localhost ([::1]:42802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2clq-0005Bc-FU for larch@yhetil.org; Sat, 18 Jun 2022 14:02:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2clI-0005BH-1S for emacs-orgmode@gnu.org; Sat, 18 Jun 2022 14:01:32 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:39821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2clF-0003mr-OO for emacs-orgmode@gnu.org; Sat, 18 Jun 2022 14:01:31 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id r3so12325551ybr.6 for ; Sat, 18 Jun 2022 11:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cUO5vVvdals6ZBZ+F5fhPdlkoMX46g/aYiyM3npvcVk=; b=da+x3Zuc6EKwjzgiB7xZL7DRT2yMMXWIKidNMXrCQNav9IIW54KtSr8GQFh8xXCfwh aP5sx0uGV292VqBw0N9QskRDjSyM2edHfUxqlZrOOKwB5PXFI1MvUm/8Y4J6gihVu5EV YUY4JLtHY3GebY3Gwc8InUCqibSV5w+rpfaegyTNc0mNyLD/ZKCWDER4Lg06JQ6nDhs0 nSwfBA8OBhgd2hR/EGabuQdPV7ybnLKFZvUdtHUQWjQ6wIpGDWJYgHkowPfegTTP1k1k pWTPsiZqneId5iE+MOx+WrwD0q3ZIDUm/4XCRd2VOy/xyUgDRGooVkgNqpT/WvBCS7Kg ADMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cUO5vVvdals6ZBZ+F5fhPdlkoMX46g/aYiyM3npvcVk=; b=biVtSAqjp1HLgHXqVJvlwD5ALH+GGumjISmrxkJiESr+RWUfp69vmc8ezWxr9jtq6n qwnsTYgjbHMQnLGftFr0hdqT33JzYSkl7pmU4fzu7P1r1SRn6YJ5gMhbGwj7KOXlRUq5 t//1dV2szSJed9qj8PCOINWMJva0Bx7vXWL60aBtRKHq/YXhuPZb8uMooZnUTA3f6VFI btHjdQDouQ+uV0ENr/UGL5FlMYYXqjNoxYQ0q2An9eoGdFGAZhSI+gvjf27oPnYeshps mYMXSIlJaccejesql64IcivSKoH+nP8bRKWG8zmIaFSVzz6gldxcraQYqQxPvKD9OjeI q/dw== X-Gm-Message-State: AJIora/1260awfuskqXPhqtldsb9viPqdhkWWxsHl8dqb/zSXtxNFjrF y0R2Z3UtyDKm9NYdGDe8yXYOZaUYSGlzXmpugT1CpVCUu/qnLQ== X-Google-Smtp-Source: AGRyM1t0qfrGBQlXcp1tXviyWI2IrBLRzpytzcii/RWCayHxbiTR/ez3BX6SRN/reHCPG5sbc5jt2HX84seBq7Aj36A= X-Received: by 2002:a25:b9c3:0:b0:668:a418:13c with SMTP id y3-20020a25b9c3000000b00668a418013cmr13961248ybj.498.1655575288093; Sat, 18 Jun 2022 11:01:28 -0700 (PDT) MIME-Version: 1.0 References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net> In-Reply-To: From: Bhavin Gandhi Date: Sat, 18 Jun 2022 23:30:50 +0530 Message-ID: Subject: =?UTF-8?Q?=5BBUG=5D_org=2Dauto=2Drepeat=2Dmaybe=3A_error_=22Can=E2=80=99t_expand_m?= =?UTF-8?Q?inibuffer_to_full_frame=22_and_missing_log_note?= To: Michael Powe Cc: emacs-orgmode@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a; envelope-from=bhavin7392@gmail.com; helo=mail-yb1-xb2a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655575327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cUO5vVvdals6ZBZ+F5fhPdlkoMX46g/aYiyM3npvcVk=; b=HGTtp/z1zUQIS+PeYPXArhyHAhUcDgspa8WHDtc33AhyBUDiTkn9HsHFQ6hh4fzlDoOB6O 5tBlOlLC9vLpoWIo57bi8SbUvlnRxgUJ5W5mXAwTR0MBybiuVnJBWHH5jCTsgSFXD1DNH9 jX07Egz3PLeoPhJcP6DwlYh6KCH4GeTGVxbeHJAzzfrdlxfRS5s82cbFaKn6dossn3yxT1 5eRpR16PHZQrDe8a2kK7uiaBu+MOqLQr/hLkbWcGdEZ1tCO5q9aMB8bBYziKkenWggB06Z wDf9t2bi5D2KVAEU/33vyMQDAvNOqxBVxjGH+sgPT3vRbUJ5nJ5NwkRQOXa1CQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655575327; a=rsa-sha256; cv=none; b=F/H/kCOruxhbODaiVJwWi7N5Iobwfd78AjnwU6cqC7T+hmxKIUm6aZ27UIluUvDfGtjveZ m51WHfO3fGiR/NmP17fPjqAYa2jKdvvAXxum/rKdejghq6IQRAAs7crfGnMZBr2tuKZPIf eOFUxe7EdaHR2NdN+1UcNdExKpYx14qgT/zXIwflhfzbihZEWcyHum2pwFpq8DOPnRMeIf KmhlBmjCkXQnsIf6hMxLHCUDlm/DPpPRmEt8p4fwcgyFLZFGpE50VcngTSqO5uVr0l9/VM DwUJdT6a+BWH5UcNbt6kBqWgMjOwya/ryPjOCR3MhThPZ6vFxmbHvqqqd3AdUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=da+x3Zuc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.29 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=da+x3Zuc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A896221D06 X-Spam-Score: -9.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: x36Fpjl33rPU On Mon, 13 Jun 2022 at 23:01, Bhavin Gandhi wrote: > > 1. emacs -Q > > 2. Create test.org with following content > > > > * TODO Repeating entry > > SCHEDULED: <2022-05-01 Mon ++2d> > > > > 3. C-c C-t on the entry, shows the above error. And shifts the schedule= d > > date correctly. > > When this error appears, the log note entry about state change is not > added. I found this issue for the first time when I saw the state > change log notes were missing. > > If I do C-c C-t again on the same entry, we get the note. > - State "DONE" from "TODO" [2022-06-13 Mon 22:48] > > This is missing when we hit the error mentioned in the first mail. Confirmed. Trying to change the subject for Woof! for the first time, I hope I get it right. I remember reading this code around a year back, where we were fixing two bugs. 1. Bug: Duplicate logbook entry for repeated tasks: https://list.orgmode.org/orgmode/CAOn=3DhbcaW1R6vtun-E2r4LS=3Dj3dp=3DVjq= mjGtzy8UC1SyPArKbA@mail.gmail.com/ 2. Bug: org-agenda-undo does not work with repeated tasks [9.4]: https://list.orgmode.org/87v98a8mes.fsf@gnu.org/ Currently, when we call `org-auto-repeat-maybe', it adds `org-add-log-note' to post-command-hook using `org-add-log-setup'. As soon as we reach the question about 10 repeater intervals (the call to `y-or-n-p' from `org-auto-repeat-maybe'), the post-command-hook gets executed.[1] So, we end up calling `delete-other-windows' while we are waiting for the user to respond with y/n. And this causes error "Can=E2=80=99t expand minibuffer to full frame". I don't know how to fix this issue yet, but I'm planning to add a test case for completing repeating tasks which need 10+ repeating intervals to shift the date. Maybe this is off-topic: I'm not sure why [1] happens, my assumption was Emacs will wait till all the functions finish executing, and then run the post-command-hooks. this-command remains org-todo (C-c C-t) throughout all the other calls done by org-todo as long as they are not commands i.e. org-auto-repeat-maybe etc. So, I tried following snippet: (defun my-test-command () (interactive) (message "my-test-command: setting post-command-hook") (add-hook 'post-command-hook 'my-own-hook) (y-or-n-p "Some question: ") (message "my-test-command: message after setting the hook") ) (defun my-own-hook () (remove-hook 'post-command-hook 'my-own-hook) (message "my-own-hook: hopefully executing at the end") ) In this case as well, as soon as it calls y-or-n-p, I can see "my-own-hook: hopefully executing at the end" in the minibuffer (while it is still waiting for user input). Is it expected? I read (info "(elisp)Command Overview") but couldn't understand this behavior. --=20 Bhavin Gandhi (bhavin192) | https://geeksocket.in