From: Bhavin Gandhi <bhavin7392@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note
Date: Tue, 16 Aug 2022 23:47:01 +0530 [thread overview]
Message-ID: <CAOn=hbcg8ZvGRBLXfNJYtzdXdjsG+qes7ovw8jEBP9Xxt_a6eA@mail.gmail.com> (raw)
In-Reply-To: <871qu8ccvr.fsf@localhost>
On Thu, 21 Jul 2022 at 23:33, Bhavin Gandhi <bhavin7392@gmail.com> wrote:
>
> On Sat, 16 Jul 2022 at 14:50, Ihor Radchenko <yantar92@gmail.com> wrote:
> > > Seems like soon I will cross the TINYCHANGE limit, so I will get the
> > > FSF copyright assignment done.
> >
> > Note that FSF should reply within 5 working days. If not, we can help
> > you to push them.
>
> Thanks! I received the PDF to sign the next day after my email, this
> will probably take a couple of days more from my side as I'm talking
> with my employer.
I finally got this done. I now have a fully executed copy of the copyright
assignment (signed by FSF and me). Do I need to send it to someone so
that they can check and update the page at
https://orgmode.org/worg/contributors.html ?
On Tue, 26 Jul 2022 at 17:18, Ihor Radchenko <yantar92@gmail.com> wrote:
> >
> > So, I saved this-command and (recursion-depth) value, and I'm checking
> > for it in the org-add-log-note (attaching diff of my changes). But this
> > doesn't guarantee that we are not in the minibuffer when the
> > post-command-hook runs.
> >
> > This is what I did, and it failed after answering the question about 10
> > repeated intervals:
> > 1. M-: (y-or-n-p "Some question")
> > 2. Now I switched to Org mode buffer.
> > 3. Did C-c C-t on the entry.
> >
> > When org-log-add-setup runs, (recursion-depth) is 1, and
> > (minibuffer-depth) is also 1.
> > Now, the question about 10 repeated intervals is asked, once I answer
> > it, post-command-hook runs. And it runs while we are in the minibuffer
> > waiting for 'Some question'.
>
> Yikes! Then, can also check for window-minibuffer-p, but I feel that it
> will be a fight against all kinds of edge cases.
I haven't been able to make much progress on this bug in the last two
weeks. Will try to send a patch in a few days, as the steps I gave above
feels like an edge case which we won't see happening hopefully.
--
Bhavin Gandhi (bhavin192) | https://geeksocket.in
next prev parent reply other threads:[~2022-08-16 18:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 15:48 Org Agenda Error Michael Powe
2022-06-12 17:46 ` Bhavin Gandhi
2022-06-13 3:29 ` Michael Powe
2022-06-13 17:31 ` Bhavin Gandhi
2022-06-18 18:00 ` [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note Bhavin Gandhi
2022-07-01 2:14 ` Ihor Radchenko
2022-07-03 17:10 ` Bhavin Gandhi
2022-07-04 12:03 ` Ihor Radchenko
2022-07-10 17:23 ` Bhavin Gandhi
2022-07-11 1:57 ` Ihor Radchenko
2022-07-14 15:22 ` Bhavin Gandhi
2022-07-16 9:21 ` Ihor Radchenko
2022-07-21 18:03 ` Bhavin Gandhi
2022-07-26 11:49 ` Ihor Radchenko
2022-08-16 18:17 ` Bhavin Gandhi [this message]
2022-08-17 9:45 ` Ihor Radchenko
2022-09-01 9:48 ` Bastien Guerry
2022-09-25 18:16 ` Bhavin Gandhi
2022-09-26 12:46 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOn=hbcg8ZvGRBLXfNJYtzdXdjsG+qes7ovw8jEBP9Xxt_a6eA@mail.gmail.com' \
--to=bhavin7392@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).