From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WI4kHU3Wq2AtMwAAgWs5BA (envelope-from ) for ; Mon, 24 May 2021 18:37:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GP3RGE3Wq2DWewAA1q6Kng (envelope-from ) for ; Mon, 24 May 2021 16:37:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71FD821116 for ; Mon, 24 May 2021 18:37:32 +0200 (CEST) Received: from localhost ([::1]:45850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llDa7-0005XL-Eo for larch@yhetil.org; Mon, 24 May 2021 12:37:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDXv-0005Sy-U0 for emacs-orgmode@gnu.org; Mon, 24 May 2021 12:35:16 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:40485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llDXt-0002FB-TZ for emacs-orgmode@gnu.org; Mon, 24 May 2021 12:35:15 -0400 Received: by mail-lf1-x135.google.com with SMTP id w33so33569709lfu.7 for ; Mon, 24 May 2021 09:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jbHRbMf1eLT2iD00XjDiUF/PT2Hn/rdqcb8eXsOhwJ4=; b=BA7PuYvi6wbXnnOwcABBNHhZKoiLdkA+tqEGKyzcYdzYDbL2QTrObiqxtgUtcEPrxY 8doFOW726GNQhX+H22HRPSNnVofNcIqn7fujmwuQJjxp9clgnkvnZEnmThjHZ3I1G094 iVJzk5jYDNnb0GBpJkPJdtKJr10MKt9vl4iBKlidZDV4KWBAPzHG8r7JdXKFzxTeobpK SZIQ9MIQtBoDzlPyD+On1Q273dKIRgH4yulWnyZqMp7Onjb6qd++G/4c7SBJGrwTUzU1 0TcTWLGCbkCncmNqeQdRW2waEWnpjRFisjTZr1Ma6VC0EVjoHRcpNLSsS5ASNH9Oct8G ItQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jbHRbMf1eLT2iD00XjDiUF/PT2Hn/rdqcb8eXsOhwJ4=; b=fowMztQ9/tEKZZd1nj7sQ2IFq39b1V2G3ljhQjoi+RESqhJlJ+5xsk9Oa3XnN++BE6 EPsGG1qn3kkmUl9kljUiQYbuAHOOnZzc781ZT3RypMDuDqgPLFm+N+IQmWqcmKtWezVn QC2Is10nqBkN4gyHn9HvMNWlEpnVlsPYgRRfftg+O8/7cMp3ILV3fOJYopNKzruT/T18 uuxRHog4LGRfSpDanjdCMllr4GlyK6Uv295zVRO6o9JZ72WRaTVCPQKHsACrCx5agUBl nUCSRteSnJRklcWD7+lvr2WhIFtN2lKSuKreN5vHg9YyYxHY6Y6SL7jb01xTaLjBiCvi r5Mg== X-Gm-Message-State: AOAM533TXb1EL+dvEiVBKMYyjJTFwrei8ldySkrWlQMpEoHeTYNw/Oq9 403suZNhglLWKwo3Z7TUF81P3GDqV/Ok0s2lr+E= X-Google-Smtp-Source: ABdhPJxGGhKNg3jygH3umLHnQqdBfp/6MmgLGnbRXH/vNB8xL4wZ0+YJGi+/jj1kmnIEs8IBy+rc1VJjNHxi/XSUyVM= X-Received: by 2002:a05:6512:22d2:: with SMTP id g18mr10510375lfu.376.1621874111943; Mon, 24 May 2021 09:35:11 -0700 (PDT) MIME-Version: 1.0 References: <87sg2ds2e0.fsf@gmail.com> In-Reply-To: <87sg2ds2e0.fsf@gmail.com> From: Bhavin Gandhi Date: Mon, 24 May 2021 22:04:35 +0530 Message-ID: Subject: Re: Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)] To: Gustavo Barros , tecosaur@gmail.com Content-Type: multipart/mixed; boundary="0000000000005064e505c315fe06" Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=bhavin7392@gmail.com; helo=mail-lf1-x135.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621874252; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NfMGfoteLOUMsuQlXek7nZeOQ8rekJCJmrz7IJb9ltI=; b=oYI9OFYJ/5YpBjXEHtFA6MTxaZePjb3jz0cjQwcJ8hcXqFo5gJJACYRFsK0HseuDFSGWga gZzDIKmjzaZQ2ZpFdzdeq0JAbkzjU59SOXa6Qq9KALajUGBt4jG4r1yeN2Au+cZGdJdxOn 2FUkl7sIBNeS8jAsPjxkjbFG5wwOnES1KeDwkXwaaJUatvlav7VOclIXtaXcybVpRa5+ix R/kBNwKxyzP4NsxN4nhDUPaVTuGuSkdxnYbkDbcNbMq/9xZWRyaJ+N1CjYm59adMnAjkE+ CRxkNEdZAYbpGBx3PQOUTJgd/PRguSkJsPZJ4Go3GMxYIRdUTKvGkOZm+/OD1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621874252; a=rsa-sha256; cv=none; b=ebOK0EmyZmsUWrC4r4YZlrRIFiwix60Cl7cp3pWJjvq0fmZTNUhHGoiaeOR1aBs+dF3jNW QntOiN0ihbMVqh9ub3+4A3dWaNJZNsTZRL19Y/n3+85HEaQERmLbaq9eoFHmuEmQ6D/y7Z TT4Mi3h8fipsy6LLbjRSgN/zlJEWkIfRkUw1mF0TqOUxIhwM6l54h6Ziif4FXlrLXuFemz hGd3/bxs25wFUa1TPBTYHpuBozvUekVtB6sy2O3YSxrtOEz11lNnXsE/Ao2lnrhee5g0E9 K8iwZBcTHEhbn9DSsBG49dwLcbXQLHdwzC/OJFTbSpPVJUvzmBynnkhZAeDeJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=BA7PuYvi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=BA7PuYvi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 71FD821116 X-Spam-Score: -0.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: L0SCTNO/Ra/x --0000000000005064e505c315fe06 Content-Type: multipart/alternative; boundary="0000000000005064e205c315fe04" --0000000000005064e205c315fe04 Content-Type: text/plain; charset="UTF-8" On Sun, 23 May 2021 at 23:53, Timothy wrote: > > Hi Bhavin! Great to see you on the mailing list :) > > Thank you so much for looking at the bugs, investigating one, /and/ > working out a fix. That's absolutely fantastic of you! Thank you for a welcoming message! :) On Mon, 24 May 2021 at 00:28, Gustavo Barros wrote: > > The patch looks good to me, and corresponds to my analysis of the > problem and suggested fix. I have only one minor nitpick: you could go > with a simple `let' there, instead of a `let*', since we only have one > let-bound variable there anyway. Yes, I have attached an updated patch. > > [...] it has other details as well. > > As far as I could see, we are very much aligned on the problem and fix. > But perhaps I'm missing something, could you elaborate on that? We are indeed aligned. The only additional thing I discovered was the reason `org-refile--get-location' works despite having double slashes. That was new for me. Just experimenting with Woof! X-Woof-Patch: confirmed --0000000000005064e205c315fe04 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, 23 May 2021 at 23:53, Timothy wrote:
>
&g= t; Hi Bhavin! Great to see you on the mailing list :)
>
> Thank= you so much for looking at the bugs, investigating one, /and/
> work= ing out a fix. That's absolutely fantastic of you!

Thank you for= a welcoming message! :)


On Mon, 24 May 2021 at 00:28, Gustavo B= arros wrote:
>
> The patch looks good to me, and corresponds to= my analysis of the
> problem and suggested fix.=C2=A0 I have only on= e minor nitpick: you could go
> with a simple `let' there, instea= d of a `let*', since we only have one
> let-bound variable there = anyway.

Yes, I have attached an updated patch.

> > [...= ] it has other details as well.
>
> As far as I could see, we a= re very much aligned on the problem and fix.
> But perhaps I'm mi= ssing something, could you elaborate on that?

We are indeed aligned.= The only additional thing I discovered was
the reason `org-refile--get-= location' works despite having double
slashes. That was new for me.<= br>
Just experimenting with Woof!
X-Woof-Patch: confirmed
--0000000000005064e205c315fe04-- --0000000000005064e505c315fe06 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-org-refile-Fix-double-slashes-in-the-refile-targets.patch" Content-Disposition: attachment; filename="0001-org-refile-Fix-double-slashes-in-the-refile-targets.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kp2tt4od0 RnJvbSBlMDY5YzM1ZmY2MDExYTdmOWVmZTM3MmU2NzVhMGJjNDNiYTFmYTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGF2aW4gR2FuZGhpIDxiaGF2aW4xOTJAZ2Vla3NvY2tldC5p bj4KRGF0ZTogU3VuLCAyMyBNYXkgMjAyMSAyMzowNzoxMyArMDUzMApTdWJqZWN0OiBbUEFUQ0hd IG9yZy1yZWZpbGU6IEZpeCBkb3VibGUgc2xhc2hlcyBpbiB0aGUgcmVmaWxlIHRhcmdldHMKCiog b3JnLXJlZmlsZS5lbCAob3JnLXJlZmlsZS1nZXQtbG9jYXRpb24pOiBXaGVuIHdlIGdlbmVyYXRl IHRoZSBgdGJsJwp2YXJpYWJsZSwgd2UgYWRkIGV4dHJhIHNsYXNoIGRlcGVuZGluZyBvbiB0aGUg dmFsdWUgb2YKYG9yZy1yZWZpbGUtdXNlLW91dGxpbmUtcGF0aCcuICBUaGlzIHBhdGNoIHVwZGF0 ZXMgc29tZSBsb2NhdGlvbnMgd2hpY2gKYWRkIGFub3RoZXIgZXh0cmEgc2xhc2ggYXNzdW1pbmcg dGhlIHRhcmdldCBkaWQgbm90IGhhdmUgaXQuCgpgb3JnLXJlZmlsZS0tZ2V0LWxvY2F0aW9uJyBk b2VzIGxvb2t1cCBmb3IgZW50cmllcyB3aXRoIGFuZCB3aXRob3V0CnNsYXNoLCBzbyBpdCB3YXMg bm90IGNhdXNpbmcgYW55IGlzc3VlcyBiZWZvcmUuICBJdCB3b3JrcyBhcyBpdCBpcyBub3cKYXMg d2VsbC4KClRoYW5rcyB0byBHdXN0YXZvIEJhcnJvcyBmb3IgYSB2ZXJ5IGRldGFpbGVkIGJ1ZyBy ZXBvcnQuCgpUSU5ZQ0hBTkdFCi0tLQogbGlzcC9vcmctcmVmaWxlLmVsIHwgMTAgKysrKy0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9saXNwL29yZy1yZWZpbGUuZWwgYi9saXNwL29yZy1yZWZpbGUuZWwKaW5kZXggYmZm YWQwYTgxLi42Nzg3NTllMTAgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLXJlZmlsZS5lbAorKysgYi9s aXNwL29yZy1yZWZpbGUuZWwKQEAgLTY0OSwyMCArNjQ5LDE4IEBAIHRoaXMgZnVuY3Rpb24gYXBw ZW5kcyB0aGUgZGVmYXVsdCB2YWx1ZSBmcm9tCiAgICAgKHNldHEgb2xkLWhpc3Qgb3JnLXJlZmls ZS1oaXN0b3J5KQogICAgIChzZXRxIGFuc3cgKGZ1bmNhbGwgY2Z1bmMgcHJvbXB0IHRibCBuaWwg KG5vdCBuZXctbm9kZXMpCiAJCQluaWwgJ29yZy1yZWZpbGUtaGlzdG9yeQotCQkJKG9yIGNkZWYg KGNvbmNhdCAoY2FyIG9yZy1yZWZpbGUtaGlzdG9yeSkgZXh0cmEpKSkpCisJCQkob3IgY2RlZiAo Y2FyIG9yZy1yZWZpbGUtaGlzdG9yeSkpKSkKICAgICAoaWYgKHNldHEgcGEgKG9yZy1yZWZpbGUt LWdldC1sb2NhdGlvbiBhbnN3IHRibCkpCi0JKGxldCogKChsYXN0LXJlZmlsZS1sb2MgKGNhciBv cmctcmVmaWxlLWhpc3RvcnkpKQotCSAgICAgICAobGFzdC1yZWZpbGUtbG9jLXBhdGggKGNvbmNh dCBsYXN0LXJlZmlsZS1sb2MgZXh0cmEpKSkKKwkobGV0ICgobGFzdC1yZWZpbGUtbG9jIChjYXIg b3JnLXJlZmlsZS1oaXN0b3J5KSkpCiAJICAob3JnLXJlZmlsZS1jaGVjay1wb3NpdGlvbiBwYSkK IAkgICh3aGVuIChvciAobm90IG9yZy1yZWZpbGUtaGlzdG9yeSkKIAkJICAgIChub3QgKGVxIG9s ZC1oaXN0IG9yZy1yZWZpbGUtaGlzdG9yeSkpCi0JCSAgICAobm90IChlcXVhbCAoY2FyIHBhKSBs YXN0LXJlZmlsZS1sb2MtcGF0aCkpKQorCQkgICAgKG5vdCAoZXF1YWwgKGNhciBwYSkgbGFzdC1y ZWZpbGUtbG9jKSkpCiAJICAgIChzZXRxIG9yZy1yZWZpbGUtaGlzdG9yeQogCQkgIChjb25zIChj YXIgcGEpIChpZiAoYXNzb2MgbGFzdC1yZWZpbGUtbG9jIHRibCkKIAkJCQkgICAgIG9yZy1yZWZp bGUtaGlzdG9yeQogCQkJCSAgIChjZHIgb3JnLXJlZmlsZS1oaXN0b3J5KSkpKQotCSAgICAod2hl biAob3IgKGVxdWFsIGxhc3QtcmVmaWxlLWxvYy1wYXRoIChudGggMSBvcmctcmVmaWxlLWhpc3Rv cnkpKQotCQkgICAgICAoZXF1YWwgbGFzdC1yZWZpbGUtbG9jIChudGggMSBvcmctcmVmaWxlLWhp c3RvcnkpKSkKKwkgICAgKHdoZW4gKGVxdWFsIGxhc3QtcmVmaWxlLWxvYyAobnRoIDEgb3JnLXJl ZmlsZS1oaXN0b3J5KSkKIAkgICAgICAocG9wIG9yZy1yZWZpbGUtaGlzdG9yeSkpKQogCSAgcGEp CiAgICAgICAoaWYgKHN0cmluZy1tYXRjaCAiXFxgXFwoLipcXCkvXFwoW14vXStcXClcXCciIGFu c3cpCi0tIAoyLjMxLjEKCg== --0000000000005064e505c315fe06--