Re: Org-info-js folding is broken in 8.3 releases

[Piyush Srivastava <piyushsriva@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2732 bytes --]

Of course, we will also need to change the regexp SID_REGEX (in
org-info-src.js) to "/(^#)((sec-|orgheadline)\d+([._]\d+)*$)/" from the
current value of "/(^#)(sec-\d+([._]\d+)*$)/".  It's capturing groups are
not used, to this should not propagate any more changes.

On Sat, Sep 5, 2015 at 8:20 PM, Piyush Srivastava <piyushsriva@gmail.com>
wrote:

> I think I have finally isolated a fix.  org-info.js uses the magic number
> "4" (i.e. the length of the string "sec-") to substring DOM ids in order to
> fin section numbers (this is on line number 97 in the source code of
> org-info-src.js).   However the changes to org-export-get-reference mean
> that instead of using the string "sec-" before the section heading, ox-html
> now used the string "orgheadline".  Thus, the fix is to replace "4" by
> "orgheadline".length in the source code of org-info-src.js.
>
> This seems to be the simplest way to fix this error.  However, as it is,
> it will break those people's code who are using the online version of the
> script.  We will probably need to detect what string the html file is using
> in the DOM id for headlines and used the length of that string.  I will try
> to write a patch in the next few days if this strategy sounds good.
>
> -- Piyush.
>
>
>
> On Sat, Sep 5, 2015 at 5:20 PM, Piyush Srivastava <piyushsriva@gmail.com>
> wrote:
>
>> In fact, further investigation shows that the first commit that actually
>> breaks org-info-js is the replacement of `org-export-get-headline-id' by
>> `org-export-get-reference' in commit id 459033 on April 13.  These problems
>> are temporarily fixed by commit cf7d64, and then reintroduced by commit
>> 4ee8f4 which reverted the changes made to org-export-get-reference in
>> cf7d64.
>>
>> -- Piyush.
>>
>>
>> On Sat, Sep 5, 2015 at 4:20 PM, Piyush Srivastava <piyushsriva@gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>>
>>> In the current 8.3.1 release of org-mode the f/F keybinding that
>>> org-info-js provides for folding headings in plain mode (of exported html
>>> files) fails to work.  Further, the 's' and 'o' keys for search and occur
>>> respectively also fail to work.  Both of these work with the 8.2.10 release.
>>>
>>> I have attached a minimal org-mode file with which I can reproduce this
>>> error.  By bisecting the commit history, I find that the breaking change is
>>> introduced by commit 4ee8f4 which has the following commit message:
>>>
>>> Author: Rasmus <rasmus@gmx.us>
>>> Date:   Sun Apr 19 16:00:06 2015 +0200
>>>
>>>     Revert "ox: Change label naming scheme"
>>>
>>>     This reverts commit cf7d64f1e456cad281674fc81a8074f969b7911c.
>>>
>>> The log produced by git bisect is also attached.
>>>
>>>
>>> Thanks,
>>> -- Piyush.
>>>
>>>
>>>
>>>
>>>
>>
>

[-- Attachment #2: Type: text/html, Size: 4145 bytes --]