From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iPyxHtjgT2He3wAAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 04:54:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kB5VGtjgT2GKFwAAbx9fmQ (envelope-from ) for ; Sun, 26 Sep 2021 02:54:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB68E2BA70 for ; Sun, 26 Sep 2021 04:54:15 +0200 (CEST) Received: from localhost ([::1]:46182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUKIw-0004QM-0U for larch@yhetil.org; Sat, 25 Sep 2021 22:54:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUKIF-0004QC-KJ for emacs-orgmode@gnu.org; Sat, 25 Sep 2021 22:53:31 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:40848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUKID-0006gu-RF; Sat, 25 Sep 2021 22:53:31 -0400 Received: by mail-lf1-f47.google.com with SMTP id b15so58137597lfe.7; Sat, 25 Sep 2021 19:53:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/3VlfCV8qqQ7aufZLDiDxEMLH3035QRZqaI4H4MVi4=; b=dcNyG6e7We7VclgtW9hmEOsowzSzVvR/MkZ51/i/q5ahxNAWKVT2S/t19ttUNSXrPx KY1GdwYWigTIRiKPol9m4Wwhvj7CM1ONG6xWjZDuFBFupZeJAThX0EAEfMYTiXZMnVoe L+MCmtyIm3XVvGkeYcbOs6JoZNqbWVbsT1Pu0jMFThkMlSQmeg6T1FPkkCoEXNEigjJq Wm4jxcY0zjoy545g44GeSf+1pCAkGEhz5Cg3DGft/DBrH2KpWID4RBkNv00JIZY8lEoL oq0h8M2RjdahptrYK1osl1fyw8GQ8/eHKPb1Iq3dt4kF84T+M9vkZY6a8v732gmDuy9i xgTw== X-Gm-Message-State: AOAM531XajHPt6SbwCIGk4HNqtSmEgyufOtK9wrrC6NSumtF8zj0dOQk h1GU1+OABcV6ADxKWfKGKra8/ofxxCLwTrpJVdpTxTtJ X-Google-Smtp-Source: ABdhPJxFmFa3+BNuckMS8fdXHddYPuoAh3Tm0iBOLRfUYQ9RNhsvSw8qt7G3ZdVKcAIawk7j0IntQcChGyqL6IxeQTA= X-Received: by 2002:a2e:8603:: with SMTP id a3mr20568508lji.142.1632624806103; Sat, 25 Sep 2021 19:53:26 -0700 (PDT) MIME-Version: 1.0 References: <87czr6uhhk.fsf@alphapapa.net> <878rzkcuao.fsf@gnu.org> In-Reply-To: <878rzkcuao.fsf@gnu.org> From: Adam Porter Date: Sat, 25 Sep 2021 21:53:15 -0500 Message-ID: Subject: Re: [BUG] 81c7a2dee8 misaligns time lines in agenda To: Bastien Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.167.47; envelope-from=alphadeltapapa@gmail.com; helo=mail-lf1-f47.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orgmode list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632624856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=x/3VlfCV8qqQ7aufZLDiDxEMLH3035QRZqaI4H4MVi4=; b=rYDIAGRH+tkMEkvUSguSSx2IkHa7UX9HklzXtL6xmzdPIW53SyWuq49UeHRccuZ/nl3KqN 4evnt7sovfDmUN9VxJmMP1tsx+cE82q/gyEinKZg8lf1EO+TD6PYUuG5NGieR9ynncp8tr 4lFP/mZLj2weqo7T3d+jgmhchrzbnlF65rbJeF3mJ/tP6xC+4Do7y3P+jIPE64F3eZmBgO Dc8NCWoFeLG85822ojBuOSqZTDtDzqWlnK85kdzFK2YUbXcMZnxfsBhQxpyUqm7mQuH9aX Tusq2G5gVKYjJ5/lgQ1Qbug5LrC7NWS7EK5BRIE3oCK4s7XhOAdTcWNv76of8Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632624856; a=rsa-sha256; cv=none; b=k9PxFuL0irsN86SHr2oUyYAjbIZz3uTgoEIUdnswBJYedEdDtWbVGE0V7mixuvtbfT4u5+ VDiuM9C5W2fqZ79xWwNhyEo9ZKuQytEqLxnzNfGGRCFM68KRMuWi5w4ZoL00V/kxnOlE3C qa6c0QHpAMzScUIGkTdnclophoM+hW1HfptBSPyF9Z1jaiZPrmlWwicAfD08OfkBHeOEjF ckvpxH/2AM0tiQMb8M9+1y0I4o3puCU6Q4TuN3TRjjq+tRzJ4keLe8hx4Lf27M+fFmXVXk d6MTLtgzPiajVzkA1u83UWRQro1AxGfXOgU0dVLQe20Nl3sP8l4rQBvF50y5rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.79 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: EB68E2BA70 X-Spam-Score: -2.79 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2+ShbUER6dIS Hi Bastien, On Sat, Sep 25, 2021 at 2:46 PM Bastien wrote: > > Since Bastien made this change, and it's very simple, I'm guessing he'll > > know what the proper fix is. :) > > The change I made was superceded by Nicolas series of patches: > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/?qt=grep&q=fix+org-duration-to-minutes+error Oops, thanks. I found your commit by searching the log, but I should have checked blame on the code to see if it had been changed since then. > I agree the new alignment looks wrong: the starting time should > bit right-aligned with other time above/below, and the separating > dash should not spaces for "HH:MM" time strings on the right, but > only for " H:MM". > > Would you have time to prepare a patch for this? Unfortunately, I'm unable to reproduce it on my system, even using Org 9.4.6 in a clean Emacs config. For some reason, it only seems to happen on the org-super-agenda repo's GitHub Actions CI (which tests on Emacs 26.3, 27.1, and snapshot versions). So I'm not sure what's going on. :( Hopefully Nicolas's changes solve the problem for Org 9.5 (if the problem is really one after all).