From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eHwQI0awJmWtJQEAauVa8A:P1 (envelope-from ) for ; Wed, 11 Oct 2023 16:25:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eHwQI0awJmWtJQEAauVa8A (envelope-from ) for ; Wed, 11 Oct 2023 16:25:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F5DF45A22 for ; Wed, 11 Oct 2023 16:25:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GHLfH4JW; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697034310; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yUB70IUgfv+GGS9BehXGpM7BPsoBxfsknW6hPlD7rPo=; b=ic7Ggw/dtofIPDDxN9Im0tqducm4V/JZ7KbCWf4bKGyAFdIosVbRa7i7K7Nxyid7jf8Nyo 854pfk18fSA7p9+WiP6uH4YjwOHcppvsU488GA9HSMrwF8lrThLR31tK1YS/mMARu4kfno DHs2+45DrJIlo5yg3j8THD/1rcPHB/Fi8ENx+ixEc3RC58SlQ9RxEJAtNCelI4/RpnzoNm TUH08qMeREr9C4jyTlpTsaUI8oHvm4srfTq+ET6wT+HMSFdlHSl5VmoKyl0FqBLaFym77E EvYHzRu2Ax7WjZie/qOiVdyMTSKJpu0n6rvUD0rIQylXfoiiWc8/CwHGteEkfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GHLfH4JW; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697034310; a=rsa-sha256; cv=none; b=lJchFsTXs4djDYLR+6dWLX0wNoLZciwFJng9U21SSSqvcBvLf7ujc6CLGGWwLyUI1FF3+T myeZ6eEFkmO7MoP5I3lesGeumhtenMjWfUceh6oY4gd+YCA6VV8S0F5/bmjaDZFwnpMV1w UM6ujAb6BUIq1auESssi9IKHY2WIQZC5QQw9g1QF12P20uUDiBQHUbzLinknPRaeg3eMyU +lqkDKdtpaEiy7OqOO/WN0wolmgwf28DwsTrtfzt/rgsRjoccdUpzUJLP2Va3GvDHQEsWE JNVhDb4LIwqhpQjoW+oefg++fNmDXWlwHSn14suKRRMrMTsz6DvbFQR3pRdyaw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqa8O-0007X8-AJ; Wed, 11 Oct 2023 10:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqa8N-0007X0-Ad for emacs-orgmode@gnu.org; Wed, 11 Oct 2023 10:24:23 -0400 Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqa8L-0002aC-RC for emacs-orgmode@gnu.org; Wed, 11 Oct 2023 10:24:23 -0400 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-45269fe9d6bso2978324137.2 for ; Wed, 11 Oct 2023 07:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697034259; x=1697639059; darn=gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=yUB70IUgfv+GGS9BehXGpM7BPsoBxfsknW6hPlD7rPo=; b=GHLfH4JWZjOfFFeUsSFO27HXtdIa5UZu2C4bOe8MzJpcU830+8SaQy0uH9NjHw7Ayw dK7ccGAdXaW8evKnAIkbMCJPEjWB37fQfJAGfiyMWIngDyJwzukxyVSITGGS6yahFgv9 Vrf6QZK7AlJ2YWU5TjR8/T01mfx+hD9o337kcaij5Hw9TLGLAulpVf1eNTK+fMdbxIMs FksPQEVAzgrN4UeVYzIwoLHmTFbol4ZIHUM35D5DQ2t9C9cfEHlEpynOyRyr84btinsW zztVhKJFv7kMADRA13i0lNiYTGTBuqtcNZr1GeYJpIbu6PjddZaXi/g8dMFlxsTk6gmr hHbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697034259; x=1697639059; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yUB70IUgfv+GGS9BehXGpM7BPsoBxfsknW6hPlD7rPo=; b=F/hGjAHXIxA86zIm73W/Ff++sc27GLgL/KP8XoNykLwvazAyD8GSApFjnecI4/CVlG OEPL2WCVhC3zVqfcrOG5XkvpAOTtM+glEpqoVa7BA+aypf0Yf4XOYxkYJdpzXAAAu+eK WljmJ6qO9Ad/U/OZViSbhPGlH5waS2ujugw10ZPRTzc0dqA6GsniY3SwzH//XXPipBGb IMea17zCMPThRUpZnRXnHqcpp8jSzOb2hkgSM27HZ2m7MnS22n4fdae9Bv9+mVv4/apG wowAvppb1kgwPcSOH/86ohcC06xG+yJoi3OlncvJEWEKDndYYGHa5v5fT12qgzEcKOSq Nmjg== X-Gm-Message-State: AOJu0YzmJQzR/49BQkeREcqy2FE7HI+N2WEdul9PH+glsIjPN4UAg1Zi GulY/Ai2TboRjEveT8Q8Me0xXJJxuuQUzZQSyI6NVMdPepQ= X-Google-Smtp-Source: AGHT+IEWP4zmm45dHmOrf8f/s28SVdB6l97LDf/1jrKwATiNk1qVNI40ebxqJZ2SueusTQHhbXwy0HzgorAffGfwTpc= X-Received: by 2002:a67:cfc4:0:b0:452:5892:2ab2 with SMTP id h4-20020a67cfc4000000b0045258922ab2mr20071857vsm.5.1697034259129; Wed, 11 Oct 2023 07:24:19 -0700 (PDT) MIME-Version: 1.0 From: Liu Hui Date: Wed, 11 Oct 2023 22:24:07 +0800 Message-ID: Subject: Re: [BUG] [PATCH] Add yank-media and DND handler [9.6.7 (9.6.7-g6eb773 @ /home/viz/lib/emacs/straight/build/org/)] To: Visuwesh Cc: emacs-orgmode@gnu.org, Ihor Radchenko Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::e29; envelope-from=liuhui1610@gmail.com; helo=mail-vs1-xe29.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.63 X-Spam-Score: -6.63 X-Migadu-Queue-Id: 2F5DF45A22 X-Migadu-Scanner: mx2.migadu.com X-TUID: MBsN9qiKyYhe Hi, Thanks for your work. I have two minor suggestions about the patch. > + (`file-link > + (let ((filename (dnd-get-local-file-name url))) > + (insert (org-link-make-string (concat "file:" filename)))))))) I think it is better to abbreviate the file name for file-link, so it would be consistent with org-insert-link. > + (caddr (read-multiple-choice > + "What to do with dropped file?" > + '((?a "attach" attach) > + (?o "open" open) > + (?f "insert file: link" file-link)))) The dialog box is shown in the center of frame and I find it a little inconvenient compared with a menu popped up just at the mouse location. How about using x-popup-menu?