From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QP1WKq4q22S8swAASxT56A (envelope-from ) for ; Tue, 15 Aug 2023 09:35:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WAppKq4q22SHPwEA9RJhRA (envelope-from ) for ; Tue, 15 Aug 2023 09:35:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E9F45F69C for ; Tue, 15 Aug 2023 09:35:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=o8s4s+nj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692084910; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RTIJStD5TkxbqvNDBQCZAWCf+Hze8VWmsKk9YVef+SQ=; b=DRETy3Dld+P/6GMJpUdqsIbrFN8CzTXXuJhDVAd1cu8hJCLo50XeQTk//0dCVWYHxJX6dv BmTBvL7bAVsOZ2AwkUBBAuGfgWwPwZAeehinLePBw4qMhCTQxPa/fY4H8MCofAIVLoglbm hFTDa5Mje6VvEJTLZrd0Z4F2Q8jzF1KCjWPNUkSw4y2zUYqzkhJa7ACgpox6eJCFicjxX9 KyxJITlPrvrXGWwqzyl8OTc9B+ryUpyulr9X+vD3XdXc/tmRHRUljMeMtsMC314nJ1Zr3J r8uoClFSsO3DTWnnZsLrnUvnr5GMXVjgeyz7YTJQFltzK4DvfqawpkjRvH/weA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=o8s4s+nj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692084910; a=rsa-sha256; cv=none; b=EhSa+iTICT6KEbHXNI5CnFLKS1SApsPkBsqc+ZD4yMvr38TplFNpUikPNjSdaQSj8e9SbF pdaqVEVSd0QptK9MTm+GET9VNzD+2rdEa2mGNiAfwLUl9gg72wGk+5t9zXVBDdAY1il2lY ha+pkFOzm9txPoD5kR6OgosWMtqH/4fYnIyGmcck+wziV9qIRYMoGyy2Q/CMSMc5oJS36v sr3LEeVBpfprL1Q+eDSF4XoFEolm6VpmFFcZHReJZU7KPq67i0a7DC77AbivQxGB0++xgx o6e/GsVfcK7xh/eGnOYrYwBA1AxLhcBAiWNXKynweqAi8fvUQod7s2+igByNGg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVoZE-00064s-Km; Tue, 15 Aug 2023 03:34:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVoZ9-00064N-SZ for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 03:34:11 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVoZ6-0003at-Ri for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 03:34:11 -0400 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-26b0b4a7cccso3434487a91.1 for ; Tue, 15 Aug 2023 00:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692084846; x=1692689646; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RTIJStD5TkxbqvNDBQCZAWCf+Hze8VWmsKk9YVef+SQ=; b=o8s4s+njxeifn5reTF5nz8H4Rz+3h7EIZg/VVj1SkbbHSa2nMva5C/UmwYw98LDUBw sFyUPv+u6r81650zWhK2guoim7Y01fR3Im2f3hf+4vyWWPZjEWsLp2loWIXdW8rQpigV X8X/+C4BgsRn5PibDuo3mSX1kDNAQth8UlWf/GwTk0TMCfaJZTOwVek+Fnjp0DlqsM0R H/g4iKqERw4+yVPTVczaUFaeKf09pLr/GyXfwd/DqSf3VUEC+1jdoi7vSUyFC9ixqsM6 7tSDyzfO068Uwrt3mbVAZ0YZORnDwgMQNbB3L1jITRPlFjq9xrLjCVwufh2jHKFOgYBX 6SaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692084846; x=1692689646; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RTIJStD5TkxbqvNDBQCZAWCf+Hze8VWmsKk9YVef+SQ=; b=Lvkrs4QaULh/nXvLXzTc0RdftpmTcTD+/n/OKUhE0gBW83J6XuUrPVPAMCofHzH+16 hvQWxxUqNoeizkvsBiyNMWoDjsKG7qrNu7Z7LcsfR9YQTrzjiTrevuh31EN/DuGRmCAo pWcSMQWTCtOhYGZ01BI1ym8zQcAUb6oHhqyQk1bIinBf1goBPZO6Y2v16NMGDIO5sNK8 xZ768hCjM3fMDVJCtTm/F8WFsKWXnckgj7xrJDAHp4jGRh4zr4pb+efn0UXpwFCSUOD6 FO6Me2xY3F2HOashECoWVj3sugIHNfl1xqk26Ua+Bg/xkY6xtJ4/Dil5of9qBx+t1hiD QWbA== X-Gm-Message-State: AOJu0YzoJVowIVwAhUS61UuSHPiUyJc30yycIHRwyVcyLkjlo9oTKYhj 3D1gUSEtse4uJ3z6huxZWgnjBHQIiR7FP8eBoiE= X-Google-Smtp-Source: AGHT+IGUEdajFn+5MeIucuCj4lmhUHW8fXm1gt6fVQZ01mUWuaiV8R6EkjOx6/dm+mTC8G9sUnke6zmw1CRT7h0wjNE= X-Received: by 2002:a17:90a:248:b0:268:b7a2:62e8 with SMTP id t8-20020a17090a024800b00268b7a262e8mr10054355pje.7.1692084846122; Tue, 15 Aug 2023 00:34:06 -0700 (PDT) MIME-Version: 1.0 References: <87bl9rq29m.fsf@gnu.org> <87sf9lv9ta.fsf@localhost> <878rbchyt9.fsf@autistici.org> <87edl3xdhe.fsf@localhost> <87tttyjw6b.fsf@autistici.org> <878rb990n5.fsf@localhost> <87r0p1pk2y.fsf@autistici.org> <87jzus8ive.fsf@localhost> <87mszj99n0.fsf@autistici.org> <87edkvm6kv.fsf@localhost> <87ila696wu.fsf@autistici.org> <87a5vh95wg.fsf@localhost> <875y65cy0r.fsf@autistici.org> <87ila4fpw5.fsf@localhost> <87o7jwazmn.fsf@autistici.org> <87pm4bp4qu.fsf@localhost> <87jzugb914.fsf@autistici.org> <875y60i97y.fsf@localhost> <87fs54b69g.fsf@autistici.org> <87pm3xit7c.fsf@localhost> <87r0obnomm.fsf@autistici.org> <87y1iit5z9.fsf@localhost> In-Reply-To: <87y1iit5z9.fsf@localhost> From: Henrik Frisk Date: Tue, 15 Aug 2023 09:33:54 +0200 Message-ID: Subject: Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?) To: Ihor Radchenko Cc: Jonathan Gregory , "Dr. Arne Babenhauserheide" , "Victor A. Stoichita" , emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="0000000000002edcf30602f134c7" Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=frisk.h@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -8.73 X-Migadu-Queue-Id: 1E9F45F69C X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -8.73 X-TUID: /2SGjnLc5yqU --0000000000002edcf30602f134c7 Content-Type: text/plain; charset="UTF-8" Den fre 11 aug. 2023 kl 09:04 skrev Ihor Radchenko : > Jonathan Gregory writes: > > >> Jonathan, do you think that your original patch is still what > >> you want to get merged? > > > > Yes, the one I sent on 20 Jul 2023. I haven't had any issues with > > it so far. > > Ok. Would you mind adding a commit message, as described in > https://orgmode.org/worg/org-contribute.html#first-patch? > > And do I understand correctly that no changes in > https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html > are needed? > > Sorry for being late in this discussion. As a user of ob-lilypond I'm very happy about these changes. On my last install, as well as my current I have had to change the following: (org-babel-get-header params :var) which appears to be outdated, to: (org-babel--get-vars params) in the version of ob-lilypond.el from here: https://github.com/mjago/ob-lilypond/blob/master/lisp/ob-lilypond.el. Which version of the file are you patching now? Another request would be to have the variables ly-XXX-pdf-path and ly-XXX-midi-path settable, or, perhaps, read from the lilypond settings of corresponding variables. I'm not an elisp programmer but I could look into that if it's of interest. /Henrik --0000000000002edcf30602f134c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
Den fre 11 aug. 2023 kl 09:04 skrev I= hor Radchenko <yantar92@posteo.ne= t>:
Jonat= han Gregory <jgr= g@autistici.org> writes:

>> Jonathan, do you think that your original patch is still what
>> you want to get merged?
>
> Yes, the one I sent on 20 Jul 2023. I haven't had any issues with =
> it so far.

Ok. Would you mind adding a commit message, as described in
https://orgmode.org/worg/org-contribute.html= #first-patch?

And do I understand correctly that no changes in
https://orgmode.org/worg/or= g-contrib/babel/languages/ob-doc-lilypond.html
are needed?

Sorry for being late in this discussion. As a user of= ob-lilypond I'm very happy about these changes. On my last install, as= well as my current I have had to change the following:

(org-babel-get-header params :var) which appears to be outdated, to: =

(org-babel--get-vars params)

in the version of ob-lilypond.el from here: https://github.c= om/mjago/ob-lilypond/blob/master/lisp/ob-lilypond.el. Which version of = the file are you patching now?

Another request wou= ld be to have the variables ly-XXX-pdf-path and ly-XXX-midi-path settable, = or, perhaps, read from the lilypond settings of corresponding variables. I&= #39;m not an elisp programmer but I could look into that if it's of int= erest.

/Henrik
--0000000000002edcf30602f134c7--