From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike McLean Subject: Re: Bug: Tag Completion Not Prompting for all tags Date: Mon, 2 Apr 2012 11:26:10 -0400 Message-ID: References: <6A1FEA98-38A0-48C5-88C3-DEE9401C38B5@pobox.com> <87pqbyqqr4.fsf@gnu.org> <87iphl3zaq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d0430878e5427a604bcb3cfb5 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEj9r-0003w2-Qj for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEj9l-0008Bz-1v for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:27:03 -0400 Received: from a-pb-sasl-sd.pobox.com ([74.115.168.62]:43454 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEj9k-000866-Rr for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:26:56 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id EB5179370 for ; Mon, 2 Apr 2012 11:26:11 -0400 (EDT) Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id E5932936F for ; Mon, 2 Apr 2012 11:26:11 -0400 (EDT) Received: from mail-ey0-f169.google.com (unknown [209.85.215.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 596759368 for ; Mon, 2 Apr 2012 11:26:11 -0400 (EDT) Received: by eaal1 with SMTP id l1so830951eaa.0 for ; Mon, 02 Apr 2012 08:26:10 -0700 (PDT) In-Reply-To: <87iphl3zaq.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: "emacs-orgmode@gnu.org" , Mike McLean --f46d0430878e5427a604bcb3cfb5 Content-Type: text/plain; charset=ISO-8859-1 Bastion The dangers of minimal testing setups is rearing its ugly head. I can confirm that your latest patch does fix the minimal example that I provided. It does not, sadly, fix a similar case where the org-tag-alist variable includes the :startgroup and :endgroup tokens. If you can my most recent steps to reproduce, step 1.3, and add those tokens, the error is "Wrong type argument: stringp, :endgroup" Thank you for you patience :) On Saturday, March 31, 2012, Bastien wrote: > Hi Mike, > > Mike McLean > writes: > > > Bastien > > > > I can verify that this has fixed the problem with tag completion not > > prompting for all tags. I see that commit > > 647396464d563634b980127673cf61769663407e has added a wrapper > > (append that combines buffer-tags with (mapcar 'car table). > > > > This has, however, exposed a new bug and conflict > > with org-completion-use-ido that I can minimally reproduce below. > > This is now fixed, thanks! > > -- > Bastien > --f46d0430878e5427a604bcb3cfb5 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Bastion

The dangers of minimal testing setups is rearing= its ugly head. I can confirm that your latest patch does fix the minimal e= xample that I provided. It does not, sadly, fix a similar case where the or= g-tag-alist variable includes the :startgroup and :endgroup tokens. If you = can my most recent steps to reproduce, step 1.3, and add those tokens, the = error is "Wrong type argument: stringp, :endgroup"

Thank you for you patience :)

On Sa= turday, March 31, 2012, Bastien wrote:
H= i Mike,

Mike McLean <mike.mclean@pobox.com> writes:<= br>
> Bastien
>
> I can verify that this has fixed the problem with tag completion not > prompting for all tags. I see that commit
> 647396464d563634b980127673cf61769663407e has added a wrapper
> (append that combines buffer-tags with (mapcar 'car table).
>
> This has, however, exposed a new bug and conflict
> with org-completion-use-ido that I can minimally reproduce below.

This is now fixed, thanks!

--
=A0Bastien
--f46d0430878e5427a604bcb3cfb5--