From: Mike McLean <mike.mclean@pobox.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] - Org Mac Outlook - Fix Call to Outlook in some cases
Date: Mon, 14 Dec 2015 12:12:27 -0500 [thread overview]
Message-ID: <CANid5Q4cdtpaX18L-tw52=j3Zw6qcuHNTdBmvtkPidfJi3+0mw@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1014 bytes --]
Updated to fix a typo in the defcustom’s documentation string.
On Mon, Dec 14, 2015 at 11:22 AM, Mike McLean <mike.mclean@pobox.com> wrote:
> Earlier in this thread, Rasmus suggested “Perhaps it should be a
> defcustom?”
>
> With a new version (2016) of Microsoft Outlook for Mac that does not
> install inside of a "Microsoft Office 2011" directory, this indeed should
> be a defcustom.
>
> This patch accomplishes that change. (It also changes the default to
> /Applications/Microsoft Outlook.app which is the filesystem path of Outlook
> 2016.
>
>
> On Wed, Jun 10, 2015 at 2:17 AM, Alan Schmitt <
> alan.schmitt@polytechnique.org> wrote:
>
>> On 2015-06-09 22:20, Mike McLean <mike.mclean@pobox.com> writes:
>>
>> > Here is a version of the patch with a (hopefully) correct Changelog
>> format
>>
>> Applied and pushed, thanks!
>>
>> Alan
>>
>> --
>> OpenPGP Key ID : 040D0A3B4ED2E5C7
>> Weekly CO₂ average (2015-05-30, Mauna Loa Observatory): 403.41 ppm
>>
>
>
[-- Attachment #1.2: Type: text/html, Size: 1959 bytes --]
[-- Attachment #2: 0001-org-mac-link.el-Make-path-to-Microsoft-Outlook-custo.patch --]
[-- Type: application/octet-stream, Size: 2483 bytes --]
From d168acf969a7536996be573d846d30085ea08a9f Mon Sep 17 00:00:00 2001
From: Mike McLean <mike.mclean@pobox.com>
Date: Mon, 14 Dec 2015 11:09:03 -0500
Subject: [PATCH] org-mac-link.el: Make path to Microsoft Outlook customizable
* org-mac-link.el (org-mac-outlook-path): New Custom String to hold the file system path to Microsoft Outlook
(org-mac-outlook-message-open, org-as-get-selected-outlook-mail): Use
the new custom string instead of hard-coding the path to Outlook
---
contrib/lisp/org-mac-link.el | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index 01556f7..e04fb80 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -21,7 +21,11 @@
;; Version: 1.3
;; Author: Alan Schmitt <alan.schmitt@polytechnique.org>
;; Consistently use `org-mac-paste-applescript-links'
-;;
+;;
+;; Version 1.4
+;; Author: Mike McLean <mike.mclean@pobox.com>
+;; Make the path to Microsoft Outlook a `defcustom'
+;;
;; This file is not part of GNU Emacs.
;;
;; This program is free software; you can redistribute it and/or modify
@@ -113,6 +117,12 @@
:group 'org-mac-link
:type 'boolean)
+(defcustom org-mac-outlook-path "/Applications/Microsoft Outlook.app"
+ "The path to the installed copy of Microsoft Outlook.app. Do not escape spaces as the AppleScript call will quote this string."
+ :tag "Path to Microsoft Outlook"
+ :group 'org-mac-link
+ :type 'string)
+
(defcustom org-mac-grab-devonthink-app-p t
"Add menu option [d]EVONthink to grab links from DEVONthink Pro Office.app."
:tag "Grab DEVONthink Pro Office.app links"
@@ -610,7 +620,7 @@ The links are of the form <link>::split::<name>."
"Open a message in Outlook"
(do-applescript
(concat
- "tell application \"/Applications/Microsoft Office 2011/Microsoft Outlook.app\"\n"
+ "tell application \"" org-mac-outlook-path "\"\n"
(format "open message id %s\n" (substring-no-properties msgid))
"activate\n"
"end tell")))
@@ -619,7 +629,7 @@ The links are of the form <link>::split::<name>."
"AppleScript to create links to selected messages in Microsoft Outlook.app."
(do-applescript
(concat
- "tell application \"/Applications/Microsoft Office 2011/Microsoft Outlook.app\"\n"
+ "tell application \"" org-mac-outlook-path "\"\n"
"set msgCount to count current messages\n"
"if (msgCount < 1) then\n"
"return\n"
--
2.6.4
next reply other threads:[~2015-12-14 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 17:12 Mike McLean [this message]
2015-12-18 10:18 ` [PATCH] - Org Mac Outlook - Fix Call to Outlook in some cases Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANid5Q4cdtpaX18L-tw52=j3Zw6qcuHNTdBmvtkPidfJi3+0mw@mail.gmail.com' \
--to=mike.mclean@pobox.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).