From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike McLean Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day Date: Tue, 20 Nov 2012 11:12:10 -0500 Message-ID: References: <87lie0nve7.fsf@gmail.com> <20121117160204.GA27446@c3po> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e0cb4efa6dfc3b671e04ceef80a4 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqRd-0007kP-Id for emacs-orgmode@gnu.org; Tue, 20 Nov 2012 11:13:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaqRX-0004xy-Ig for emacs-orgmode@gnu.org; Tue, 20 Nov 2012 11:13:05 -0500 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:64605 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqRX-0004tu-Cd for emacs-orgmode@gnu.org; Tue, 20 Nov 2012 11:12:59 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 57AAEADC5 for ; Tue, 20 Nov 2012 11:12:33 -0500 (EST) Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 4B2E3ADC4 for ; Tue, 20 Nov 2012 11:12:33 -0500 (EST) Received: from mail-lb0-f169.google.com (unknown [209.85.217.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id C57C1ADC3 for ; Tue, 20 Nov 2012 11:12:32 -0500 (EST) Received: by mail-lb0-f169.google.com with SMTP id gk1so5297911lbb.0 for ; Tue, 20 Nov 2012 08:12:30 -0800 (PST) In-Reply-To: <20121117160204.GA27446@c3po> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Toby Cubitt , emacs-orgmode@gnu.org --e0cb4efa6dfc3b671e04ceef80a4 Content-Type: text/plain; charset=UTF-8 On Sat, Nov 17, 2012 at 11:02 AM, Toby Cubitt wrote: > On Sat, Nov 17, 2012 at 03:42:24PM +0100, Nicolas Goaziou wrote: > > Toby Cubitt writes: > > > > > I've replaced the cons cells with additional plist properties, as you > > > suggested. The resulting customization ui still isn't wonderful in my > > > opinion. But it does the job, and I'm not sure how much scope there is > > > for improving it further. If you see a way, by all means feel free to > > > make the changes yourself. I really don't mind what format you go with > > > for org-time-clocksum-format, as long as it supports the new formatting > > > features implemented in the patch. > > > > Considering I'm not an expert in customize ui, it's good enough as it > > is. > > OK. If someone thinks of a way to improve the customization ui (keeping > the same data type), it's easy to change it later without breaking > anything. > > > I've applied your patch (with some small changes in a docstring). Thank > > you again for all that work. > > Glad we finally found a good implementation. Thanks to you for all your > helpful feedback. > > I like the new implementation and customization options, but now when I do ~C-c C-x C-c~ to get a sub-tree time, I get nothing but zeros (~0d 0:00~) for every subtree. Mike --e0cb4efa6dfc3b671e04ceef80a4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Sat, Nov 17, 2012 at 11:02 AM, Toby Cubitt <t= sc25@cantab.net> wrote:
On Sat, Nov 17, 2012 at 03:42:24PM +0100, Nicolas Goaziou= wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
>
> > I've replaced the cons cells with additional plist properties= , as you
> > suggested. The resulting customization ui still isn't wonderf= ul in my
> > opinion. But it does the job, and I'm not sure how much scope= there is
> > for improving it further. If you see a way, by all means feel fre= e to
> > make the changes yourself. I really don't mind what format yo= u go with
> > for org-time-clocksum-format, as long as it supports the new form= atting
> > features implemented in the patch.
>
> Considering I'm not an expert in customize ui, it's good enoug= h as it
> is.

OK. If someone thinks of a way to improve the customization ui (keepi= ng
the same data type), it's easy to change it later without breaking
anything.

> I've applied your patch (with some small changes in a docstring). = Thank
> you again for all that work.

Glad we finally found a good implementation. Thanks to you for all yo= ur
helpful feedback.


Mike



=
--e0cb4efa6dfc3b671e04ceef80a4--