From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xi Shen Subject: Re: [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment. Date: Sat, 15 Apr 2017 06:06:26 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114e550665ec07054d2e5ca5 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czGr1-0003ZQ-Hz for Emacs-orgmode@gnu.org; Sat, 15 Apr 2017 02:06:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czGr0-0007C1-Ll for Emacs-orgmode@gnu.org; Sat, 15 Apr 2017 02:06:39 -0400 Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:33194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czGr0-0007Bg-Fz for Emacs-orgmode@gnu.org; Sat, 15 Apr 2017 02:06:38 -0400 Received: by mail-yw0-x22d.google.com with SMTP id l189so41307133ywb.0 for ; Fri, 14 Apr 2017 23:06:38 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "emacs-orgmode@gnu.org" , Nicolas Goaziou --001a114e550665ec07054d2e5ca5 Content-Type: text/plain; charset=UTF-8 On Wed, Apr 12, 2017, 11:16 Xi Shen wrote: > Hi, > > Regarding a patch I made early. Ref. title: [PATCH] ob-sql.el: Support > sqlcmd and cygwin environment. > > I found it does not for Emacs for Windows. More generally, it does not > work in minGW or MSYS environments. I think it is because minGW is not a > POSIX environment, and applications in minGW can actually talk to Windows > system and handle Windows file path directly. > > Because there's no official way to identify if Emacs is in minGW > environment, I must roll out cygwin environment first, then I test if it is > in "windows-nt" environment. > > Please review the patch, and let me know if you have any comments/question. > > > Thanks, > David > > --001a114e550665ec07054d2e5ca5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Apr 12, 2017, 1= 1:16 Xi Shen <davidshen84@gmail= .com> wrote:
Hi,

Regarding a patch I made early. Ref. title: [PATCH] ob-sql.el:= Support sqlcmd and cygwin environment.

I found it d= oes not for Emacs for Windows. More generally, it does not work in minGW or= MSYS environments. I think it is because minGW is not a POSIX environment,= and applications in minGW can actually talk to Windows system and handle W= indows file path directly.

Because there's no = official way to identify if Emacs is in minGW environment, I must roll out = cygwin environment first, then I test if it is in "windows-nt" en= vironment.

Please review the patch, and let me kno= w if you have any comments/question.


Thanks,
David

--001a114e550665ec07054d2e5ca5--