From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xi Shen Subject: [PATCH] lisp/ob-sql.el: Fix filename conversion in minGW environment. Date: Wed, 12 Apr 2017 03:16:29 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114e55061125a3054cefa328 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cy8lv-00026T-Rc for Emacs-orgmode@gnu.org; Tue, 11 Apr 2017 23:16:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cy8lu-0003mR-Tg for Emacs-orgmode@gnu.org; Tue, 11 Apr 2017 23:16:43 -0400 Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:36525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cy8lu-0003l4-Op for Emacs-orgmode@gnu.org; Tue, 11 Apr 2017 23:16:42 -0400 Received: by mail-yw0-x22d.google.com with SMTP id j9so6660228ywj.3 for ; Tue, 11 Apr 2017 20:16:41 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "emacs-orgmode@gnu.org" --001a114e55061125a3054cefa328 Content-Type: multipart/alternative; boundary=001a114e550611259c054cefa326 --001a114e550611259c054cefa326 Content-Type: text/plain; charset=UTF-8 Hi, Regarding a patch I made early. Ref. title: [PATCH] ob-sql.el: Support sqlcmd and cygwin environment. I found it does not for Emacs for Windows. More generally, it does not work in minGW or MSYS environments. I think it is because minGW is not a POSIX environment, and applications in minGW can actually talk to Windows system and handle Windows file path directly. Because there's no official way to identify if Emacs is in minGW environment, I must roll out cygwin environment first, then I test if it is in "windows-nt" environment. Please review the patch, and let me know if you have any comments/question. Thanks, David --001a114e550611259c054cefa326 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Regarding a patch I made early. Ref. title: [PA= TCH] ob-sql.el: Support sqlcmd and cygwin environment.

I found it does not for Emacs for Windows. More generally, it does not w= ork in minGW or MSYS environments. I think it is because minGW is not a POS= IX environment, and applications in minGW can actually talk to Windows syst= em and handle Windows file path directly.

Because = there's no official way to identify if Emacs is in minGW environment, I= must roll out cygwin environment first, then I test if it is in "wind= ows-nt" environment.

Please review the patch,= and let me know if you have any comments/question.


Thanks,
David

--001a114e550611259c054cefa326-- --001a114e55061125a3054cefa328 Content-Type: application/octet-stream; name="ob-sql.el.patch" Content-Disposition: attachment; filename="ob-sql.el.patch" Content-Transfer-Encoding: base64 Content-ID: <15b60260e74dce9021b1> X-Attachment-Id: 15b60260e74dce9021b1 RnJvbSA0OGQzMTkzNzk5ZmMwYTZmYWIwN2M5ZTAxMWQ1YWNiNjM2MTViZmUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaSBTaGVuIDxkYXZpZHNoZW44NEBnbWFpbC5jb20+CkRhdGU6 IFdlZCwgMTIgQXByIDIwMTcgMTA6MjM6NDUgKzA4MDAKU3ViamVjdDogW1BBVENIXSBsaXNwL29i LXNxbC5lbDogRml4IGZpbGVuYW1lIGNvbnZlcnNpb24gaW4gbWluR1cgZW52aXJvbm1lbnQuCgoo b3JnLWJhYmVsLXNxbC1jb252ZXJ0LXN0YW5kYXJkLWZpbGVuYW1lKTogSWYgaXQgaXMgbm90IGlu IEN5Z3dpbgplbnZpcm9ubWVudCwgYW5kIGBzeXN0ZW0tbnQnIGlzICJ3aW5kb3dzLW50IiwgRW1h Y3MgbXVzdCBiZSBpbiBtaW5HVwpvciBNU1lTIGVudmlyb25tZW50LCBjYW4gY2FuIGhhbmRsZSBX aW5kb3dzIGZpbGVuYW1lIGNvcnJlY3RseS4KLS0tCiBsaXNwL29iLXNxbC5lbCB8IDE0ICsrKysr KystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3Avb2Itc3FsLmVsIGIvbGlzcC9vYi1zcWwuZWwKaW5kZXggZWMw NDI3Zi4uMDRmNDBkOSAxMDA2NDQKLS0tIGEvbGlzcC9vYi1zcWwuZWwKKysrIGIvbGlzcC9vYi1z cWwuZWwKQEAgLTE0OSwxNCArMTQ5LDE0IEBAIFNRTCBTZXJ2ZXIgb24gV2luZG93cyBhbmQgTGlu dXggcGxhdGZvcm0uIgogCSAgICAgICIgIikpCiAKIChkZWZ1biBvcmctYmFiZWwtc3FsLWNvbnZl cnQtc3RhbmRhcmQtZmlsZW5hbWUgKGZpbGUpCi0gICJDb252ZXJ0IHRoZSBmaWxlIG5hbWUgdG8g T1Mgc3RhbmRhcmQuCisgICJDb252ZXJ0IGBGSUxFJyB0byBPUyBzdGFuZGFyZCBmaWxlIHBhdGgu CiBJZiBpbiBDeWd3aW4gZW52aXJvbm1lbnQsIHVzZXMgQ3lnd2luIHNwZWNpZmljIGZ1bmN0aW9u IHRvCi1jb252ZXJ0IHRoZSBmaWxlIG5hbWUuIE90aGVyd2lzZSwgdXNlcyBFbWFjcycgc3RhbmRh cmQgY29udmVyc2lvbgotZnVuY3Rpb24uIgotICAoZm9ybWF0ICJcIiVzXCIiCi0JICAoaWYgKGZi b3VuZHAgJ2N5Z3dpbi1jb252ZXJ0LWZpbGUtbmFtZS10by13aW5kb3dzKQotCSAgICAgIChjeWd3 aW4tY29udmVydC1maWxlLW5hbWUtdG8td2luZG93cyBmaWxlKQotCSAgICAoY29udmVydC1zdGFu ZGFyZC1maWxlbmFtZSBmaWxlKSkpKQorY29udmVydCB0aGUgZmlsZSBuYW1lOyBpZiBpbiBgd2lu ZG93cy1udCcgZW52aXJvbm1lbnQsIGRvIG5vdAorY29udmVydHRoZSBgRklMRScgcGFyYW1ldGVy LiAgT3RoZXJ3aXNlLCB1c2VzIEVtYWNzJyBzdGFuZGFyZAorY29udmVyc2lvbiBmdW5jdGlvbi4i CisgIChjb25kICgoZmJvdW5kcCAnY3lnd2luLWNvbnZlcnQtZmlsZS1uYW1lLXRvLXdpbmRvd3Mp IChmb3JtYXQgIlwiJXNcIiIgKGN5Z3dpbi1jb252ZXJ0LWZpbGUtbmFtZS10by13aW5kb3dzIGZp bGUpKSkKKwkoKHN0cmluZz0gIndpbmRvd3MtbnQiIHN5c3RlbS10eXBlKSBmaWxlKQorCSh0IChm b3JtYXQgIlwiJXNcIiIgKGNvbnZlcnQtc3RhbmRhcmQtZmlsZW5hbWUgZmlsZSkpKSkpCiAKIChk ZWZ1biBvcmctYmFiZWwtZXhlY3V0ZTpzcWwgKGJvZHkgcGFyYW1zKQogICAiRXhlY3V0ZSBhIGJs b2NrIG9mIFNxbCBjb2RlIHdpdGggQmFiZWwuCi0tIAoyLjEwLjAud2luZG93cy4xCgo= --001a114e55061125a3054cefa328--