emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ship Mints <shipmints@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add org-src-is-fontify-buffer-p (patch attached)
Date: Sat, 18 Jan 2025 06:28:16 -0500	[thread overview]
Message-ID: <CAN+1Hbogd=HA9TEcHMroA89COum0XV-Vpg8SRZz0hd641+dGHQ@mail.gmail.com> (raw)
In-Reply-To: <87plkkqsgp.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

Yes, could do, and nothing needed by org-mode or markdown-mode. Could also
test for buffer-file-name nil. Or test both. Let's recommend that simpler
approach and I will rescind my markdown PR in favor of this simpler
suggestion.

On Sat, Jan 18, 2025 at 6:18 AM Ihor Radchenko <yantar92@posteo.net> wrote:

> Ship Mints <shipmints@gmail.com> writes:
>
> > Eglot was the first request cited. For python programmers that rely on
> per
> > project/directory-local or per-buffer virtual environment set up, this
> can
> > be heavier than needed just for fontification. I enable eglot manually,
> but
> > I do use python virtual environments and would disable initialization in
> > fontification buffers.
>
> Ok. Fair enough.
>
> > I'd prefer a more generic interface than propagating org internals like
> the
> > format of the fortification buffer name. It's what I submitted to the
> > markdown repo also. The buffer name scheme can change in the future
> without
> > impacting this feature.
>
> From my point of view, the interface you suggest is not generic enough.
> It only addresses a single use case - Org fontification.
>
> What about another, more general approach - check if buffer name starts
> with space? By convention, buffers with names starting with space are
> considered internal.
>
> --
> Ihor Radchenko // yantar92,
> Org mode maintainer,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 2322 bytes --]

  reply	other threads:[~2025-01-18 11:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-18  0:39 Add org-src-is-fontify-buffer-p (patch attached) Ship Mints
2025-01-18  7:29 ` Ihor Radchenko
2025-01-18  9:27   ` Ship Mints
2025-01-18 11:20     ` Ihor Radchenko
2025-01-18 11:28       ` Ship Mints [this message]
2025-01-18 11:38         ` Ihor Radchenko
2025-01-18 11:54           ` Ship Mints
2025-01-18 11:57             ` Ship Mints
2025-01-18 12:42               ` Ihor Radchenko
2025-01-18 12:53                 ` Ship Mints
2025-01-18 12:59                   ` Ihor Radchenko
2025-01-18 12:15           ` Jens Schmidt
2025-01-18 12:33             ` Ship Mints
2025-01-18 12:48             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN+1Hbogd=HA9TEcHMroA89COum0XV-Vpg8SRZz0hd641+dGHQ@mail.gmail.com' \
    --to=shipmints@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).