Issues when compiling Org master from source in GNU Emacs 25.0.50.1

Issues when compiling Org master from source in GNU Emacs 25.0.50.1

[Vicente Vera]

Hello

When I started using GNU Emacs compiled from the emacs25 branch two
issues come up consistently during Org make routine. These issues are
related to changes in the next Emacs version.

[...]
Compiling /home/user/repositories/org-mode/lisp/org-src.el...

In org-src-font-lock-fontify-block:
org-src.el:504:54:Warning: ‘font-lock-fontify-buffer’ is for interactive use
    only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
[...]
Compiling /home/user/repositories/org-mode/lisp/org.el...

In org-fast-tag-selection:
org.el:15261:47:Error: ‘add-to-list’ can’t use lexical var ‘buffer-tags’; use
    ‘push’ or ‘cl-pushnew’
[...]

Note that the .elc files get generated just fine, I mean, the make
routine finishes correctly and Org is still usable.

Re: Issues when compiling Org master from source in GNU Emacs 25.0.50.1

[Kyle Meyer]

Hi Vicente,

Vicente Vera <vicentemvp@gmail.com> writes:

> Hello
>
> When I started using GNU Emacs compiled from the emacs25 branch two
> issues come up consistently during Org make routine. These issues are
> related to changes in the next Emacs version.

Thanks for reporting these.

> Compiling /home/user/repositories/org-mode/lisp/org-src.el...
>
> In org-src-font-lock-fontify-block:
> org-src.el:504:54:Warning: ‘font-lock-fontify-buffer’ is for interactive use
>     only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.

This has been switched over to font-lock-ensure a couple times (in
f36b19e and then reverted in 99f9999, then again in d81e6b5 and reverted
in 003a0f1).  When font-lock-ensure is used, source blocks don't get
highlighted.

> Compiling /home/user/repositories/org-mode/lisp/org.el...
>
> In org-fast-tag-selection:
> org.el:15261:47:Error: ‘add-to-list’ can’t use lexical var ‘buffer-tags’; use
>     ‘push’ or ‘cl-pushnew’

I think this one should be fixed.  I'll look into it.

-- 
Kyle

Re: Issues when compiling Org master from source in GNU Emacs 25.0.50.1

[Vicente Vera]

Hello Kyle,

Thanks for your reply. I see now why `font-lock-fontify-buffer' hasn't
been replaced.

2016-01-20 12:28 GMT-03:00 Kyle Meyer <kyle@kyleam.com>:
> Hi Vicente,
>
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Hello
>>
>> When I started using GNU Emacs compiled from the emacs25 branch two
>> issues come up consistently during Org make routine. These issues are
>> related to changes in the next Emacs version.
>
> Thanks for reporting these.
>
>> Compiling /home/user/repositories/org-mode/lisp/org-src.el...
>>
>> In org-src-font-lock-fontify-block:
>> org-src.el:504:54:Warning: ‘font-lock-fontify-buffer’ is for interactive use
>>     only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
>
> This has been switched over to font-lock-ensure a couple times (in
> f36b19e and then reverted in 99f9999, then again in d81e6b5 and reverted
> in 003a0f1).  When font-lock-ensure is used, source blocks don't get
> highlighted.
>
>> Compiling /home/user/repositories/org-mode/lisp/org.el...
>>
>> In org-fast-tag-selection:
>> org.el:15261:47:Error: ‘add-to-list’ can’t use lexical var ‘buffer-tags’; use
>>     ‘push’ or ‘cl-pushnew’
>
> I think this one should be fixed.  I'll look into it.
>
> --
> Kyle