On Wed, Jan 15, 2025 at 10:13 AM Ihor Radchenko <yantar92@posteo.net> wrote:
Looks like I was not clear enough in my last comment.

The latest version of your patch exceeds 20LOC and cannot be accepted
unless you have FSF copyright assignment.

Sorry, that was clear in your previous comment. I am working on the assignment form right now but I expect that to be a solved problem and I want to continue to contribute to Org mode anyway, so I wanted to parallelize that with continuing on the patch. If you would like me to stop working on the patch until I have the copyright assignment taken care of, I can do that, too.
 
>     (let ((org-capture-templates '(("t" "Test" entry (here) "* Test
> Header\n\n")))
>           (base-filename (buffer-file-name)))
>
>       (org-capture nil "t")

This one is awkward.
You can create an indirect buffer explicitly instead of relying upon
implementation details of org-capture.

Thanks for pointing that out, I'll fix it. 

 
I recommend using `org-babel-effective-tangled-filename' instead.
This is more future-proof against possible changes in the way file name
is computed.

I'm sorry, I don't quite understand. Do you mean I should change the function name `org-base-buffer-file-name' to `org-babel-effective-tangled-filename' or something else?

Thanks,

Derek

--
+---------------------------------------------------------------+
| Derek Chen-Becker                                             |
| GPG Key available at https://keybase.io/dchenbecker and       |
| Fngrprnt: EB8A 6480 F0A3 C8EB C1E7  7F42 AFC5 AFEE 96E4 6ACC  |
+---------------------------------------------------------------+