From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gKklJBaxi2ffVgAA62LTzQ:P1 (envelope-from ) for ; Sat, 18 Jan 2025 13:48:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id gKklJBaxi2ffVgAA62LTzQ (envelope-from ) for ; Sat, 18 Jan 2025 14:48:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=chen-becker.org header.s=google header.b=UxVtn9z0; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1737208086; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FO9pIrTJAAS5COLKpG+xkadXe5sFVH2IuJVW2h/lqfg=; b=LW6UTSqD5CdEl27l7UG1M9RDb7kQqL4BpJgRPVvljx3GT1WpvY1GDrNZCc0nWzdNPpV47z n2SXar/OmyKdxXJMdDtdJpq42718UAOlWLcj1iHl6Yj0bJXnOW0urWKfKzM94cWMTEpDJA SFfqayHlX37mvZ6s5n7TrR4mrY/96C5CiHu7IclrjLaq3lstiPSML3OOP2v13ly49NINDQ uvwca+wK36pDrLROqkBtBNlN1YVFgUNfjpuTjsedzmwx4sfUh2v+v0xCau5iAdg9huUGcy 6zXE0W74vsoBx+fhpLOga2wsYDGz3s0iNKaURTuudDk2S3x3dkGpiR8gPq/f8g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=chen-becker.org header.s=google header.b=UxVtn9z0; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1737208086; a=rsa-sha256; cv=none; b=bAB43oVDSe7b1prVtAL0QYd5HeN+A5/Q9K0qN+ju8IQ5QAoqPfvscWHa5KQ+n7Gwowjgii AldBicqptEj4oomGy8ISt8baBG3/ZPoz+QEnnjEmI677mknnWrnRlxE6A9jRvSgz3Wa+h1 SHB02ezSFd+lgHqzFQ+4d40SPvEoBr7j7KPT77KmuVQlod0svx0NESwZ0A1qv95Avs0jHL rP+lAHEc0RqfT4s9TqhA1duhN9M3EO1yq6UMGWy46Qcr6dvGlhLoYTy1W1HtKALgmrxM0O gSY5gfxWayMK2SUC9jGX6CtaEVARQ7yr7f76ASTIHJvBj8z0k72h6Z6awD5Uzw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 25A2B19773 for ; Sat, 18 Jan 2025 14:48:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tZ95U-0004Jn-LT; Sat, 18 Jan 2025 08:42:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZ95S-0004JB-8d for emacs-orgmode@gnu.org; Sat, 18 Jan 2025 08:42:06 -0500 Received: from mail-vs1-xe31.google.com ([2607:f8b0:4864:20::e31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tZ95P-0002q1-2u for emacs-orgmode@gnu.org; Sat, 18 Jan 2025 08:42:05 -0500 Received: by mail-vs1-xe31.google.com with SMTP id ada2fe7eead31-4b2c0a7ef74so1707167137.2 for ; Sat, 18 Jan 2025 05:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chen-becker.org; s=google; t=1737207721; x=1737812521; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FO9pIrTJAAS5COLKpG+xkadXe5sFVH2IuJVW2h/lqfg=; b=UxVtn9z0Tdts3zmyzbXCGIwhRV+1aiFuIP28Yblz51MX92WHZcGLw3tForeq++LkyY ukmRyd/4XMaYrNgGArLei3WJ64RoOu1rJhGMwxCqDegIC2HXpolHGlmESt8iWA0sS2Ix ACXFD98qq9GGcMTnVnvsC7aZEc9NhLObuI1RwV1npgKzyUr+53x1rmlWZ3KxLQaDL49I YGtv6NIz2EvJGEnNEAfkEfNjm0WCNhQKu+Lsx+eemPMthl7aMHzv+P4097WWHKTzqM0K rLgCk1epdgQWsVeUHvpdkkHlk7TmyLzbKO5wvAzbcTQxBOK7iiBk1QJG1dR9MsBz/P3c D88g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737207721; x=1737812521; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FO9pIrTJAAS5COLKpG+xkadXe5sFVH2IuJVW2h/lqfg=; b=mwx1GnBkhc2tiBhXDYr9iXgaSM+2pfXPj52mGmpDy+u8zImsWQZIOAlBIBCel4qLP0 kxI9ofkVES3nknQyj4HPP4r6fdixCGdet/FfXDA0f5zm0VxfwNz2AjNzSKuBOSCu7F0q y5Bt5o6UIcnPtY9DQIwk5v1Y+fBi60CblmcoL7iddc7oI+tbqk9fH4z7qfqdyCQv3vmF 2qHjGpnbJMLGd9aJ0s1wKtiHMwxZsw62n08eUUYBdIfTYyD9x+DBpi4Euv8ujAchlgAw j4I4PGbmUr9Y4inPcFAqjveVKhf2/u2XH1ukuNx/fZbc+qkGb2uqCw84Tv+q5Np4lADb jc/g== X-Gm-Message-State: AOJu0YxqeAO7o5w8IT0ezUrsZBTfhVHrBhrPPZqQoeDZSv0dzrAotvsf 6ykty6UCOk2+pS61ULBA8PCF4GedMtu51hq2Q5cI7fTQFqMaK47Ufh5YviuudGFmJRbSHd7/139 vBlXBmG42TkNJHgpTxLXKprEjtB7Bb54d3hYh9K8lgZ3T44t79WI= X-Gm-Gg: ASbGncsoEn22paqfCyCi2tHRvdE5VzUgeUDKsOotgcG/dedJfHI3Kcv+X3x/EG0NB7O 7ETMdInnZ12k6KONWBmVt0bhChyrKPy4/jgauwJFPjof5KwOg X-Google-Smtp-Source: AGHT+IE/753AR/Jy6AKU3hXQkpkfNrMncAR2VZ9vm8EsCZaa/rHSFd7OGyjEgQ5xrseflQq8nogtTNf53Dpugej51tM= X-Received: by 2002:a05:6102:3049:b0:4b6:20a5:8a13 with SMTP id ada2fe7eead31-4b690c19fe5mr5579343137.13.1737207721110; Sat, 18 Jan 2025 05:42:01 -0800 (PST) MIME-Version: 1.0 References: <2dijBN1CGUPtmZzcNXZAe54y8u0pC8V_DYIBCL4rSR1eh2s8TFJGW5V3q7pkiCRFtEHYXy66CU7F6kK3NN_VAX-R_RbAXptG0b5vOlUQsi8=@protonmail.com> <87y15bcbi1.fsf@localhost> <877c7zede2.fsf@localhost> <874j2z7a8u.fsf@localhost> <87ttatigrx.fsf@localhost> <87msfxd81c.fsf@localhost> <87sepox9oy.fsf@localhost> <87wmey7hmb.fsf@localhost> <87v7uhe0tg.fsf@localhost> <878qrcdmmt.fsf@localhost> <875xmefu3v.fsf@localhost> In-Reply-To: <875xmefu3v.fsf@localhost> From: Derek Chen-Becker Date: Sat, 18 Jan 2025 06:41:50 -0700 X-Gm-Features: AbW1kvbmtu64Fe-OMS8x1-l766lNJXx-WEfUweyQj-hZwoMAjgZfYn95OtXHqNM Message-ID: Subject: Re: [BUG] Cannot tangle src block in capture buffer [9.7.6] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="0000000000001e4c34062bfb31dd" Received-SPF: pass client-ip=2607:f8b0:4864:20::e31; envelope-from=derek@chen-becker.org; helo=mail-vs1-xe31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.67 X-Spam-Score: -2.67 X-Migadu-Queue-Id: 25A2B19773 X-TUID: z1QWGGEoIoEU --0000000000001e4c34062bfb31dd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'm still sorting out the copyright assignment, but I have another style question: It feels like I should move the `should' clauses closer to the checks so that I get a more concise report when something is wrong: (ert-deftest test-org-base-buffer-file-name () "Test `org-base-buffer-file-name'." ;; Test direct buffer resolution (org-test-with-temp-text-in-file "File" (let ((base-filename (buffer-file-name))) ;; Confirm that we get the same answer whether we provide the buffer or use the default (should (equal base-filename (org-base-buffer-file-name))) (should (equal base-filename (org-base-buffer-file-name (current-buffer)))))) ;; Test indirect buffer resolution (org-test-with-temp-text-in-file "File with indirect buffer" (let ((base-filename (buffer-file-name)) (base-buffer (current-buffer)) (indirect-test-buffer (make-indirect-buffer (current-buffer) "test"))) (set-buffer indirect-test-buffer) ;; Confirm that we get the same answer for the default, the indirect buffer, and the base buffer (should (equal base-filename (org-base-buffer-file-name))) (should (equal base-filename (org-base-buffer-file-name base-buffer))) (should (equal base-filename (org-base-buffer-file-name indirect-test-buffer))) (kill-buffer indirect-test-buffer))) ;; Test for a buffer with no associated file (org-test-with-temp-text "Buffer without file" (should-not (org-base-buffer-file-name)))) Is that OK? Thanks, Derek On Thu, Jan 16, 2025 at 12:13=E2=80=AFPM Ihor Radchenko wrote: > Derek Chen-Becker writes: > > >> The latest version of your patch exceeds 20LOC and cannot be accepted > >> unless you have FSF copyright assignment. > > > > Sorry, that was clear in your previous comment. I am working on the > > assignment form right now but I expect that to be a solved problem and = I > > want to continue to contribute to Org mode anyway, so I wanted to > > parallelize that with continuing on the patch. If you would like me to > stop > > working on the patch until I have the copyright assignment taken care > of, I > > can do that, too. > > Great. If you are going to have the copyright assignment, there is no > limit on the patch size. It is just that we will need to wait until you > finalize the assignment before we actually merge it. > > But nothing stops you and me from working on the patch before that. > > >> I recommend using `org-babel-effective-tangled-filename' instead. > >> This is more future-proof against possible changes in the way file nam= e > >> is computed. > >> > > > > I'm sorry, I don't quite understand. Do you mean I should change the > > function name `org-base-buffer-file-name' to > > `org-babel-effective-tangled-filename' or something else? > > Ouch. Never mind. I misread your patch. I thought that you are using > :tangle yes in which case `org-babel-effective-tangle-filename' would be > used to auto-generate the tangle file name. But that's not the case - > you explicitly specify the tangle target. > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at . > Support Org development at , > or support my work at > --=20 +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=3Dderek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+ --0000000000001e4c34062bfb31dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm still sorting out the copyright= assignment, but I have another style question: It feels like I should move= the `should' clauses closer to the checks so that I get a more concise= report when something is wrong:

(ert-deftest test-org-base-buffer-file-name () =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 "Test `org-base-buffer-file-= name'." =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0
=C2=A0 ;; Test direct buffer resolution =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0
=C2=A0 (org-test-with-temp-text-in-file =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2= =A0 =C2=A0"File" =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0(let = ((base-filename (buffer-file-name))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0;; Confirm that we get the same an= swer whether we provide the buffer or use the default =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0(should (equal base-filename (org-base= -buffer-file-name))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0
=C2=A0 =C2=A0 =C2=A0(should (equal base-filename (org-base-buffe= r-file-name (current-buffer)))))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 ;; Test indirect buffer resolution = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0
=C2=A0 (org-test-with-temp-text-in-file =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
= =C2=A0 =C2=A0"File with indirect buffer" =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0
=C2=A0 =C2=A0(let ((base-filename (buffer-file-name)) =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(base-buffer (current-buffer)) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(i= ndirect-test-buffer (make-indirect-buffer (current-buffer) "test"= ))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0
=C2=A0 =C2=A0 =C2=A0(set-buffer indirect-test-buffer) =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2= =A0 =C2=A0 =C2=A0;; Confirm that we get the same answer for the default, th= e indirect buffer, and the base buffer
=C2=A0 =C2=A0 =C2=A0(should (equ= al base-filename (org-base-buffer-file-name))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0(should (equal base= -filename (org-base-buffer-file-name base-buffer))) =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
= =C2=A0 =C2=A0 =C2=A0(should (equal base-filename (org-base-buffer-file-name= indirect-test-buffer))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0(kill-buffer indirect-test-buffer))) = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 ;= ; Test for a buffer with no associated file =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0
=C2=A0 (org-test-with-temp-text =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0"Buffer without file" = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0(shoul= d-not (org-base-buffer-file-name))))=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0=C2=A0

Is th= at OK?

Thanks,

Derek=C2=A0

On Thu, Jan 16, 2025 at 12:13=E2=80=AFPM Ihor Radchenko <yantar92@posteo.net> wrote:
Derek Chen-Becker <= derek@chen-becke= r.org> writes:

>> The latest version of your patch exceeds 20LOC and cannot be accep= ted
>> unless you have FSF copyright assignment.
>
> Sorry, that was clear in your previous comment. I am working on the > assignment form right now but I expect that to be a solved problem and= I
> want to continue to contribute to Org mode anyway, so I wanted to
> parallelize that with continuing on the patch. If you would like me to= stop
> working on the patch until I have the copyright assignment taken care = of, I
> can do that, too.

Great. If you are going to have the copyright assignment, there is no
limit on the patch size. It is just that we will need to wait until you
finalize the assignment before we actually merge it.

But nothing stops you and me from working on the patch before that.

>> I recommend using `org-babel-effective-tangled-filename' inste= ad.
>> This is more future-proof against possible changes in the way file= name
>> is computed.
>>
>
> I'm sorry, I don't quite understand. Do you mean I should chan= ge the
> function name `org-base-buffer-file-name' to
> `org-babel-effective-tangled-filename' or something else?

Ouch. Never mind. I misread your patch. I thought that you are using
:tangle yes in which case `org-babel-effective-tangle-filename' would b= e
used to auto-generate the tangle file name. But that's not the case - you explicitly specify the tangle target.

--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>


--
+-----------------------------------------------------------= ----+
| Derek Chen-Bec= ker=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|
| GPG Key available at https://= keybase.io/dchenbecker = and=C2=A0 =C2=A0 =C2=A0 =C2=A0|
| Fngrprnt: EB8A 6480 F0A3 C8EB C1E7=C2=A0 7F42 AFC5 AFEE 96E4 6ACC= =C2=A0 |
+------------= ---------------------------------------------------+

<= /div>
--0000000000001e4c34062bfb31dd--