Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Jiajian Huang]

[-- Attachment #1.1: Type: text/plain, Size: 4575 bytes --]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
Bug(maybe): org-edit-special under org 9.x does not preserve the leading
spaces in black line or dose not indent the blank line after exit editing.


Reproduce steps:

Launch emacs by `emacs -Q`, eval the following snippet(assumed org 9.x
is installed via elpa)

    (package-initialize)
    (require 'org)

open a org buffer, input the source by <s and type `python`

#+BEGIN_SRC python

#+END_SRC

use C-c ' to edit the block and input

    for i in range(10):      # input this line and <enter>
        # there are 4 spaces before the '#' now

use C-c ' to close the source block buffer and back to org-mode, we can
see the first line of the block is indented 2 spaces by org while the blank
line
isn't.


​

Emacs  : GNU Emacs 25.1.1 (x86_64-apple-darwin16.3.0, Carbon Version 157
AppKit 1504.76)
 of 2016-12-23
Package: Org mode version 9.0.3 (9.0.3-elpa @
/Users/Yomisuko/.emacs.d/elpa/org-20161224/)

current state:
==============
(setq
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '((closure
 (org-inlinetask-min-level buffer-face-mode-face org-mode-map
  org-tbl-menu org-org-menu org-struct-menu org-entities
  org-last-state org-id-track-globally org-clock-start-time
  texmathp-why remember-data-file
  org-agenda-tags-todo-honor-ignore-options iswitchb-temp-buflist
  calc-embedded-open-mode calc-embedded-open-formula
  calc-embedded-close-formula align-mode-rules-list
  org-emphasis-alist org-emphasis-regexp-components
  org-export-registered-backends org-modules
  org-babel-load-languages t)
 nil
 (add-hook (quote change-major-mode-hook) (quote org-show-block-all)
  (quote append) (quote local))
 )
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all append
   local]
  5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
 org-cycle-show-empty-lines
 org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("id" :follow org-id-open)
      ("rmail" :follow org-rmail-open :store org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link)
      ("info" :follow org-info-open :export org-info-export :store
org-info-store-link)
      ("gnus" :follow org-gnus-open :store org-gnus-store-link)
      ("docview" :follow org-docview-open :export org-docview-export
:store org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
      ("doi" :follow org--open-doi-link)
      ("elisp" :follow org--open-elisp-link)
      ("file" :complete org-file-complete-link)
      ("ftp" :follow
(lambda (path) (browse-url (concat "ftp:" path))))
      ("help" :follow org--open-help-link)
      ("http" :follow
(lambda (path) (browse-url (concat "http:" path))))
      ("https" :follow
(lambda (path) (browse-url (concat "https:" path))))
      ("mailto" :follow
(lambda (path) (browse-url (concat "mailto:" path))))
      ("message" :follow
(lambda (path) (browse-url (concat "message:" path))))
      ("news" :follow
(lambda (path) (browse-url (concat "news:" path))))
      ("shell" :follow org--open-shell-link))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

[-- Attachment #1.2: Type: text/html, Size: 9847 bytes --]

[-- Attachment #2: org.gif --]
[-- Type: image/gif, Size: 80844 bytes --]

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Jiajian Huang]

[-- Attachment #1.1: Type: text/plain, Size: 4977 bytes --]

The issue is found in:
https://github.com/joaotavora/yasnippet/issues/761#issuecomment-270693995

On Fri, Jan 6, 2017 at 10:29 PM, Jiajian Huang <ispinfx@gmail.com> wrote:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>      http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org mailing list.
> ------------------------------------------------------------------------
> Bug(maybe): org-edit-special under org 9.x does not preserve the leading
> spaces in black line or dose not indent the blank line after exit editing.
>
>
> Reproduce steps:
>
> Launch emacs by `emacs -Q`, eval the following snippet(assumed org 9.x
> is installed via elpa)
>
>     (package-initialize)
>     (require 'org)
>
> open a org buffer, input the source by <s and type `python`
>
> #+BEGIN_SRC python
>
> #+END_SRC
>
> use C-c ' to edit the block and input
>
>     for i in range(10):      # input this line and <enter>
>         # there are 4 spaces before the '#' now
>
> use C-c ' to close the source block buffer and back to org-mode, we can
> see the first line of the block is indented 2 spaces by org while the
> blank line
> isn't.
>
>
> ​
>
> Emacs  : GNU Emacs 25.1.1 (x86_64-apple-darwin16.3.0, Carbon Version 157
> AppKit 1504.76)
>  of 2016-12-23
> Package: Org mode version 9.0.3 (9.0.3-elpa @
> /Users/Yomisuko/.emacs.d/elpa/org-20161224/)
>
> current state:
> ==============
> (setq
>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe
> org-babel-header-arg-expand)
>  org-speed-command-hook '(org-speed-command-default-hook
> org-babel-speed-command-hook)
>  org-occur-hook '(org-first-headline-recenter)
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  org-confirm-shell-link-function 'yes-or-no-p
>  org-after-todo-state-change-hook '(org-clock-out-if-current)
>  org-src-mode-hook '(org-src-babel-configure-edit-buffer
>     org-src-mode-configure-edit-buffer)
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-babel-pre-tangle-hook '(save-buffer)
>  org-mode-hook '((closure
>  (org-inlinetask-min-level buffer-face-mode-face org-mode-map
>   org-tbl-menu org-org-menu org-struct-menu org-entities
>   org-last-state org-id-track-globally org-clock-start-time
>   texmathp-why remember-data-file
>   org-agenda-tags-todo-honor-ignore-options iswitchb-temp-buflist
>   calc-embedded-open-mode calc-embedded-open-formula
>   calc-embedded-close-formula align-mode-rules-list
>   org-emphasis-alist org-emphasis-regexp-components
>   org-export-registered-backends org-modules
>   org-babel-load-languages t)
>  nil
>  (add-hook (quote change-major-mode-hook) (quote org-show-block-all)
>   (quote append) (quote local))
>  )
> #[0 "\300\301\302\303\304$\207"
>   [add-hook change-major-mode-hook org-babel-show-result-all append
>    local]
>   5]
> org-babel-result-hide-spec org-babel-hide-all-hashes)
>  org-archive-hook '(org-attach-archive-delete-maybe)
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
>  org-cycle-show-empty-lines
>  org-optimize-window-after-visibility-change)
>  org-confirm-elisp-link-function 'yes-or-no-p
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-link-parameters '(("id" :follow org-id-open)
>       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
>       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
>       ("irc" :follow org-irc-visit :store org-irc-store-link)
>       ("info" :follow org-info-open :export org-info-export :store
> org-info-store-link)
>       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
>       ("docview" :follow org-docview-open :export org-docview-export
> :store org-docview-store-link)
>       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
>       ("bbdb" :follow org-bbdb-open :export org-bbdb-export
> :complete org-bbdb-complete-link :store org-bbdb-store-link)
>       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
>       ("doi" :follow org--open-doi-link)
>       ("elisp" :follow org--open-elisp-link)
>       ("file" :complete org-file-complete-link)
>       ("ftp" :follow
> (lambda (path) (browse-url (concat "ftp:" path))))
>       ("help" :follow org--open-help-link)
>       ("http" :follow
> (lambda (path) (browse-url (concat "http:" path))))
>       ("https" :follow
> (lambda (path) (browse-url (concat "https:" path))))
>       ("mailto" :follow
> (lambda (path) (browse-url (concat "mailto:" path))))
>       ("message" :follow
> (lambda (path) (browse-url (concat "message:" path))))
>       ("news" :follow
> (lambda (path) (browse-url (concat "news:" path))))
>       ("shell" :follow org--open-shell-link))
>  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
>  )
>
>

[-- Attachment #1.2: Type: text/html, Size: 11884 bytes --]

[-- Attachment #2: org.gif --]
[-- Type: image/gif, Size: 80844 bytes --]

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Nicolas Goaziou]

Hello,

Jiajian Huang <ispinfx@gmail.com> writes:

> Reproduce steps:
>
> Launch emacs by `emacs -Q`, eval the following snippet(assumed org 9.x
> is installed via elpa)
>
>     (package-initialize)
>     (require 'org)
>
> open a org buffer, input the source by <s and type `python`
>
> #+BEGIN_SRC python
>
> #+END_SRC
>
> use C-c ' to edit the block and input
>
>     for i in range(10):      # input this line and <enter>
>         # there are 4 spaces before the '#' now
>
> use C-c ' to close the source block buffer and back to org-mode, we can
> see the first line of the block is indented 2 spaces by org while the blank
> line
> isn't.

This is not a bug. See `org-src-preserve-indentation'.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Jiajian Huang]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Hi,

Thanks for you reply. I cannot understand the design of
`org-src-preserve-indentation`.

Setting it to `nil` cause what described in my previous mail.
Setting it to `t` lose the leading two spaces indentation/alignment in the
origin org buffer.

If it is `nil`, why inserting 2 leading spaces to the code in the org
buffer except the line containing only spaces?

How can I get

#+BEGIN_SRC python
    a = 1
    b = 2
    for i in range(10):
        # 6 spaces before '#'
#+END_SRC

after exit `org-edit-special` ?

Best regards,
Jiajian Huang

On Sat, Jan 7, 2017 at 12:31 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Jiajian Huang <ispinfx@gmail.com> writes:
>
> > Reproduce steps:
> >
> > Launch emacs by `emacs -Q`, eval the following snippet(assumed org 9.x
> > is installed via elpa)
> >
> >     (package-initialize)
> >     (require 'org)
> >
> > open a org buffer, input the source by <s and type `python`
> >
> > #+BEGIN_SRC python
> >
> > #+END_SRC
> >
> > use C-c ' to edit the block and input
> >
> >     for i in range(10):      # input this line and <enter>
> >         # there are 4 spaces before the '#' now
> >
> > use C-c ' to close the source block buffer and back to org-mode, we can
> > see the first line of the block is indented 2 spaces by org while the
> blank
> > line
> > isn't.
>
> This is not a bug. See `org-src-preserve-indentation'.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2347 bytes --]

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Nicolas Goaziou]

Hello,

Jiajian Huang <ispinfx@gmail.com> writes:

> If it is `nil`, why inserting 2 leading spaces to the code in the org
> buffer except the line containing only spaces?

Probably because empty lines are not meaningful anyway. We probably
should go further and remove all spaces in empty lines.

> How can I get
>
> #+BEGIN_SRC python
>     a = 1
>     b = 2
>     for i in range(10):
>         # 6 spaces before '#'
> #+END_SRC
>
> after exit `org-edit-special` ?

You cannot obtain the last empty line. I don't understand why would you
want that either. It is only a TAB away from an empty line.


Regards,

-- 
Nicolas Goaziou

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Jiajian Huang]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

Hello,

Thanks for you reply.

I'm not trying to get the empty line. The example snippet is just for
illustration.

First of all, I really like the two space indentation/alignment when
`org-src-preserve-indentation`
is set to `nil`. And since org does not indent the empty line*s, *the fields
one empty of `yasnippet` or packages which generate empty lines can not
work properly and the indentation of these line*s* are violated
as mentioned in the second mail.

Best regards,
Jiajian Huang

On Sat, Jan 7, 2017 at 7:21 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Jiajian Huang <ispinfx@gmail.com> writes:
>
> > If it is `nil`, why inserting 2 leading spaces to the code in the org
> > buffer except the line containing only spaces?
>
> Probably because empty lines are not meaningful anyway. We probably
> should go further and remove all spaces in empty lines.
>
> > How can I get
> >
> > #+BEGIN_SRC python
> >     a = 1
> >     b = 2
> >     for i in range(10):
> >         # 6 spaces before '#'
> > #+END_SRC
> >
> > after exit `org-edit-special` ?
>
> You cannot obtain the last empty line. I don't understand why would you
> want that either. It is only a TAB away from an empty line.
>
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2352 bytes --]

Re: Bug: org-edit-special does not indent the blank line after exit editing [9.0.3 (9.0.3-elpa @ /Users/Yomisuko/.emacs.d/elpa/org-20161224/)]

[Nicolas Goaziou]

Jiajian Huang <ispinfx@gmail.com> writes:

> First of all, I really like the two space indentation/alignment when
> `org-src-preserve-indentation`
> is set to `nil`. And since org does not indent the empty line*s, *the fields
> one empty of `yasnippet` or packages which generate empty lines can not
> work properly and the indentation of these line*s* are violated
> as mentioned in the second mail.

Sorry for being bold, but I do not understand what you want.

Would removing all spaces from blank lines solve your issue? I'd rather
do this than leaving trailing spaces in the code.

Regards,