From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonard Randall Subject: Re: Feature Request. org-bibtex-tags-are-keywords inherit tags Date: Fri, 18 Apr 2014 14:44:29 +0100 Message-ID: References: <8761m89go7.fsf@bzg.ath.cx> <87tx9qj3e8.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0149c1f053e47304f7515908 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wb95n-0005Y1-S6 for emacs-orgmode@gnu.org; Fri, 18 Apr 2014 09:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wb95i-000400-V2 for emacs-orgmode@gnu.org; Fri, 18 Apr 2014 09:44:35 -0400 In-Reply-To: <87tx9qj3e8.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --089e0149c1f053e47304f7515908 Content-Type: multipart/alternative; boundary=089e0149c1f053e46d04f7515906 --089e0149c1f053e46d04f7515906 Content-Type: text/plain; charset=UTF-8 Hi Bastien, Thanks for the feedback. I have attached the modified patch. All best, Leonard On 18 April 2014 12:14, Bastien wrote: > Hi Leonard, > > thanks for starting this! A few stylistic comments inline. > > Leonard Randall writes: > > > diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el > > index ed645e5..848d0e4 100644 > > --- a/lisp/org-bibtex.el > > +++ b/lisp/org-bibtex.el > > @@ -270,20 +270,31 @@ with underscores, and characters that are not > permitted in org > > tags will be removed. > > > > If t, local tags in an org entry will be exported as a > > -comma-separated string of keywords when exported to bibtex. Tags > > -defined in `org-bibtex-tags' or `org-bibtex-no-export-tags' will > > -not be exported." > > +comma-separated string of keywords when exported to bibtex. If > > Make sure to end sentences with two spaces. > > > (defcustom org-bibtex-no-export-tags nil > > "List of tag(s) that should not be converted to keywords. > > -This variable is relevant only if `org-bibtex-export-tags-as-keywords' > is t." > > +This variable is relevant only if `org-bibtex-tags-are-keywords' is t." > > :group 'org-bibtex > > :version "24.1" > > :type '(repeat :tag "Tag" (string))) > > I fixed this docstring from the maint branch, you may need to pull > again and rewrite your changes. > > > +(defcustom org-bibtex-inherit-tags nil > > + "This variable controlls whether inherited tags are included > > The first line of the docstring should be a sentence. > > > +when converting org tags to bibtex keywords. It is relevant only > > +if `org-bibtex-tags-are-keywords' is t. Tag inheritence itself is > > +controlled by `org-use-tag-inheritence' and > > +`org-exclude-tags-from-inheritence'" > > There is a missing fullstop at the end, and missing double-space > between sentences. > > > + :group 'org-bibtex > > + :version "24.1" > > + :type 'boolean) > > Use > > :version "25.1" > :package-version '(Org . "8.3") > > here, so that users will know the option is new in Org 8.3 (the next > version that will be released from the master branc) and in Emacs 25.1 > (the next Emacs stable version that will contain 8.3.) > > Otherwise, the patch looks good. Please resubmit it from a fresh pull > with the modifications I suggested. > > Thanks in advance! > > -- > Bastien > --089e0149c1f053e46d04f7515906 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Bastien,
Thanks for the feedback. I have attached t= he modified patch.
All best,
Leonard


On 18 April 2014 12:= 14, Bastien <bzg@gnu.org> wrote:
Hi Leonard,

thanks for starting this! =C2=A0A few stylistic comments inline.

Leonard Randall <leonard.= a.randall@gmail.com> writes:

> diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el
> index ed645e5..848d0e4 100644
> --- a/lisp/org-bibtex.el
> +++ b/lisp/org-bibtex.el
> @@ -270,20 +270,31 @@ with underscores, and characters that are not pe= rmitted in org
> =C2=A0tags will be removed.
>
> =C2=A0If t, local tags in an org entry will be exported as a
> -comma-separated string of keywords when exported to bibtex. =C2=A0Tag= s
> -defined in `org-bibtex-tags' or `org-bibtex-no-export-tags' w= ill
> -not be exported."
> +comma-separated string of keywords when exported to bibtex. If

Make sure to end sentences with two spaces.

> =C2=A0(defcustom org-bibtex-no-export-tags nil
> =C2=A0 =C2=A0"List of tag(s) that should not be converted to keyw= ords.
> -This variable is relevant only if `org-bibtex-export-tags-as-keywords= ' is t."
> +This variable is relevant only if `org-bibtex-tags-are-keywords' = is t."
> =C2=A0 =C2=A0:group 'org-bibtex
> =C2=A0 =C2=A0:version "24.1"
> =C2=A0 =C2=A0:type '(repeat :tag "Tag" (string)))

I fixed this docstring from the maint branch, you may need to pull
again and rewrite your changes.

> +(defcustom org-bibtex-inherit-tags nil
> + =C2=A0"This variable controlls whether inherited tags are inclu= ded

The first line of the docstring should be a sentence.

> +when converting org tags to bibtex keywords. It is relevant only
> +if `org-bibtex-tags-are-keywords' is t. Tag inheritence itself is=
> +controlled by `org-use-tag-inheritence' and
> +`org-exclude-tags-from-inheritence'"

There is a missing fullstop at the end, and missing double-space
between sentences.

> + =C2=A0:group 'org-bibtex
> + =C2=A0:version "24.1"
> + =C2=A0:type 'boolean)

Use

=C2=A0 :version "25.1"
=C2=A0 :package-version '(Org . "8.3")

here, so that users will know the option is new in Org 8.3 (the next
version that will be released from the master branc) and in Emacs 25.1
(the next Emacs stable version that will contain 8.3.)

Otherwise, the patch looks good. =C2=A0Please resubmit it from a fresh pull=
with the modifications I suggested.

Thanks in advance!

--
=C2=A0Bastien

--089e0149c1f053e46d04f7515906-- --089e0149c1f053e47304f7515908 Content-Type: text/plain; charset=US-ASCII; name="org-bibtexpatch2.diff" Content-Disposition: attachment; filename="org-bibtexpatch2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hu5j0pe20 ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLWJpYnRleC5lbCBiL2xpc3Avb3JnLWJpYnRleC5lbAppbmRl eCBjZGIxMmI3Li41MTZmMmNmIDEwMDY0NAotLS0gYS9saXNwL29yZy1iaWJ0ZXguZWwKKysrIGIv bGlzcC9vcmctYmlidGV4LmVsCkBAIC0yNzAsOSArMjcwLDEwIEBAIHdpdGggdW5kZXJzY29yZXMs IGFuZCBjaGFyYWN0ZXJzIHRoYXQgYXJlIG5vdCBwZXJtaXR0ZWQgaW4gb3JnCiB0YWdzIHdpbGwg YmUgcmVtb3ZlZC4KIAogSWYgdCwgbG9jYWwgdGFncyBpbiBhbiBvcmcgZW50cnkgd2lsbCBiZSBl eHBvcnRlZCBhcyBhCi1jb21tYS1zZXBhcmF0ZWQgc3RyaW5nIG9mIGtleXdvcmRzIHdoZW4gZXhw b3J0ZWQgdG8gYmlidGV4LiAgVGFncwotZGVmaW5lZCBpbiBgb3JnLWJpYnRleC10YWdzJyBvciBg b3JnLWJpYnRleC1uby1leHBvcnQtdGFncycgd2lsbAotbm90IGJlIGV4cG9ydGVkLiIKK2NvbW1h LXNlcGFyYXRlZCBzdHJpbmcgb2Yga2V5d29yZHMgd2hlbiBleHBvcnRlZCB0byBiaWJ0ZXguICBJ ZgorYG9yZy1iaWJ0ZXgtaW5oZXJpdC10YWdzJyBpcyB0LCBpbmhlcml0ZWQgdGFncyB3aWxsIGFs c28gYmUKK2V4cG9ydGVkIGFzIGtleXdvcmRzLiAgVGFncyBkZWZpbmVkIGluIGBvcmctYmlidGV4 LXRhZ3MnIG9yCitgb3JnLWJpYnRleC1uby1leHBvcnQtdGFncycgd2lsbCBub3QgYmUgZXhwb3J0 ZWQuIgogICA6Z3JvdXAgJ29yZy1iaWJ0ZXgKICAgOnZlcnNpb24gIjI0LjEiCiAgIDp0eXBlICdi b29sZWFuKQpAQCAtMjg0LDYgKzI4NSwxNyBAQCBUaGlzIHZhcmlhYmxlIGlzIHJlbGV2YW50IG9u bHkgaWYgYG9yZy1iaWJ0ZXgtdGFncy1hcmUta2V5d29yZHMnIGlzIHQuIgogICA6dmVyc2lvbiAi MjQuMSIKICAgOnR5cGUgJyhyZXBlYXQgOnRhZyAiVGFnIiAoc3RyaW5nKSkpCiAKKyhkZWZjdXN0 b20gb3JnLWJpYnRleC1pbmhlcml0LXRhZ3MgbmlsCisgICJDb250cm9scyB3aGV0aGVyIGluaGVy aXRlZCB0YWdzIGFyZSBjb252ZXJ0ZWQgdG8gYmlidGV4IGtleXdvcmRzLgorSXQgaXMgcmVsZXZh bnQgb25seSBpZiBgb3JnLWJpYnRleC10YWdzLWFyZS1rZXl3b3JkcycgaXMgdC4gIFRhZyAKK2lu aGVyaXRlbmNlIGl0c2VsZiBpcyBjb250cm9sbGVkIGJ5IGBvcmctdXNlLXRhZy1pbmhlcml0ZW5j ZScgYW5kCitgb3JnLWV4Y2x1ZGUtdGFncy1mcm9tLWluaGVyaXRlbmNlJy4iCisgIDpncm91cCAn b3JnLWJpYnRleAorICA6dmVyc2lvbiAiMjUuMSIKKyAgOnBhY2thZ2UtdmVyc2lvbiAnKE9yZyAu ICI4LjMiKQorICA6dHlwZSAnYm9vbGVhbikKKworCiAoZGVmY3VzdG9tIG9yZy1iaWJ0ZXgtdHlw ZS1wcm9wZXJ0eS1uYW1lICJidHlwZSIKICAgIlByb3BlcnR5IGluIHdoaWNoIHRvIHN0b3JlIGJp YnRleCBlbnRyeSB0eXBlIChlLmcuLCBhcnRpY2xlKS4iCiAgIDpncm91cCAnb3JnLWJpYnRleApA QCAtMzMyLDcgKzM0NCw5IEBAIFRoaXMgdmFyaWFibGUgaXMgcmVsZXZhbnQgb25seSBpZiBgb3Jn LWJpYnRleC10YWdzLWFyZS1rZXl3b3JkcycgaXMgdC4iCiAJCQkJCSAgKGFwcGVuZCBvcmctYmli dGV4LXRhZ3MKIAkJCQkJCSAgb3JnLWJpYnRleC1uby1leHBvcnQtdGFncykpCiAJCQkgICAgdGFn KSkKLQkJCShvcmctZ2V0LWxvY2FsLXRhZ3MtYXQpKSkpKSkKKwkJCShpZiBvcmctYmlidGV4LWlu aGVyaXQtdGFncworCQkJICAgIChvcmctZ2V0LXRhZ3MtYXQpCisJCQkgIChvcmctZ2V0LWxvY2Fs LXRhZ3MtYXQpKSkpKSkpCiAgICAgKHdoZW4gdHlwZQogICAgICAgKGxldCAoKGVudHJ5IChmb3Jt YXQKIAkJICAgICJAJXN7JXMsXG4lc1xufVxuIiB0eXBlIGlkCg== --089e0149c1f053e47304f7515908--