From: Le Wang <l26wang@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: Bastien <bzg@altern.org>, emacs-orgmode@gnu.org
Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss
Date: Thu, 13 Dec 2012 22:36:02 +0800 [thread overview]
Message-ID: <CAM=K+iqz+xCtX1=VKbdAyfFvuj3JPEP=oqnAoY-0U0Kqo6XDag@mail.gmail.com> (raw)
In-Reply-To: <878v925aru.fsf@norang.ca>
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Thu, Dec 13, 2012 at 9:42 PM, Bernt Hansen <bernt@norang.ca> wrote:
> I'll try this patch and report back later today.
That commit was from me, and I did not test against Emacs < 24.2. I
will submit another patch to add some tests. Do tests get
automatically run on some kind of Travis CI setup?
In the mean time, I think my included patch (logic identically to
Bastien's) is more lisp-ly.
--
Le
[-- Attachment #2: org-src.el.le.patch --]
[-- Type: application/octet-stream, Size: 566 bytes --]
diff --git a/lisp/org-src.el b/lisp/org-src.el
index f91da19..6515987 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -230,7 +230,9 @@ buffer."
(beg (make-marker))
;; Move marker with inserted text for case when src block is
;; just one empty line, i.e. beg == end.
- (end (copy-marker nil t))
+ (end (let ((marker (make-marker)))
+ (set-marker-insertion-type marker t)
+ marker))
(allow-write-back-p (null code))
block-nindent total-nindent ovl lang lang-f single lfmt buffer msg
begline markline markcol line col transmitted-variables)
next prev parent reply other threads:[~2012-12-13 14:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50A62865.8010904@gmail.com>
2012-12-07 15:36 ` bug#12905: 24.2.50; org: edit source block causes data loss Chong Yidong
[not found] ` <87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org>
2012-12-12 16:55 ` Bastien
2012-12-12 21:05 ` Bernt Hansen
2012-12-12 21:34 ` Jonathan Leech-Pepin
2012-12-12 21:51 ` Bernt Hansen
2012-12-12 23:18 ` Bastien
2012-12-13 3:27 ` Bernt Hansen
2012-12-13 3:37 ` Bernt Hansen
2012-12-13 4:50 ` Nick Dokos
2012-12-13 12:45 ` Bernt Hansen
2012-12-13 13:41 ` Bernt Hansen
2012-12-13 10:36 ` Bastien
2012-12-13 13:42 ` Bernt Hansen
2012-12-13 14:36 ` Le Wang [this message]
2012-12-13 15:17 ` Bastien
2012-12-13 16:06 ` Le Wang
2012-12-13 16:25 ` Bastien
2012-12-13 23:40 ` Le Wang
2012-12-13 23:50 ` Le Wang
2012-12-14 9:38 ` Bastien
2012-12-14 9:39 ` Bastien
2012-12-16 14:39 ` Le Wang
2012-12-14 9:40 ` Bastien
2012-12-13 13:48 ` Bernt Hansen
2012-12-13 16:05 ` Bastien
2012-12-14 0:04 ` Bernt Hansen
2012-12-14 9:35 ` Bastien
2012-12-14 9:57 ` Le Wang
[not found] ` <87wqwnyzud.fsf@bzg.ath.cx>
2012-12-12 17:39 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=K+iqz+xCtX1=VKbdAyfFvuj3JPEP=oqnAoY-0U0Kqo6XDag@mail.gmail.com' \
--to=l26wang@gmail.com \
--cc=bernt@norang.ca \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).