From mboxrd@z Thu Jan 1 00:00:00 1970 From: Le Wang Subject: Re: [PATCH] org-edit-special too much space if starting with empty block Date: Sun, 18 Nov 2012 13:49:18 +0800 Message-ID: References: <87sj8jlj4b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001636c5b3e9c9bc8304cebe8f93 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:35862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZxkw-0004KY-6x for emacs-orgmode@gnu.org; Sun, 18 Nov 2012 00:49:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZxkt-0007uy-41 for emacs-orgmode@gnu.org; Sun, 18 Nov 2012 00:49:22 -0500 Received: from mail-qc0-f169.google.com ([209.85.216.169]:61918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZxks-0007uq-VF for emacs-orgmode@gnu.org; Sun, 18 Nov 2012 00:49:19 -0500 Received: by mail-qc0-f169.google.com with SMTP id t2so2959942qcq.0 for ; Sat, 17 Nov 2012 21:49:18 -0800 (PST) In-Reply-To: <87sj8jlj4b.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Orgmode Mailing List --001636c5b3e9c9bc8304cebe8f93 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Nov 9, 2012 at 8:23 AM, Nicolas Goaziou wrote: > Thank you for your patch. > > Would you mind adding comments in the function in order to explain the > need for two pass. Also, you may want to reverse the if test in order to > get rid of the progn. I've refactored and added comments. > Finally, could you provide the patch as "git format-patch" and add > a changelog entry to it? The patch is now in the requested format. If the commit message and inlined comments still aren't enough to explain the changes, please let me know. Thanks! -- Le --001636c5b3e9c9bc8304cebe8f93 Content-Type: application/octet-stream; name="org-src.el.patch" Content-Disposition: attachment; filename="org-src.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h9nqwdf20 RnJvbSBlYzM2ZjQ2YTFhYzU3ZTk5ZTM0ZGIyOWNmNzEzNzlkOTFhOGQ2YjliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZSBXYW5nIDxsZS53YW5nQGFnd29ybGQuY29tLmF1PgpEYXRl OiBTdW4sIDE4IE5vdiAyMDEyIDEzOjM5OjUxICswODAwClN1YmplY3Q6IFtQQVRDSF0gZml4IG9y Zy1lZGl0LXNyYy1jb2RlIGZvciBlbXB0eSBibG9ja3MgYW5kIGJsb2NrIHdpdGgganVzdAogYW4g ZW1wdHkgbGluZQoKLSB1c2UgbWFya2VyIHdpdGggaW5zZXJ0aW9uIHR5cGUgJ3QgdG8gdHJhY2sg ZW5kIGFuZCByZW1vdmUgaGFjayByZXF1aXJpbmcKICBkZWxldGUgZnJvbSBgYmVnJyB0byBgKDEt IGVuZCknCi0tLQogbGlzcC9vcmctc3JjLmVsIHwgMjEgKysrKysrKysrKysrKysrKy0tLS0tCiAx IGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL29yZy1zcmMuZWwgYi9saXNwL29yZy1zcmMuZWwKaW5kZXggNzVkYjFkNy4uNGJk ODVhNiAxMDA2NDQKLS0tIGEvbGlzcC9vcmctc3JjLmVsCisrKyBiL2xpc3Avb3JnLXNyYy5lbApA QCAtMjE1LDExICsyMTUsMjMgQEAgYnVmZmVyLiIKICAgICAoc2V0cSBvcmctZWRpdC1zcmMtc2F2 ZWQtdGVtcC13aW5kb3ctY29uZmlnIChjdXJyZW50LXdpbmRvdy1jb25maWd1cmF0aW9uKSkpCiAg IChsZXQqICgobWFyayAoYW5kIChvcmctcmVnaW9uLWFjdGl2ZS1wKSAobWFyaykpKQogCSAoY2Fz ZS1mb2xkLXNlYXJjaCB0KQotCSAoaW5mbyAob3JnLWVkaXQtc3JjLWZpbmQtcmVnaW9uLWFuZC1s YW5nKSkKKwkgKGluZm8KKwkgIDs7IGlmIHRoZSBzcmMgcmVnaW9uIGNvbnNpc3RlcyBvZiBubyBs aW5lcywgd2UgaW5zZXJ0IGEKKwkgIDs7IGJsYW5rIGxpbmUuCisJICAobGV0KiAoKHRlbXAgKG9y Zy1lZGl0LXNyYy1maW5kLXJlZ2lvbi1hbmQtbGFuZykpCisJCSAoYmVnIChudGggMCB0ZW1wKSkK KwkJIChlbmQgKG50aCAxIHRlbXApKSkKKwkgICAgKGlmICg8IGVuZCBiZWcpCisJCShwcm9nbiAo Z290by1jaGFyIGJlZykKKwkJICAgICAgIChpbnNlcnQgIlxuIikKKwkJICAgICAgIChvcmctZWRp dC1zcmMtZmluZC1yZWdpb24tYW5kLWxhbmcpKQorCSAgICAgIHRlbXApKSkKIAkgKGZ1bGwtaW5m byAob3JnLWJhYmVsLWdldC1zcmMtYmxvY2staW5mbyAnbGlnaHQpKQogCSAob3JnLW1vZGUtcCAo ZGVyaXZlZC1tb2RlLXAgJ29yZy1tb2RlKSkgOzsgZGVyaXZlZC1tb2RlLXAgaXMgcmVmbGV4aXZl CiAJIChiZWcgKG1ha2UtbWFya2VyKSkKLQkgKGVuZCAobWFrZS1tYXJrZXIpKQorCSA7OyBtb3Zl IG1hcmtlciB3aXRoIGluc2VydGVkIHRleHQgZm9yIGNhc2Ugd2hlbiBzcmMgYmxvY2sgaXMKKwkg OzsganVzdCBvbmUgZW1wdHkgbGluZSwgaS5lLiBiZWcgPT0gZW5kCisJIChlbmQgKGNvcHktbWFy a2VyIG5pbCB0KSkKIAkgKGFsbG93LXdyaXRlLWJhY2stcCAobnVsbCBjb2RlKSkKIAkgYmxvY2st bmluZGVudCB0b3RhbC1uaW5kZW50IG92bCBsYW5nIGxhbmctZiBzaW5nbGUgbGZtdCBidWZmZXIg bXNnCiAJIGJlZ2xpbmUgbWFya2xpbmUgbWFya2NvbCBsaW5lIGNvbCB0cmFuc21pdHRlZC12YXJp YWJsZXMpCkBAIC02ODksMTAgKzcwMSw5IEBAIHdpdGggXCIsKlwiLCBcIiwjK1wiLCBcIiwsKlwi IGFuZCBcIiwsIytcIi4iCiAgICAgICAoa2lsbC1idWZmZXIgYnVmZmVyKSkKICAgICAoZ290by1j aGFyIGJlZykKICAgICAod2hlbiBhbGxvdy13cml0ZS1iYWNrLXAKLSAgICAgIChkZWxldGUtcmVn aW9uIGJlZyAobWF4IGJlZyAoMS0gZW5kKSkpCisgICAgICAoZGVsZXRlLXJlZ2lvbiBiZWcgKG1h eCBiZWcgZW5kKSkKICAgICAgICh1bmxlc3MgKHN0cmluZy1tYXRjaCAiXFxgWyBcdF0qXFwnIiBj b2RlKQotCShpbnNlcnQgY29kZSkKLQkoZGVsZXRlLWNoYXIgMSkpCisJKGluc2VydCBjb2RlKSkK ICAgICAgIChnb3RvLWNoYXIgYmVnKQogICAgICAgKGlmIHNpbmdsZSAoanVzdC1vbmUtc3BhY2Up KSkKICAgICAoaWYgKG1lbXEgdCAobWFwY2FyIChsYW1iZGEgKG92ZXJsYXkpCi0tIAoxLjcuMTEu NAo= --001636c5b3e9c9bc8304cebe8f93--