From mboxrd@z Thu Jan  1 00:00:00 1970
From: Le Wang <l26wang@gmail.com>
Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss
Date: Sun, 16 Dec 2012 22:39:45 +0800
Message-ID: <CAM=K+ipn_m7xUZVMg7mkfdu978q10DZa-tsMRRn+fFt-6NK2yw@mail.gmail.com>
References: <50A62865.8010904@gmail.com>
	<87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org>
	<87wqwnyzud.fsf__32428.3239235685$1355331429$gmane$org@bzg.ath.cx>
	<87bodzt201.fsf@norang.ca> <877gom7tc3.fsf@bzg.ath.cx>
	<876246skbt.fsf@norang.ca> <87lid262rf.fsf@norang.ca>
	<8738za44ss.fsf@bzg.ath.cx> <878v925aru.fsf@norang.ca>
	<CAM=K+iqz+xCtX1=VKbdAyfFvuj3JPEP=oqnAoY-0U0Kqo6XDag@mail.gmail.com>
	<87wqwm0yoi.fsf@bzg.ath.cx>
	<CAM=K+iq=x557g5VeUFRr4_ZdHznD=KTNGsy1O0JuCGrLZT8eRw@mail.gmail.com>
	<87mwxhyl5l.fsf@bzg.ath.cx>
	<CAM=K+ioHiom-PNz5fV83MtA6JY1pVLG8a8YUvi08MiSUvZbyXw@mail.gmail.com>
	<87a9th55xa.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:41136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l26wang@gmail.com>) id 1TkFNb-00075V-Q9
	for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 09:39:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l26wang@gmail.com>) id 1TkFNa-0001gL-GS
	for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 09:39:47 -0500
Received: from mail-vc0-f169.google.com ([209.85.220.169]:52777)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l26wang@gmail.com>) id 1TkFNa-0001gH-Cd
	for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 09:39:46 -0500
Received: by mail-vc0-f169.google.com with SMTP id gb23so6244384vcb.0
	for <emacs-orgmode@gnu.org>; Sun, 16 Dec 2012 06:39:45 -0800 (PST)
In-Reply-To: <87a9th55xa.fsf@bzg.ath.cx>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@altern.org>
Cc: Bernt Hansen <bernt@norang.ca>, emacs-orgmode@gnu.org

On Fri, Dec 14, 2012 at 5:39 PM, Bastien <bzg@altern.org> wrote:
> Le Wang <l26wang@gmail.com> writes:
>
>>        ;; Move marker with inserted text for case when src block is
>>        ;; just one empty line, i.e. beg == end.
>> -      (end (copy-marker (make-marker) t))
>> +      (end (let ((marker (make-marker)))
>> +             (set-marker-insertion-type marker t)
>> +             marker))
>
> There is a (make-marker) in both case, the first one is okay.

Well in the first case two marker are made (make-marker, then
copy-marker), in the second one is made, IIUC of course; but it's not
a big deal.

I just had a chance to catch up on your changes.  Tests pass fine now
without structured error handling.  So I'm happy with the state of
things.


Thanks.

-- 
Le