From: Le Wang <l26wang@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-edit-special too much space if starting with empty block
Date: Fri, 23 Nov 2012 22:54:12 +0800 [thread overview]
Message-ID: <CAM=K+ipZH6i9EXmUcu9xHG=6Pgz9Vy6z9X4RfRcrH_cJJd+mjA@mail.gmail.com> (raw)
In-Reply-To: <CAM=K+ippN-uMWSJvAU6F6cCCuzqxkiYxoP_G9OtYAAZo2GJiZA@mail.gmail.com>
Has anyone had a chance to check this out? Others have run into this problem.
On Sun, Nov 18, 2012 at 1:49 PM, Le Wang <l26wang@gmail.com> wrote:
> On Fri, Nov 9, 2012 at 8:23 AM, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
>> Thank you for your patch.
>>
>> Would you mind adding comments in the function in order to explain the
>> need for two pass. Also, you may want to reverse the if test in order to
>> get rid of the progn.
>
> I've refactored and added comments.
>
>> Finally, could you provide the patch as "git format-patch" and add
>> a changelog entry to it?
>
> The patch is now in the requested format. If the commit message and
> inlined comments still aren't enough to explain the changes, please
> let me know.
>
> Thanks!
>
>
> --
> Le
--
Le
next prev parent reply other threads:[~2012-11-23 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 14:31 [PATCH] org-edit-special too much space if starting with empty block Le Wang
2012-11-08 12:33 ` Le Wang
2012-11-09 0:23 ` Nicolas Goaziou
2012-11-18 5:49 ` Le Wang
2012-11-23 14:54 ` Le Wang [this message]
2012-11-30 13:23 ` Nicolas Goaziou
2012-12-13 14:05 ` Le Wang
2012-12-13 14:05 ` Nicolas Goaziou
2012-12-13 15:15 ` Bastien
2012-12-13 15:53 ` Le Wang
2012-12-13 16:00 ` Bastien
2012-12-13 18:09 ` Achim Gratz
2012-12-13 21:53 ` Le Wang
2012-12-13 22:20 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=K+ipZH6i9EXmUcu9xHG=6Pgz9Vy6z9X4RfRcrH_cJJd+mjA@mail.gmail.com' \
--to=l26wang@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).