From: Duy Nguyen <ddnguyen2101@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Emacs-orgmode@gnu.org
Subject: Re: [PATCH v3] Show org file title in org-clock clocktable
Date: Sun, 21 Aug 2022 14:06:30 +0200 [thread overview]
Message-ID: <CAM=3T07Hrps+ExVR=MAuWbZQ0KUzMFiLAV199H2hK7UtfV6jYg@mail.gmail.com> (raw)
In-Reply-To: <87k073o2zs.fsf@localhost>
> Thanks for the update!
> Applied onto main via 2cc2d8f1f with amendments.
> I fixed on double space " " between sentences, removed autoload cookie
> (that function is not used outside org-clock), and altered the docstring
> making the first line a single sentence and clarifying about the return
> value a bit.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2cc2d8f1f6265d12c92b734931f2e3e417276b05
Thank you so much for your guidance throughout this patch, hopefully I
will be able to contribute to better patches myself in the future!
Duy
next prev parent reply other threads:[~2022-08-21 12:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 21:54 [Patch] Show org file title in org-clock clocktable Duy Nguyen
2022-08-13 8:00 ` Ihor Radchenko
2022-08-13 10:55 ` Duy Nguyen
2022-08-13 11:35 ` Ihor Radchenko
2022-08-15 6:40 ` [PATCH v2] " Duy Nguyen
2022-08-17 9:34 ` Ihor Radchenko
2022-08-17 18:53 ` [PATCH v3] " Duy Nguyen
2022-08-20 6:14 ` Ihor Radchenko
2022-08-21 12:06 ` Duy Nguyen [this message]
2022-08-28 8:11 ` Duy Nguyen
2022-08-28 8:33 ` Duy Nguyen
2022-08-28 11:30 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=3T07Hrps+ExVR=MAuWbZQ0KUzMFiLAV199H2hK7UtfV6jYg@mail.gmail.com' \
--to=ddnguyen2101@gmail.com \
--cc=Emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).