emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Duy Nguyen <ddnguyen2101@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Emacs-orgmode@gnu.org
Subject: Re: [PATCH v3] Show org file title in org-clock clocktable
Date: Wed, 17 Aug 2022 20:53:58 +0200	[thread overview]
Message-ID: <CAM=3T05hsdsoziTOyyqB0umjCRJ5pTrxd3n1BHc1zJvNv1tGeg@mail.gmail.com> (raw)
In-Reply-To: <87fshv1aet.fsf@localhost>


[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]

>
> It is not a good idea to call internal function (with "--" in name) from
> a different file. Such functions are a subject of change without notice.
>
> `org-macro-templates' is always initialized when Org mode is active, and
> you can rely on its value.
>

Thanks for letting me know. The reason I chose that method is because the
org-macro-templates are not updated immediately after I change the title
and save the file. However, I think I found a solution using
org-macro-initialize-templates and org-macro-templates. Please see the
attached patch. Hope this is OK, otherwise please let me know how to
improve.

Duy

[-- Attachment #1.2: Type: text/html, Size: 883 bytes --]

[-- Attachment #2: v3-0001-lisp-org-clock.el-Show-file-title-in-org-clock-cl.patch --]
[-- Type: application/x-patch, Size: 4030 bytes --]

  reply	other threads:[~2022-08-17 18:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 21:54 [Patch] Show org file title in org-clock clocktable Duy Nguyen
2022-08-13  8:00 ` Ihor Radchenko
2022-08-13 10:55   ` Duy Nguyen
2022-08-13 11:35     ` Ihor Radchenko
2022-08-15  6:40       ` [PATCH v2] " Duy Nguyen
2022-08-17  9:34         ` Ihor Radchenko
2022-08-17 18:53           ` Duy Nguyen [this message]
2022-08-20  6:14             ` [PATCH v3] " Ihor Radchenko
2022-08-21 12:06               ` Duy Nguyen
2022-08-28  8:11                 ` Duy Nguyen
2022-08-28  8:33                   ` Duy Nguyen
2022-08-28 11:30                     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM=3T05hsdsoziTOyyqB0umjCRJ5pTrxd3n1BHc1zJvNv1tGeg@mail.gmail.com' \
    --to=ddnguyen2101@gmail.com \
    --cc=Emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).