From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Hyatt Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time Date: Tue, 4 Feb 2020 14:25:44 -0500 Message-ID: References: <87zjswb0vq.fsf@fastmail.fm> <87siyojc2c.fsf@gmail.com> <87fvun6gku.fsf@fastmail.fm> <87ob9bkd4c.fsf@gmail.com> <87txj2lo0j.fsf@fastmail.fm> <87mwopinzv.fsf@gmail.com> <87fvucuwva.fsf@fastmail.fm> <87vc38ff84.fsf@gmail.com> <3E07FCDB-2619-4BFE-BC68-C5181717152B@gmail.com> <87haegy5i9.fsf@gmail.com> <87blqiodo6.fsf@gnu.org> <87o8ufo5l8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004310dd059dc502a4" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:53172) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz3pm-0005Mq-9x for emacs-orgmode@gnu.org; Tue, 04 Feb 2020 14:26:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz3pl-00011g-4R for emacs-orgmode@gnu.org; Tue, 04 Feb 2020 14:26:06 -0500 In-Reply-To: <87o8ufo5l8.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: Nick Dokos , "emacs-orgmode@gnu.org" --0000000000004310dd059dc502a4 Content-Type: text/plain; charset="UTF-8" I've tried the latest version from Feb 2nd, and it still has the same issue. After some more time with the issue, the issue is when the agenda has items A, and next line, invisibily (due to org-agenda-dim-blocked-tasks), B. Trying to set A gets you into an invisible loop because moving to the start of the line after displaying the time in org-agenda-show-new-time doesn't take you far enough back to proceed backwards. The next iteration through the loop, the time will be re-displayed. Removing the (beginning-of-line 1) at the end of the time display code in that function, and substituting (org-agenda-previous-line) seems to fix it. I'm not sure if that's the right approach - the previous code didn't use that function for a reason, but I don't know what that reason was. On Mon, Feb 3, 2020 at 2:04 PM Bastien wrote: > Hi Andrew, > > I have pushed some fixes in this area, if you have a chance to test > Org from the latest maint or master branch, please do so and report > if the problem persists. > > Thanks, > > -- > Bastien > --0000000000004310dd059dc502a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've tried the latest version from Feb 2nd, and it sti= ll has the same issue.

After some more time with the iss= ue, the issue is when the agenda has items A, and next line, invisibily (du= e to org-agenda-dim-blocked-tasks), B.=C2=A0 Trying to set A gets you into = an invisible loop because moving to the start of the line after displaying = the time in org-agenda-show-new-time doesn't take you far enough back t= o proceed backwards.=C2=A0 The next iteration through the loop, the time wi= ll be re-displayed.=C2=A0=C2=A0

Removing the (begi= nning-of-line 1) at the end of the time display code in that function, and = substituting (org-agenda-previous-line) seems to fix it.=C2=A0 I'm not = sure if that's the right approach - the previous code didn't use th= at function for a reason, but I don't know what that reason was.
<= /div>
O= n Mon, Feb 3, 2020 at 2:04 PM Bastien <bz= g@gnu.org> wrote:
Hi Andrew,

I have pushed some fixes in this area, if you have a chance to test
Org from the latest maint or master branch, please do so and report
if the problem persists.

Thanks,

--
=C2=A0Bastien
--0000000000004310dd059dc502a4--