From: Noam Postavsky <npostavs@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org, Aaron Jensen <aaronjensen@gmail.com>
Subject: Re: Fontification error
Date: Sun, 19 Mar 2017 14:04:49 -0400 [thread overview]
Message-ID: <CAM-tV--Zzsa_tZkUj4a=VWMMRj=GA1osreRfck4jD22tmDt+7A@mail.gmail.com> (raw)
In-Reply-To: <87r31trybx.fsf@kyleam.com>
On Sun, Mar 19, 2017 at 1:05 PM, Kyle Meyer <kyle@kyleam.com> wrote:
>>
>> * lisp/org-src.el (org-src-font-lock-fontify-block): Let-bind
>> `inhibit-modification-hooks' to nil, since this function can be called
>> from jit-lock-function which binds that variable to t (Bug#25132).
>>
>> Call modification hooks in org-src fontify buffers
>> ae8264c5cccf19d5b25a340a605bf2f07de1577e
>> Noam Postavsky
>> Sun Jan 29 11:01:32 2017 -0500
>>
>> At the moment, the minimum ECM I know of is to install spacemacs and
>> open an org file containing:
>
> [+cc Noam because I'm not sure if he follows this list.]
[Thanks, I don't follow this list indeed]
>
> I backported this commit to the Org repo, but I don't have any good
> guesses at what's leading to the error below.
I think the problem is that the let-binding's scope is too big, it's
applying to a text property change on the original org buffer, which
seems to cause problems with one of its modifcation hooks due to
narrowing. Actually, I initially posted the patch with a smaller
binding, but then enlarged it before I pushed it; I don't remember
why...
Could someone who can reproduce this problem try shrinking the scope
of (let ((inhibit-modification-hooks nil))...) to stop after the
(insert " ") as in [1], and see if that fixes it?
[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25132;att=3;filename=v1-0001-Call-modification-hooks-in-org-src-fontify-buffer.patch;msg=22
next prev parent reply other threads:[~2017-03-19 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 15:19 Fontification error Aaron Jensen
2017-03-19 17:05 ` Kyle Meyer
2017-03-19 17:12 ` Sébastien Le Maguer
2017-03-19 18:04 ` Noam Postavsky [this message]
2017-03-19 19:50 ` Aaron Jensen
2017-03-19 22:58 ` Nicolas Goaziou
2017-03-20 1:03 ` Aaron Jensen
2017-05-06 16:53 ` Thomas S. Dye
-- strict thread matches above, loose matches on Subject: below --
2017-02-13 16:58 Thomas S. Dye
2017-02-13 17:21 ` Nicolas Goaziou
2017-02-16 18:56 ` Sébastien Le Maguer
2017-02-16 21:31 ` Thomas S. Dye
2017-02-17 4:04 ` Thomas S. Dye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV--Zzsa_tZkUj4a=VWMMRj=GA1osreRfck4jD22tmDt+7A@mail.gmail.com' \
--to=npostavs@gmail.com \
--cc=aaronjensen@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).