From mboxrd@z Thu Jan 1 00:00:00 1970 From: Moritz Ulrich Subject: Regression in `org-todo' Date: Sun, 1 Apr 2012 17:01:12 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=00151750e1986c5e8a04bc9f59e2 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:46224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEMHh-000432-41 for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 11:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEMHf-0001dH-F2 for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 11:01:36 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:37865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEMHf-0001d5-5G for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 11:01:35 -0400 Received: by bkwq16 with SMTP id q16so1924405bkw.0 for ; Sun, 01 Apr 2012 08:01:33 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --00151750e1986c5e8a04bc9f59e2 Content-Type: text/plain; charset=UTF-8 Commit 6cbf1f417222321a47848a7368427ba8a22fe3a5 renames variable `last-state' to `org-last-state' in org.el. This change isn't reflected in function `org-todo'. That causes the following regression: Toggling a TODO state to DONE on a headline via C-c C-t (`org-todo') results in: "Symbol's value as variable is void: org-last-state". This is reproducible in latest HEAD and even in tag 'release_7.8.07'. M-x emacs-version: GNU Emacs 24.0.94.1 (i386-apple-darwin11.3.0, NS apple-appkit-1138.32) of 2012-03-12 on moritz-macbook.local The attached patch contains a simple (two line) fix. Cheers, Moritz Ulrich -- Moritz Ulrich --00151750e1986c5e8a04bc9f59e2 Content-Type: application/octet-stream; name="fix-org-last-state.patch" Content-Disposition: attachment; filename="fix-org-last-state.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h0i7v38s0 ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXggYzQxOGM2Ny4uMTY5 ZTE3ZCAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcuZWwKQEAgLTExMzEz LDcgKzExMzEzLDcgQEAgRm9yIGNhbGxpbmcgdGhyb3VnaCBsaXNwLCBhcmcgaXMgYWxzbyBpbnRl cnByZXRlZCBpbiB0aGUgZm9sbG93aW5nIHdheToKIAkJIChpbnRlcnByZXQgKG50aCAxIGFzcykp CiAJCSAoZG9uZS13b3JkIChudGggMyBhc3MpKQogCQkgKGZpbmFsLWRvbmUtd29yZCAobnRoIDQg YXNzKSkKLQkJIChsYXN0LXN0YXRlIChvciB0aGlzICIiKSkKKwkJIChvcmctbGFzdC1zdGF0ZSAo b3IgdGhpcyAiIikpCiAJCSAoY29tcGxldGlvbi1pZ25vcmUtY2FzZSB0KQogCQkgKG1lbWJlciAo bWVtYmVyIHRoaXMgb3JnLXRvZG8ta2V5d29yZHMtMSkpCiAJCSAodGFpbCAoY2RyIG1lbWJlcikp CkBAIC0xMTM3OSw3ICsxMTM3OSw3IEBAIEZvciBjYWxsaW5nIHRocm91Z2ggbGlzcCwgYXJnIGlz IGFsc28gaW50ZXJwcmV0ZWQgaW4gdGhlIGZvbGxvd2luZyB3YXk6CiAJCQkgIChjYXIgdGFpbCkp KSkKIAkJIChzdGF0ZSAob3IKIAkJCSAocnVuLWhvb2std2l0aC1hcmdzLXVudGlsLXN1Y2Nlc3MK LQkJCSAgJ29yZy10b2RvLWdldC1kZWZhdWx0LWhvb2sgc3RhdGUgbGFzdC1zdGF0ZSkKKwkJCSAg J29yZy10b2RvLWdldC1kZWZhdWx0LWhvb2sgc3RhdGUgb3JnLWxhc3Qtc3RhdGUpCiAJCQkgc3Rh dGUpKQogCQkgKG5leHQgKGlmIHN0YXRlIChjb25jYXQgIiAiIHN0YXRlICIgIikgIiAiKSkKIAkJ IChjaGFuZ2UtcGxpc3QgKGxpc3QgOnR5cGUgJ3RvZG8tc3RhdGUtY2hhbmdlIDpmcm9tIHRoaXMg OnRvIHN0YXRlCg== --00151750e1986c5e8a04bc9f59e2--