From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oJfPNJhA6GaXLQAAe85BDQ:P1 (envelope-from ) for ; Mon, 16 Sep 2024 14:28:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oJfPNJhA6GaXLQAAe85BDQ (envelope-from ) for ; Mon, 16 Sep 2024 16:28:41 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YkseqDRE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726496920; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1aTQ6X8U5VXvdK6Zh1c82+sghOLsMLc5nUlzhVE1UsU=; b=fJuHDQOseXUzB0oaT9ejZtxAwNiqSGPQv0wTZkitkmwDprGP3dsAFrV1kdCmFSIUtsySpR Ft1DMT9D+Z6k+BkxhA2fbipvc3ZTOa/F3ounPVbW7HwQmYUSoPc1+LY6fJLx89bnsGwCEx 6S14+XZpxkEwm000OekSJYc46RV/eO1UU/CIpBt2TTGfUg80Dggt9hd/3tXrjORRy4VQOl ccqBlmphIN7cf3g/R3ggwMr6zo9IYhko90tBSCF7Mn2TQ5VO3ugAs5lnt5kDjbTb+bpJUa VbRel1e0CyLmV/NlgxQFAUL1HE6jAF1Mg0j2wkjJYDBVD2/EsRHVRljW2e4Xkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YkseqDRE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726496920; a=rsa-sha256; cv=none; b=BxFLpdFeP/yG8STFRxap/J65r6sjZFoLpSlFttNIVICZ6FeOzdwfNt+Vgd8JGto9F1/33K m0L50UQLj2h78kLmOEeDeBJk7tlmiVo+uz8Jrb9Ot1V1TH38kXmmJ/5LANxzt+2INscDsT 4LxzYsRF4h6wfHgi7lNwxqO9yxvENO1IFQL0ND8mgOHoKxdfe7pYFfXgsicWqVk3sjQbU1 shbb/ascI51IPW8JPQRVs8Q/rcahqNVKnnoRinAkBOy8DnminMc4lNl7v9bISCaTuoIyu2 DWYn17Iglr0eH0SDDxtZ51iG1SR4UqXNKUcknuj0YOKqUU97nkTvMywaxS8baw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CBF48435A for ; Mon, 16 Sep 2024 16:28:40 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqChZ-0001ar-G8; Mon, 16 Sep 2024 10:27:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqChY-0001aj-1u for emacs-orgmode@gnu.org; Mon, 16 Sep 2024 10:27:40 -0400 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqChW-0007lR-7J for emacs-orgmode@gnu.org; Mon, 16 Sep 2024 10:27:39 -0400 Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-e04196b7603so3776595276.0 for ; Mon, 16 Sep 2024 07:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726496856; x=1727101656; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1aTQ6X8U5VXvdK6Zh1c82+sghOLsMLc5nUlzhVE1UsU=; b=YkseqDREeI7cG8KR9M0LGD73/b4U0ugeLsWYmloHgy++Yryy2/Tb49YtDo+vyGoDWB vLEYXw/napjvtlhSOxoUhBzb2P3k5TAyngdMTlfLb5GLaqdI80OTgt7nQ1QRsUkokG58 uo7UUnkkfxx9H6il2MnAy3C1+IyipkNS1iiM0Ie4taDJ71jmFMJXLp+laVxsINP+wwU2 65hicAljhrbe8L6Yt9gqHRxQRD08GixoPG/O2MA9TyhZPwI5UBMa4lqqsDn37vFXCsyi 9+2GsNFt/HFTGDFd+Dg5PFcaeH4PsV5W4oDZE8BYPvDI9dicurxtJDw1gkozRMpxe9Qf xqEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726496856; x=1727101656; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1aTQ6X8U5VXvdK6Zh1c82+sghOLsMLc5nUlzhVE1UsU=; b=LZ5wbDaWVlRQPD5HDVKeBIjrEUbM5VD+UwoHg6UM5rwqch8LRvkEqihEBDQ+Ukv0la Zcur5WJAmVzMRwRQWU7C5aU5PNbcFj+hWA+oAZ5ybZ2J3n5jikLSnhzjufTT0UIOZhWc oEqnR/vc//fMwflwwd2OefjXS4Y0m4mNNsgf8UTq+as9c5P/Vt9uCHZU7srlSDTvGWI1 GYfNZxwmgBkH6g4gDCbUNG7YrumDU6uEipSaN5rayQTcwfut/zcutuuYbW2QRwA+oJF7 P1WXJaFWZPYRwpV502AOtY/GNqUbSTCT+fm6B8mRkGA2o4oMZ3zxE+c0//BnSOglae2n WnEg== X-Gm-Message-State: AOJu0YzudKYIm6nDuApMQNBzDHSKTZ4sgFcEnDgKPGUBYHro+8SgmGVg mn460819u5Uem4udEyVF5GkVnCuRHqai3UScbCI6b4ksqfcvKXKU/W3WPT3diJ6FjwPh1pi7Z6x c/QuNs8jOdyLxZ/kL7qHGBq1DjHI= X-Google-Smtp-Source: AGHT+IFcL60UYOE2AVyIvSVWSJ9axlsfXCiFRBAfbNjeb743d0SUQF81x4WCTdtxUQv4yuvW0u8umFg0nd7UDtTO1AQ= X-Received: by 2002:a05:6902:1243:b0:e1f:e81b:dfd1 with SMTP id 3f1490d57ef6-e1fe81be094mr3955617276.14.1726496856403; Mon, 16 Sep 2024 07:27:36 -0700 (PDT) MIME-Version: 1.0 References: <87ikv3o33d.fsf@localhost> In-Reply-To: <87ikv3o33d.fsf@localhost> From: Benjamin McMillan Date: Mon, 16 Sep 2024 23:27:10 +0900 Message-ID: Subject: Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000d4faad06223d5ff4" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2c; envelope-from=mcmillanbb@gmail.com; helo=mail-yb1-xb2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 4CBF48435A X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -9.82 X-Migadu-Spam-Score: -9.82 X-TUID: leIPLpIvYIvQ --000000000000d4faad06223d5ff4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, I am happy to submit a patch. It would be my first, so I will have to find time to make the commit properly. On Wed, Sep 11, 2024 at 1:59=E2=80=AFAM Ihor Radchenko wrote: > Benjamin McMillan writes: > > > At some point in the last few months, org mode stopped fontifying my > > latex export blocks. However, an older version of emacs on my computer > > still does fontify. > > (The difference is seen even opening emacs with the -q flag) > > It seems that there was a change to the function > > org-fontify-meta-lines-and-blocks-1 in org.el, specifically at the > > conditional that checks org-src-fontify-natively. > > As the comment there explains, the intention is to only fontify src > > blocks, but I don't see any option exposed to enable fontififcation of > > export blocks, which is a fairly crucial feature to my workflow. > > > > I think fontification of export blocks should follow that of src blocks= , > > or a separate option should be made. (Or, I may be missing some already > > existing solution!) > > > > For what it is worth, I can get the desired behavior by modifying the > > code mentioned above to include "export", as in the following: > > (and org-src-fontify-natively > > ;; Technically, according to > > ;; `org-src-fontify-natively' docstring, we should > > ;; only fontify src blocks. However, it is common > > ;; to use undocumented fontification of example > > ;; blocks with undocumented language specifier. > > ;; Keep this undocumented feature for user > > ;; convenience. > > (member block-type '("src" "example" "export"))) > > Since we already do it for example blocks, I see not why we should not > for export blocks. > > Would you be interested to submit a patch with your modification? > See https://orgmode.org/worg/org-contribute.html#first-patch > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --000000000000d4faad06223d5ff4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I am happy to submit a patch. It would be my first, so= I will have to find time to make the commit properly.

On Wed, Sep 11, 2= 024 at 1:59=E2=80=AFAM Ihor Radchenko <yantar92@posteo.net> wrote:
Benjamin McMillan <mcmillanbb@gmail.com> writes:

> At some point in the last few months, org mode stopped fontifying my > latex export blocks. However, an older version of emacs on my computer=
> still does fontify.
> (The difference is seen even opening emacs with the -q flag)
> It seems that there was a change to the function
> org-fontify-meta-lines-and-blocks-1 in org.el, specifically at the
> conditional that checks org-src-fontify-natively.
> As the comment there explains, the intention is to only fontify src > blocks, but I don't see any option exposed to enable fontififcatio= n of
> export blocks, which is a fairly crucial feature to my workflow.
>
> I think fontification of export blocks should follow that of src block= s,
> or a separate option should be made. (Or, I may be missing some alread= y
> existing solution!)
>
> For what it is worth, I can get the desired behavior by modifying the<= br> > code mentioned above to include "export", as in the followin= g:
> (and org-src-fontify-natively
>=C2=A0 =C2=A0 =C2=A0;; Technically, according to
>=C2=A0 =C2=A0 =C2=A0;; `org-src-fontify-natively' docstring, we sho= uld
>=C2=A0 =C2=A0 =C2=A0;; only fontify src blocks.=C2=A0 However, it is co= mmon
>=C2=A0 =C2=A0 =C2=A0;; to use undocumented fontification of example
>=C2=A0 =C2=A0 =C2=A0;; blocks with undocumented language specifier.
>=C2=A0 =C2=A0 =C2=A0;; Keep this undocumented feature for user
>=C2=A0 =C2=A0 =C2=A0;; convenience.
>=C2=A0 =C2=A0 =C2=A0(member block-type '("src" "exam= ple" "export")))

Since we already do it for example blocks, I see not why we should not
for export blocks.

Would you be interested to submit a patch with your modification?
See https://orgmode.org/worg/org-contribute.= html#first-patch

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--000000000000d4faad06223d5ff4--