Re: [RFC] Change property drawer syntax

[Puneeth Chaganti <punchagan@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Sat, Dec 6, 2014 at 5:01 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Puneeth Chaganti <punchagan@gmail.com> writes:
>
>> It looks the commit 8d8ad983823c63b13fd6b471ce9db8c2f95e3808 broke
>> generation of org sparse trees, when searching with properties that
>> are not all uppercase.
>
> Could you provide an ECM?

I've attached the ECM.

>> The fix seems to be just removing the conversion of key to upcase in
>> `org-entry-properties'. Since the comparison with special properties
>> is being done by a case insensitive check, this should be the only fix
>> required?
>
> There is another check, case-sensitive this time, for duplicate
> properties just below.
>
> Anyway, I think the problem lies in the fact that, somewhere in the
> internals of the function generating the spare tree, there is
> a case-sensitive search.

Yes, that is correct.  I have a few code blocks that work and don't
work, in the ECM, if at all you want to look at them.

[-- Attachment #2: sparse-tree-ecm.org --]
[-- Type: application/octet-stream, Size: 790 bytes --]

* Classic
** Goldberg Variations
   :PROPERTIES:
   :Title:    Goldberg Variations
   :Composer: J.S. Bach
   :Artist:   Glen Gould
   :Publisher: Deutsche Grammophon
   :NDisks:   1
   :TEST:     1
   :END:

#+BEGIN_SRC emacs-lisp
  (org-match-sparse-tree nil "NDisks=\"1\"") ;; Does not work
  (org-match-sparse-tree nil "TEST=\"1\"")   ;; Works

  ;; The matcher created is
  (and (progn (setq org-cached-props nil) (string= (or (org-cached-entry-get nil "NDisks") "") "1")) t)
  ;; Cached entries have upcase tags and it doesn't work


  ;; This would work
  (and (progn (setq org-cached-props nil) (string= (or (org-cached-entry-get nil "NDISKS") "") "1")) t)

  ;; Also, this
  (and (progn (setq org-cached-props nil) (string= (or (org-entry-get nil "NDisks") "") "1")) t)

#+END_SRC