From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: outline-demote incorrectly demotes leaf nodes Date: Sat, 22 Oct 2011 10:15:24 +0200 Message-ID: References: <20111018105406.921@usenet.piggo.com> <4E9D4E10.6070606@christianmoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:35898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHWjo-0000q9-6v for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 04:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHWjm-0002xe-S6 for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 04:15:28 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:45677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHWjm-0002xT-K4 for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 04:15:26 -0400 Received: by wwf27 with SMTP id 27so1244639wwf.30 for ; Sat, 22 Oct 2011 01:15:25 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Bastien , emacs-orgmode@gnu.org, =?ISO-8859-1?Q?S=E9bastien_Delafond?= , Sanjoy Mahajan Hi Carsten On Fri, Oct 21, 2011 at 16:40, Carsten Dominik wrote: > On Oct 19, 2011, at 5:39 PM, Michael Brand wrote: >> (define-key org-mode-map [remap outline-promote] 'org-promote-subtree) >> (define-key org-mode-map [remap outline-demote] 'org-demote-subtree) >> [...] > > Would you like to carefully think about which other functions you > might want to have remapped ... I started to go through the functions that are bound in outline-mode-prefix-map to compare their behavior with that of the Org equivalents. Now I stumbled upon outline/org-forward/backward-same-level. All four doc strings state "Stop at the first and last subheadings of a superior heading", but the Org ones don't. As I remember, Org "motion on same level" C-c C-f/b once stopped. Git bisect shows that this had been the case before the "motion on same level" functionality moved into the new functions org-forward/backward-same-level with http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=0eaf3cce At that time the (error "No following same-level heading") disappeared. I assume that Org mode should still stop as documented and like Outline mode. If this is true I'd like to ask you if you could help to resolve this. Of course I tried to do it myself but have to admit that it would mean too much effort for me to understand what happens before and after the commit with the three optimization levels that it implements. > and then prepare a patch? I'll add the two new pairs from above and probably some more into a follow-up to this http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=b2632dc4 when I'll be finished with going through outline-mode-prefix-map. Michael