Corrupted TBLFM after table edit

Corrupted TBLFM after table edit

[Michael Brand]

Hi all

If you use release_8.2.4-14-geb28fe4 or newer and are using Org table
spreadsheet #+TBLFM then downgrade your Org version before editing
tables. In the files where you already edited a table with such an Org
release check all #+TBLFM in that file for corruption as shown below.


Hi Bastien

The change for release_8.2.4-14-geb28fe4

    commit eb28fe41dc5517e2f1d4d782eb0b5da08b90af53
    Author: Bastien Guerry <bzg@altern.org>
    Date:   Sun Dec 22 10:09:53 2013 +0100

      org-table.el (ogr-table-fix-formulas): Handle multiple #+tblfm: lines

on maint and master corrupts #+TBLFM when e. g. swapping the columns c
and d with M-<left>/M-<right> by changing $1 and $2 also in all tables
below the edit.

* ab
  | a | b |
  |---+---|
  | 0 | 1 |
  #+TBLFM: $2 = $1 + 1
* cd
  | c | d |
  |---+---|
  | 2 | 3 |
  #+TBLFM: $2 = $1 + 1
* ef
  | e | f |
  |---+---|
  | 4 | 5 |
  #+TBLFM: $2 = $1 + 1
* gh
  | g | h |
  |---+---|
  | 6 | 7 |
  #+TBLFM: $2 = $1 + 1

Michael

Re: Corrupted TBLFM after table edit

[Bastien]

Hi Michael,

Michael Brand <michael.ch.brand@gmail.com> writes:

> If you use release_8.2.4-14-geb28fe4 or newer and are using Org table
> spreadsheet #+TBLFM then downgrade your Org version before editing
> tables. In the files where you already edited a table with such an Org
> release check all #+TBLFM in that file for corruption as shown
> below.

This is now fixed, thanks.

-- 
 Bastien

Re: Corrupted TBLFM after table edit

[Michael Brand]

Hi Bastien

On Thu, Jan 9, 2014 at 11:03 AM, Bastien <bzg@gnu.org> wrote:
> This is now fixed, thanks.

The release_8.2.5c-8-ga2619b7 this refers to solves only a part of the
bugs introduced with the greedy (re-search-forward "^\\S-*$\\|\\'" nil
t). It does not work before the first headline, does not cover #+TBLFM
in list items etc. without end.

I suggest to solve this completely differently by replacing the greedy
(re-search-forward "^\\S-*$\\|\\'" nil t) and not using s-end any
more. I would change the "while" to

    (while (let ((case-fold-search t)) (looking-at "[ \t]*#\\+tblfm:"))
      [...]
      (forward-line))

which is simple and water-proof.

Michael

Re: Corrupted TBLFM after table edit

[Bastien]

Hi Michael,

Michael Brand <michael.ch.brand@gmail.com> writes:

> I suggest to solve this completely differently by replacing the greedy
> (re-search-forward "^\\S-*$\\|\\'" nil t) and not using s-end any
> more. I would change the "while" to
>
>     (while (let ((case-fold-search t)) (looking-at "[ \t]*#\\+tblfm:"))
>       [...]
>       (forward-line))
>
> which is simple and water-proof.

Yes, sure, please go ahead -- thanks in advance,

-- 
 Bastien

Re: Corrupted TBLFM after table edit

[Michael Brand]

Hi Bastien

On Thu, Jan 9, 2014 at 12:14 PM, Bastien <bzg@altern.org> wrote:
> Michael Brand <michael.ch.brand@gmail.com> writes:
>> I suggest to solve this completely differently by replacing the greedy
>> (re-search-forward "^\\S-*$\\|\\'" nil t) and not using s-end any
>> more. I would change the "while" to
>>
>>     (while (let ((case-fold-search t)) (looking-at "[ \t]*#\\+tblfm:"))
>>       [...]
>>       (forward-line))
>>
>> which is simple and water-proof.
>
> Yes, sure, please go ahead -- thanks in advance,

Done.

Michael