Bug: named columns in tables not working if name contains "_"

Bug: named columns in tables not working if name contains "_"

[András Major]

Hi,

Yet another one I just stumbled across: if I create a table and use
"!" in the first column to assign names to the columns, I can only
reference those columns by name in #+TBLFM: if the names don't contain
a "_" character.  This isn't mentioned in the docs and shouldn't be
so, IMHO.  I haven't checked for other common characters that are
prohibited, but the "_" bites me quite a bit.

  András

Re: Bug: named columns in tables not working if name contains "_"

[Nick Dokos]

András Major <andras.g.major@gmail.com> wrote:


> Yet another one I just stumbled across: if I create a table and use
> "!" in the first column to assign names to the columns, I can only
> reference those columns by name in #+TBLFM: if the names don't contain
> a "_" character.  This isn't mentioned in the docs and shouldn't be
> so, IMHO.  I haven't checked for other common characters that are
> prohibited, but the "_" bites me quite a bit.
> 

Try adding an underscore to the regexp on line 2179 of org-table.el -
something like this (untested):

          ...
	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
	      (push (cons name (int-to-string cnt)) org-table-column-names))))


The only characters permitted are alphanumerics. That can probably be
easily relaxed.

Nick

Re: Bug: named columns in tables not working if name contains

[András Major]

> Try adding an underscore to the regexp on line 2179 of org-table.el -
> something like this (untested):
> 
>           ...
> 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
> 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
> 
> The only characters permitted are alphanumerics. That can probably be
> easily relaxed.

Thanks Nick.  It would be nice if the documentation reflected such an
arbitrary choice of characters you can use...

  András

Re: Bug: named columns in tables not working if name contains "_"

[Carsten Dominik]

On Aug 23, 2011, at 3:53 PM, Nick Dokos wrote:

> András Major <andras.g.major@gmail.com> wrote:
> 
> 
>> Yet another one I just stumbled across: if I create a table and use
>> "!" in the first column to assign names to the columns, I can only
>> reference those columns by name in #+TBLFM: if the names don't contain
>> a "_" character.  This isn't mentioned in the docs and shouldn't be
>> so, IMHO.  I haven't checked for other common characters that are
>> prohibited, but the "_" bites me quite a bit.
>> 
> 
> Try adding an underscore to the regexp on line 2179 of org-table.el -
> something like this (untested):
> 
>          ...
> 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
> 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
> 
> 
> The only characters permitted are alphanumerics. That can probably be
> easily relaxed.

Hi Nick, I don't think it can be easily relaxed.  Many other characters are
operators in Calc and would lead to confusion.

But amending the docs is certainly a good idea.

Thanks

- Carsten

Re: Bug: named columns in tables not working if name contains "_"

[Nick Dokos]

Carsten Dominik <carsten.dominik@gmail.com> wrote:

> 
> On Aug 23, 2011, at 3:53 PM, Nick Dokos wrote:
> 
> > András Major <andras.g.major@gmail.com> wrote:
> > 
> > 
> >> Yet another one I just stumbled across: if I create a table and use
> >> "!" in the first column to assign names to the columns, I can only
> >> reference those columns by name in #+TBLFM: if the names don't contain
> >> a "_" character.  This isn't mentioned in the docs and shouldn't be
> >> so, IMHO.  I haven't checked for other common characters that are
> >> prohibited, but the "_" bites me quite a bit.
> >> 
> > 
> > Try adding an underscore to the regexp on line 2179 of org-table.el -
> > something like this (untested):
> > 
> >          ...
> > 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
> > 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
> > 
> > 
> > The only characters permitted are alphanumerics. That can probably be
> > easily relaxed.
> 
> Hi Nick, I don't think it can be easily relaxed.  Many other characters are
> operators in Calc and would lead to confusion.
> 

So add more syntax: formulas can use {this+is-a*/strange\@name}.

OK, ok - just kidding.

Thanks,
Nick

PS. This is a paraphrase of the indirection principle: Any problem can
    be solved by adding yet another layer of syntax...

Re: Bug: named columns in tables not working if name contains

[Bastien]

Hi András,

András Major <andras.g.major@gmail.com> writes:

> Thanks Nick.  It would be nice if the documentation reflected such an
> arbitrary choice of characters you can use...

I added a footnote.

-- 
 Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Bastien]

Hi Nick,

Nick Dokos <nicholas.dokos@hp.com> writes:

> Try adding an underscore to the regexp on line 2179 of org-table.el -
> something like this (untested):
>
>           ...
> 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
> 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
>
> The only characters permitted are alphanumerics. That can probably be
> easily relaxed.

Thanks for the suggested fix.

I've pushed a change to allow the underscore char in both field and
column names.

Best,

-- 
 Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Carsten Dominik]

On Aug 23, 2011, at 4:32 PM, Nick Dokos wrote:

> Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
>> 
>> On Aug 23, 2011, at 3:53 PM, Nick Dokos wrote:
>> 
>>> András Major <andras.g.major@gmail.com> wrote:
>>> 
>>> 
>>>> Yet another one I just stumbled across: if I create a table and use
>>>> "!" in the first column to assign names to the columns, I can only
>>>> reference those columns by name in #+TBLFM: if the names don't contain
>>>> a "_" character.  This isn't mentioned in the docs and shouldn't be
>>>> so, IMHO.  I haven't checked for other common characters that are
>>>> prohibited, but the "_" bites me quite a bit.
>>>> 
>>> 
>>> Try adding an underscore to the regexp on line 2179 of org-table.el -
>>> something like this (untested):
>>> 
>>>         ...
>>> 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
>>> 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
>>> 
>>> 
>>> The only characters permitted are alphanumerics. That can probably be
>>> easily relaxed.
>> 
>> Hi Nick, I don't think it can be easily relaxed.  Many other characters are
>> operators in Calc and would lead to confusion.
>> 
> 
> So add more syntax: formulas can use {this+is-a*/strange\@name}.
> 
> OK, ok - just kidding.
> 
> Thanks,
> Nick
> 
> PS. This is a paraphrase of the indirection principle: Any problem can
>    be solved by adding yet another layer of syntax...

:) Yes, true!
- Carsten

Re: Bug: named columns in tables not working if name contains "_"

[Bastien]

Hi Carsten,

Carsten Dominik <carsten.dominik@gmail.com> writes:

>> The only characters permitted are alphanumerics. That can probably be
>> easily relaxed.
>
> Hi Nick, I don't think it can be easily relaxed.  Many other characters are
> operators in Calc and would lead to confusion.

So perhaps my recent commit is wrong.   I did a few tests and found no
problem, but I'm certainly not using calc operators that much.  Please 
feel free to revert commit 76ab4dd422216ff2c574be4586ba161b8c40704e if
necessary...

> But amending the docs is certainly a good idea.

... and commit f893659b272ef80c1da8c0420d55b6237a4c3f00 about the doc.

Thanks!

-- 
 Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Achim Gratz]

Nick Dokos <nicholas.dokos@hp.com> writes:
> The only characters permitted are alphanumerics. That can probably be
> easily relaxed.

Only if you don't want to have _underlined_ still working and perhaps
never use calc on that table.  The problem with simple syntax is that
the quoting rules become bizarre and the other way around.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: Bug: named columns in tables not working if name contains "_"

[Carsten Dominik]

On 23.8.2011, at 18:20, Bastien wrote:

> Hi Carsten,
> 
> Carsten Dominik <carsten.dominik@gmail.com> writes:
> 
>>> The only characters permitted are alphanumerics. That can probably be
>>> easily relaxed.
>> 
>> Hi Nick, I don't think it can be easily relaxed.  Many other characters are
>> operators in Calc and would lead to confusion.
> 
> So perhaps my recent commit is wrong.   I did a few tests and found no
> problem, but I'm certainly not using calc operators that much.  Please 
> feel free to revert commit 76ab4dd422216ff2c574be4586ba161b8c40704e if
> necessary...

I'll take a look.

- Carsten


> 
>> But amending the docs is certainly a good idea.
> 
> ... and commit f893659b272ef80c1da8c0420d55b6237a4c3f00 about the doc.
> 
> Thanks!
> 
> -- 
> Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Carsten Dominik]

On 23.8.2011, at 18:20, Bastien wrote:

> Hi Carsten,
> 
> Carsten Dominik <carsten.dominik@gmail.com> writes:
> 
>>> The only characters permitted are alphanumerics. That can probably be
>>> easily relaxed.
>> 
>> Hi Nick, I don't think it can be easily relaxed.  Many other characters are
>> operators in Calc and would lead to confusion.
> 
> So perhaps my recent commit is wrong.   I did a few tests and found no
> problem, but I'm certainly not using calc operators that much.  Please 
> feel free to revert commit 76ab4dd422216ff2c574be4586ba161b8c40704e if
> necessary...

I have checked, underscore is aceptable, calc allows it in variables names.
However, I would not recommend adding any more characters to this regexp.

- Carsten


> 
>> But amending the docs is certainly a good idea.
> 
> ... and commit f893659b272ef80c1da8c0420d55b6237a4c3f00 about the doc.
> 
> Thanks!
> 
> -- 
> Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Bastien]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> I have checked, underscore is aceptable, calc allows it in variables
> names.  However, I would not recommend adding any more characters to
> this regexp.

Thanks for the quick feedback!

-- 
 Bastien

Re: Bug: named columns in tables not working if name contains "_"

[Michael Brand]

On Tue, Aug 23, 2011 at 20:29, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> I have checked, underscore is aceptable, calc allows it in variables names.
> However, I would not recommend adding any more characters to this regexp.

Just to mention: Although "_" is the subscript operator that takes the
nth vector element in Calc, I don't mind the change since the formula
below that uses "$vector_1" did also not work before the change
probably because some other regexp to parse the field name already
included "_". And the alternative formula with "subscr($vector, 1)"
seems to be syntactically more robust/flexible/clear/etc. anyway.

|   | [x y]  | x | x | #ERROR | x |
| ^ | vector |   |   |        |   |
#+TBLFM: @<$3 = $2_1 :: @<$4 = subscr($2, 1) :: @<$5 = $vector_1 ::
@<$6 = subscr($vector, 1)

Michael

Re: Bug: named columns in tables not working if name contains "_"

[Michael Brand]

On Tue, Aug 23, 2011 at 18:24, Achim Gratz <Stromeko@nexgo.de> wrote:
> Nick Dokos <nicholas.dokos@hp.com> writes:
>> The only characters permitted are alphanumerics. That can probably be
>> easily relaxed.
>
> Only if you don't want to have _underlined_ still working [...]

I use _underlined_ in tables and I'm glad it still works.

Michael

Re: Bug: named columns in tables not working if name contains "_"

[Nick Dokos]

Michael Brand <michael.ch.brand@gmail.com> wrote:

> On Tue, Aug 23, 2011 at 20:29, Carsten Dominik
> <carsten.dominik@gmail.com> wrote:
> > I have checked, underscore is aceptable, calc allows it in variables names.
> > However, I would not recommend adding any more characters to this regexp.
> 
> Just to mention: Although "_" is the subscript operator that takes the
> nth vector element in Calc, I don't mind the change since the formula
> below that uses "$vector_1" did also not work before the change
> probably because some other regexp to parse the field name already
> included "_". And the alternative formula with "subscr($vector, 1)"
> seems to be syntactically more robust/flexible/clear/etc. anyway.
> 
> |   | [x y]  | x | x | #ERROR | x |
> | ^ | vector |   |   |        |   |
> #+TBLFM: @<$3 = $2_1 :: @<$4 = subscr($2, 1) :: @<$5 = $vector_1 ::
> @<$6 = subscr($vector, 1)
> 

That's worth recording somewhere in Worg, methinks.

Nick

Re: Bug: named columns in tables not working if name contains "_"

[Nick Dokos]

Michael Brand <michael.ch.brand@gmail.com> wrote:

> On Tue, Aug 23, 2011 at 18:24, Achim Gratz <Stromeko@nexgo.de> wrote:
> > Nick Dokos <nicholas.dokos@hp.com> writes:
> >> The only characters permitted are alphanumerics. That can probably be
> >> easily relaxed.
> >
> > Only if you don't want to have _underlined_ still working [...]
> 
> I use _underlined_ in tables and I'm glad it still works.
> 

Yeah, but Achim has a point: do underlined column names work? I'd guess
not if the name contains an underscore.  Does it matter if they don't?
Not to me, but others might disagree.

Nick