From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: outline-demote incorrectly demotes leaf nodes Date: Wed, 9 Nov 2011 19:16:22 +0100 Message-ID: References: <20111018105406.921@usenet.piggo.com> <4E9D4E10.6070606@christianmoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0015174481ec07d4a504b1514934 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:34172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROChG-0005qZ-Bh for emacs-orgmode@gnu.org; Wed, 09 Nov 2011 13:16:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROChE-00086L-Qi for emacs-orgmode@gnu.org; Wed, 09 Nov 2011 13:16:26 -0500 Received: from mail-ww0-f41.google.com ([74.125.82.41]:62797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROChE-00086C-7k for emacs-orgmode@gnu.org; Wed, 09 Nov 2011 13:16:24 -0500 Received: by wwf27 with SMTP id 27so8259403wwf.0 for ; Wed, 09 Nov 2011 10:16:23 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --0015174481ec07d4a504b1514934 Content-Type: text/plain; charset=ISO-8859-1 Hi Carsten Attached is the patch with this changelog: Completion of remapping for Outline functions * lisp/org.el Key bindings: remap the Outline functions from `outline-mode-prefix-map' where possible. Michael On Sat, Oct 22, 2011 at 10:15, Michael Brand wrote: > On Fri, Oct 21, 2011 at 16:40, Carsten Dominik > wrote: >> Would you like to carefully think about which other functions you >> might want to have remapped ... > > I started to go through the functions that are bound in > outline-mode-prefix-map to compare their behavior with that of the Org > equivalents. Now I stumbled upon > outline/org-forward/backward-same-level. All four doc strings state > "Stop at the first and last subheadings of a superior heading", but > the Org ones don't. As I remember, Org "motion on same level" C-c > C-f/b once stopped. Git bisect shows that this had been the case > before the "motion on same level" functionality moved into the new > functions org-forward/backward-same-level with > http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=0eaf3cce > At that time the (error "No following same-level heading") > disappeared. > > I assume that Org mode should still stop as documented and like > Outline mode. If this is true I'd like to ask you if you could help to > resolve this. Of course I tried to do it myself but have to admit that > it would mean too much effort for me to understand what happens before > and after the commit with the three optimization levels that it > implements. > >> and then prepare a patch? > > I'll add the two new pairs from above and probably some more into a > follow-up to this > http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=b2632dc4 > when I'll be finished with going through outline-mode-prefix-map. --0015174481ec07d4a504b1514934 Content-Type: text/plain; charset=US-ASCII; name="0001-Completion-of-remapping-for-Outline-functions.patch.txt" Content-Disposition: attachment; filename="0001-Completion-of-remapping-for-Outline-functions.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gusnb4ye0 RnJvbSA4ZGU0NzI5NjE2OGFlOWM4M2E4MTg5OTA0NmNlNzlhMTYxMzZjNmVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWls LmNvbT4KRGF0ZTogV2VkLCA5IE5vdiAyMDExIDE5OjA3OjQ1ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gQ29tcGxldGlvbiBvZiByZW1hcHBpbmcgZm9yIE91dGxpbmUgZnVuY3Rpb25zCgoqIGxpc3Av b3JnLmVsIEtleSBiaW5kaW5nczogcmVtYXAgdGhlIE91dGxpbmUgZnVuY3Rpb25zIGZyb20KYG91 dGxpbmUtbW9kZS1wcmVmaXgtbWFwJyB3aGVyZSBwb3NzaWJsZS4KLS0tCiBsaXNwL29yZy5lbCB8 ICAgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiAxIGZpbGVzIGNoYW5n ZWQsIDM1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9v cmcuZWwgYi9saXNwL29yZy5lbAppbmRleCA1YzRlYTMzLi5lMjRjZGFlIDEwMDY0NAotLS0gYS9s aXNwL29yZy5lbAorKysgYi9saXNwL29yZy5lbApAQCAtMTcwNzQsOSArMTcwNzQsNDMgQEAgKGRl ZnVuIG9yZy1yZW1vdmUtaW5saW5lLWltYWdlcyAoKQogCiA7Ozs7IEtleSBiaW5kaW5ncwogCi07 OyBSZW1hcCBvdXRsaW5lIGtleXMKKzs7IE91dGxpbmUgZnVuY3Rpb25zIGZyb20gYG91dGxpbmUt bW9kZS1wcmVmaXgtbWFwJworOzsgdGhhdCBjYW4gYmUgcmVtYXBwZWQgaW4gT3JnOgorKGRlZmlu ZS1rZXkgb3JnLW1vZGUtbWFwIFtyZW1hcCBvdXRsaW5lLW1hcmstc3VidHJlZV0gJ29yZy1tYXJr LXN1YnRyZWUpCisoZGVmaW5lLWtleSBvcmctbW9kZS1tYXAgW3JlbWFwIHNob3ctc3VidHJlZV0g J29yZy1zaG93LXN1YnRyZWUpCisoZGVmaW5lLWtleSBvcmctbW9kZS1tYXAgW3JlbWFwIG91dGxp bmUtZm9yd2FyZC1zYW1lLWxldmVsXQorICAnb3JnLWZvcndhcmQtc2FtZS1sZXZlbCkKKyhkZWZp bmUta2V5IG9yZy1tb2RlLW1hcCBbcmVtYXAgb3V0bGluZS1iYWNrd2FyZC1zYW1lLWxldmVsXQor ICAnb3JnLWJhY2t3YXJkLXNhbWUtbGV2ZWwpCisoZGVmaW5lLWtleSBvcmctbW9kZS1tYXAgW3Jl bWFwIHNob3ctYnJhbmNoZXNdCisgICdvcmcta2lsbC1ub3RlLW9yLXNob3ctYnJhbmNoZXMpCiAo ZGVmaW5lLWtleSBvcmctbW9kZS1tYXAgW3JlbWFwIG91dGxpbmUtcHJvbW90ZV0gJ29yZy1wcm9t b3RlLXN1YnRyZWUpCiAoZGVmaW5lLWtleSBvcmctbW9kZS1tYXAgW3JlbWFwIG91dGxpbmUtZGVt b3RlXSAnb3JnLWRlbW90ZS1zdWJ0cmVlKQorKGRlZmluZS1rZXkgb3JnLW1vZGUtbWFwIFtyZW1h cCBvdXRsaW5lLWluc2VydC1oZWFkaW5nXSAnb3JnLWN0cmwtYy1yZXQpCisKKzs7IE91dGxpbmUg ZnVuY3Rpb25zIGZyb20gYG91dGxpbmUtbW9kZS1wcmVmaXgtbWFwJworOzsgdGhhdCBjYW4gbm90 IGJlIHJlbWFwcGVkIGluIE9yZzoKKzs7IC0gdGhlIGNvbHVtbiAia2V5IGJpbmRpbmciIHNob3dz IHdoZXRoZXIgdGhlIE91dGxpbmUgZnVuY3Rpb24gaXMgc3RpbGwKKzs7ICAgYXZhaWxhYmxlIGlu IE9yZyBtb2RlIG9uIHRoZSBzYW1lIGtleSB0aGF0IGl0IGhhcyBiZWVuIGJvdW5kIHRvIGluCis7 OyAgIE91dGxpbmUgbW9kZToKKzs7ICAgLSAib3ZlcnJpZGRlbiI6IGtleSB1c2VkIGZvciBhIGRp ZmZlcmVudCBmdW5jdGlvbmFsaXR5IGluIE9yZyBtb2RlCis7OyAgIC0gZWxzZToga2V5IHN0aWxs IGJvdW5kIHRvIHRoZSBzYW1lIE91dGxpbmUgZnVuY3Rpb24gaW4gT3JnIG1vZGUKKzs7IHwgT3V0 bGluZSBmdW5jdGlvbiAgICAgICAgICAgICAgICAgICB8IGtleSBiaW5kaW5nIHwgT3JnIHJlcGxh Y2VtZW50ICAgICAgIHwKKzs7IHwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0r LS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLXwKKzs7IHwgYG91dGxpbmUtbmV4 dC12aXNpYmxlLWhlYWRpbmcnICAgICB8IGBDLWMgQy1uJyAgIHwgc3RpbGwgc2FtZSBmdW5jdGlv biAgIHwKKzs7IHwgYG91dGxpbmUtcHJldmlvdXMtdmlzaWJsZS1oZWFkaW5nJyB8IGBDLWMgQy1w JyAgIHwgc3RpbGwgc2FtZSBmdW5jdGlvbiAgIHwKKzs7IHwgYHNob3ctY2hpbGRyZW4nICAgICAg ICAgICAgICAgICAgICB8IGBDLWMgQy1pJyAgIHwgdmlzaWJpbGl0eSBjeWNsaW5nICAgIHwKKzs7 IHwgYGhpZGUtc3VidHJlZScgICAgICAgICAgICAgICAgICAgICB8IG92ZXJyaWRkZW4gIHwgdmlz aWJpbGl0eSBjeWNsaW5nICAgIHwKKzs7IHwgYG91dGxpbmUtdXAtaGVhZGluZycgICAgICAgICAg ICAgICB8IGBDLWMgQy11JyAgIHwgc3RpbGwgc2FtZSBmdW5jdGlvbiAgIHwKKzs7IHwgYGhpZGUt Ym9keScgICAgICAgICAgICAgICAgICAgICAgICB8IG92ZXJyaWRkZW4gIHwgbm8gcmVwbGFjZW1l bnQgICAgICAgIHwKKzs7IHwgYHNob3ctYWxsJyAgICAgICAgICAgICAgICAgICAgICAgICB8IG92 ZXJyaWRkZW4gIHwgbm8gcmVwbGFjZW1lbnQgICAgICAgIHwKKzs7IHwgYGhpZGUtZW50cnknICAg ICAgICAgICAgICAgICAgICAgICB8IG92ZXJyaWRkZW4gIHwgdmlzaWJpbGl0eSBjeWNsaW5nICAg IHwKKzs7IHwgYHNob3ctZW50cnknICAgICAgICAgICAgICAgICAgICAgICB8IG92ZXJyaWRkZW4g IHwgbm8gcmVwbGFjZW1lbnQgICAgICAgIHwKKzs7IHwgYGhpZGUtbGVhdmVzJyAgICAgICAgICAg ICAgICAgICAgICB8IG92ZXJyaWRkZW4gIHwgbm8gcmVwbGFjZW1lbnQgICAgICAgIHwKKzs7IHwg YGhpZGUtc3VibGV2ZWxzJyAgICAgICAgICAgICAgICAgICB8IG92ZXJyaWRkZW4gIHwgbm8gcmVw bGFjZW1lbnQgICAgICAgIHwKKzs7IHwgYGhpZGUtb3RoZXInICAgICAgICAgICAgICAgICAgICAg ICB8IG92ZXJyaWRkZW4gIHwgbm8gcmVwbGFjZW1lbnQgICAgICAgIHwKKzs7IHwgYG91dGxpbmUt bW92ZS1zdWJ0cmVlLXVwJyAgICAgICAgICB8IGBDLWMgQy1eJyAgIHwgYmV0dGVyOiBvcmctc2hp ZnR1cCAgIHwKKzs7IHwgYG91dGxpbmUtbW92ZS1zdWJ0cmVlLWRvd24nICAgICAgICB8IG92ZXJy aWRkZW4gIHwgYmV0dGVyOiBvcmctc2hpZnRkb3duIHwKIAogOzsgTWFrZSBgQy1jIEMteCcgYSBw cmVmaXgga2V5CiAob3JnLWRlZmtleSBvcmctbW9kZS1tYXAgIlxDLWNcQy14IiAobWFrZS1zcGFy c2Uta2V5bWFwKSkKLS0gCjEuNi4yLjEKCg== --0015174481ec07d4a504b1514934--