From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Makefile restructuring Date: Sun, 30 Oct 2011 15:20:37 +0100 Message-ID: References: <87k4bqwkyw.fsf@gnu.org> <87sjqejvob.fsf@Rainer.invalid> <87k4bqjnwu.fsf@Rainer.invalid> <87fwmdkind.fsf@Rainer.invalid> <874o2t81qu.fsf@gnu.org> <87liw43iys.fsf@Rainer.invalid> <8762n8d4ys.fsf@gnu.org> <87ei1u6u3q.fsf_-_@Rainer.invalid> <87hb6i3z1l.fsf@Rainer.invalid> <87bot1ph9h.fsf@Rainer.invalid> <87ehxvlyrn.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:35823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKWFb-0002Q2-2W for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 10:20:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKWFZ-0001ze-LP for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 10:20:39 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:65131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKWFZ-0001xk-Ev for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 10:20:37 -0400 Received: by mail-wy0-f169.google.com with SMTP id 24so59221wyg.0 for ; Sun, 30 Oct 2011 07:20:37 -0700 (PDT) In-Reply-To: <87ehxvlyrn.fsf@Rainer.invalid> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim On Sun, Oct 30, 2011 at 08:33, Achim Gratz wrote: >> In case the errors are confirmed: My guess is that again you have a >> better solution than me and I don't propose a patch yet. (org-version) >> uses (file-exists-p (expand-file-name ".git" dir)) and >> (executable-find "git") for this. > > You are talking about org-version here? I don't consider org-version to be used in the Makefile but assume that the same tests have to be made there. >=A0That code is not mine (I only > added another defconst to be able to record the version string during > install). =A0I have never tried what happens when not installed and no gi= t > is present... so please if that does indeed break put a patch to master, > as the problem should already be present there. =A0AFAIK the code should > just drop down to no appending the description string. No worry, org-version gets along with that. > GNU Makefile standards ask that a help target be available and that make > without arguments should show the help rather than freak you out with > starting to do something you may not have wanted to do. Good to know. I prefer the standard and like that the GNU Makefile default target is standardized this way. Michael