From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: "git describe" in version of info file with "make info_git_describe" Date: Wed, 26 Oct 2011 18:07:58 +0200 Message-ID: References: <87fwnse1d8.fsf@norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:58383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ61M-00036t-Tg for emacs-orgmode@gnu.org; Wed, 26 Oct 2011 12:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ61I-0005yw-Qh for emacs-orgmode@gnu.org; Wed, 26 Oct 2011 12:08:04 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:59684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ61I-0005yo-MN for emacs-orgmode@gnu.org; Wed, 26 Oct 2011 12:08:00 -0400 Received: by wwf27 with SMTP id 27so2045994wwf.30 for ; Wed, 26 Oct 2011 09:07:59 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik , Bastien Guerry Cc: Bernt Hansen , Org Mode Hi Carsten and Bastien On Fri, Oct 21, 2011 at 16:44, Carsten Dominik wrote: > is there an agreement that this is a good patch? =A0I have not followed t= he discussion..... Let me summarize: > On Oct 16, 2011, at 9:12 PM, Michael Brand wrote: >> The previous patch attachment had a wrong mime type, could therefore >> not be caught by patchwork and has not been accepted. Only a clarification about "has not been accepted": The first version of my patch has just not been applied, there was no disagreement or reject. The second version was only to get my patch into patchwork at all and to rebase it at the design level. For the change in org-version (substitution of the "-" from the git tag delivered by git describe with "."): As Bernt is the author of this substitution I originally asked him if I could remove it to align with the output of git describe and he agreed. He now has reviewed this part of the second version of my patch and he is fine with it. There has not yet been any review or comment on the changes in the Makefile and in UTILITIES/set-version.pl. I would be happy if these parts could be reviewed too. Michael