From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Brand <michael.ch.brand@gmail.com>
Subject: Re: Add the capture feature "%(sexp)" to org-feed
Date: Thu, 9 Aug 2012 16:07:41 +0200
Message-ID: <CALn3zogGT5Lr2Fj4JdGQ8Q3S+Ry7NY5mQAdQTJ2FQZxc=0m3Bg@mail.gmail.com>
References: <michael.ch.brand@gmail.com>
	<CALn3zojPR+yudDsmJxX4Q_CjahwOi7uAOOw6ehOHQoB1CL4=Pg@mail.gmail.com>
	<7822.1339898820@alphaville>
	<CALn3zoipejd1=f_KR3V0qAphReU6P5nWj0jiy56MmdG0hT4njw@mail.gmail.com>
	<87y5lqe21l.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:39919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael.ch.brand@gmail.com>) id 1SzTOu-0005DD-2D
	for emacs-orgmode@gnu.org; Thu, 09 Aug 2012 10:07:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael.ch.brand@gmail.com>) id 1SzTOo-0004ay-7H
	for emacs-orgmode@gnu.org; Thu, 09 Aug 2012 10:07:47 -0400
In-Reply-To: <87y5lqe21l.fsf@gnu.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@gnu.org>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hi Bastien

Thank you for reviewing my patch.

On Wed, Aug 8, 2012 at 1:05 AM, Bastien <bzg@gnu.org> wrote:

> I've reworked some parts of your patch,

You omitted the Local variables sentence-end-double-space: t. Isn't
this a good idea for all the users like me that have set this to nil
in their config? I wanted to add it to more files as soon as I will
change them.

=93The current date.=94 is probably meant to remain =93the current date.=94=
.

> specifically, I used `org-at-regexp-p' instead of
> `org-capture-inside-embedded-elisp-p'.

With `org-capture-inside-embedded-elisp-p' I wanted to be quite more
waterproof than `org-at-regexp-p' with the new additional closing
parenthesis in `org-capture-template-embedded-elisp-re'. See its
comment =93to deal with for example %(length ")")=94. Isn't it a good idea
to use `forward-sexp' in Emacs Lisp Mode for this? What can I improve?

> Can you check this is working okay for you?

I'll do with the final version of the patch if there will be changes.

Michael