From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Makefile restructuring Date: Sat, 29 Oct 2011 13:22:50 +0200 Message-ID: References: <87k4bqwkyw.fsf@gnu.org> <87sjqejvob.fsf@Rainer.invalid> <87k4bqjnwu.fsf@Rainer.invalid> <87fwmdkind.fsf@Rainer.invalid> <874o2t81qu.fsf@gnu.org> <87liw43iys.fsf@Rainer.invalid> <8762n8d4ys.fsf@gnu.org> <87ei1u6u3q.fsf_-_@Rainer.invalid> <87hb6i3z1l.fsf@Rainer.invalid> <87bot1ph9h.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:44987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK702-0008G3-Nq for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:22:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RK701-0004Rt-0z for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:22:54 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:52061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK700-0004Ro-Pz for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:22:52 -0400 Received: by wwe3 with SMTP id 3so95445wwe.30 for ; Sat, 29 Oct 2011 04:22:51 -0700 (PDT) In-Reply-To: <87bot1ph9h.fsf@Rainer.invalid> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim On Fri, Oct 28, 2011 at 12:00, Achim Gratz wrote: > As discussed in another thread, the version from git-describe is now > also recorded into the info documentation. see here for the thread: http://lists.gnu.org/archive/html/emacs-orgmode/2011-06/msg00054.html I have looked into your branch only now. I think it is uncommon for Makefiles how clean they look now and I appreciate how the Makefile has been split up plus one is in doc/ and one in lisp/, that there are no explicit xy.el any more and so on. Thank you for this work. Some comments: There is no @value{DATE}, missing already on master. Would it be ok to remove setting the DATE or to include it in org.texi like the commit message subject anticipates? In the latter case it could be labeled "build date" and optionally when available be enriched with "release date", looked up from the git tag when make is running in a git repo not dirty and if git is installed. Maybe "release date" could also become visible in org-version when running from .el in a git repo not dirty and if git is installed or when running from .elc built with the same git requirement. Both would help users to be aware of how outdated their version is and more. These are only suggestions, else I'm fine with removing DATE. I would prefer the file/target name variables.texi instead of git-describe.texi as git describe is not necessarily involved and must not be a requirement. Did you check this?: - make info when not in a git repo - make info when in a git repo but git is not installed In case the errors are confirmed: My guess is that again you have a better solution than me and I don't propose a patch yet. (org-version) uses (file-exists-p (expand-file-name ".git" dir)) and (executable-find "git") for this. The default make target has been changed from "all" to "targets help". Is this standard? I assume that you considered that this can break the target "org-mode" of some upper level Makefile from users (and Emacs?). Michael