[Patch]: Ignore search option when org-lint local file link

[Patch]: Ignore search option when org-lint local file link

[Lei Zhe]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

For the link [[file:example.pdf::2]], org-lint identifies it as an invalid link.
This patch aims to address the issue.

[-- Attachment #2: 0001-Check-local-file-link-ignoring-path-option.patch --]
[-- Type: application/octet-stream, Size: 828 bytes --]

From a194ca2c1f71b679e16db20b32634413623454d8 Mon Sep 17 00:00:00 2001
From: llcc <lzhes43@gmail.com>
Date: Sun, 19 Jan 2025 17:11:39 +0800
Subject: [PATCH] Check local file link ignoring path option

---
 lisp/org-lint.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/org-lint.el b/lisp/org-lint.el
index 3ab718eac..083cb2c3d 100644
--- a/lisp/org-lint.el
+++ b/lisp/org-lint.el
@@ -728,6 +728,9 @@ Use :header-args: instead"
 	(pcase type
 	  ((or "attachment" "file")
 	   (let* ((path (org-element-property :path l))
+                  (path (if (string-match "::\\(.*\\)\\'" path)
+		            (substring path 0 (match-beginning 0))
+                          path))
 		  (file (if (string= type "file")
 			    path
                           (org-with-point-at (org-element-begin l)
-- 
2.37.2.windows.2

Re: [Patch]: Ignore search option when org-lint local file link

[Ihor Radchenko]

Lei Zhe <lzhes43@gmail.com> writes:

> For the link [[file:example.pdf::2]], org-lint identifies it as an invalid link.
> This patch aims to address the issue.

I am unable to reproduce this problem. M-x org-lint does not show any
warning after I change the link to point to an existing file.

I tested on the latest main.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [Patch]: Ignore search option when org-lint local file link

[Lei Zhe]

Sorry, it was [[attachment:example.pdf::2]].
The lint for [[file:example.pdf::2]] is fine, since
org-element-context returns the raw path without the search option.
However, this is not the case for [[attachment:example.pdf::2]].

On Sun, Jan 19, 2025 at 5:57 PM Ihor Radchenko <yantar92@posteo.net> wrote:
>
> Lei Zhe <lzhes43@gmail.com> writes:
>
> > For the link [[file:example.pdf::2]], org-lint identifies it as an invalid link.
> > This patch aims to address the issue.
>
> I am unable to reproduce this problem. M-x org-lint does not show any
> warning after I change the link to point to an existing file.
>
> I tested on the latest main.
>
> --
> Ihor Radchenko // yantar92,
> Org mode maintainer,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

Re: [Patch]: Ignore search option when org-lint local file link

[Ihor Radchenko]

Lei Zhe <lzhes43@gmail.com> writes:

> Sorry, it was [[attachment:example.pdf::2]].
> The lint for [[file:example.pdf::2]] is fine, since
> org-element-context returns the raw path without the search option.
> However, this is not the case for [[attachment:example.pdf::2]].

I can reproduce this one.
Applied, onto bugfix, with minor amendments after adding a proper commit
message.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c54340b8a8

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>