emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Juri Linkov <juri@linkov.net>, Eli Zaretskii <eliz@gnu.org>,
	Morgan.J.Smith@outlook.com,  emacs-orgmode@gnu.org,
	58131@debbugs.gnu.org, emacs-devel@gnu.org
Subject: Re: [FR] Allow flattened imenu index
Date: Mon, 11 Dec 2023 23:07:58 +0000	[thread overview]
Message-ID: <CALDnm52HqdmQc5pxJ6Njb14Csw6zMx_vY+ti9QBQOK-MH24WGA@mail.gmail.com> (raw)
In-Reply-To: <87o7ew7d05.fsf@localhost>

On Mon, Dec 11, 2023 at 7:27 PM Ihor Radchenko <yantar92@posteo.net> wrote:

> > Indeed, it's unfortunate that imenu--make-index-alist and imenu--index-alist
> > are named as internal.
>
> Should they be renamed to `imenu-make-index-alist' and `imenu-index-alist' then?

Maybe, but it's much more urgent IMO to review the representation
they describe, since it's all over the place.  Ideally do this
before any rename.

Incidentally, I just remembered why breadcrumb-jump uses the
'breadcrumb-region' text property cookie: it's because without it
the current imenu tree structure has no way to for backends to
store locations to non-leaf nodes, which are often among the places
you want to jump to.

text-properties + standard cons trees + "special elements" is a
bit of a ugly mess, but OTOH it works and is backwards compatible
to existing frontends and backends.

So one of the possibilities that whoever conducts this review
may consider is an 'imenu-region' text property similar to
'breadcrumb-region', describe it imenu--index-alist, and
make M-x imenu take advantage of it.

João


  reply	other threads:[~2023-12-11 23:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 20:52 [PATCH] Add new option 'org-imenu-flatten' Morgan Smith
2023-12-08 22:19 ` Ihor Radchenko
2023-12-09  1:46   ` Morgan Smith
2023-12-09  2:01     ` William Denton
2023-12-09 10:57     ` [FR] Allow flattened imenu index (was: [PATCH] Add new option 'org-imenu-flatten') Ihor Radchenko
2023-12-09 11:28       ` Eli Zaretskii
2023-12-09 11:39         ` Ihor Radchenko
2023-12-09 17:37           ` [FR] Allow flattened imenu index Juri Linkov
2023-12-11 11:51             ` João Távora
2023-12-11 17:20               ` Juri Linkov
2023-12-11 17:40                 ` João Távora
     [not found]                 ` <cf91ddb8-7759-52be-345f-fb85eadb9717@gutov.dev>
2023-12-11 18:00                   ` João Távora
     [not found]                     ` <595d6418-71f6-eec7-e37c-e3987265364c@gutov.dev>
2023-12-11 23:10                       ` João Távora
     [not found]                         ` <303c567e-7f0d-1fac-1ab4-0099bd98d8dd@gutov.dev>
2023-12-11 23:35                           ` João Távora
     [not found]                             ` <31ede4fc-8ebe-39ac-40c5-91ba08c35178@gutov.dev>
2023-12-11 23:48                               ` João Távora
     [not found]                                 ` <7eab6e94-cb8e-9ae1-d2cd-c0eb1b3bab43@gutov.dev>
2023-12-11 23:57                                   ` João Távora
2023-12-11 19:30                 ` Ihor Radchenko
2023-12-11 23:07                   ` João Távora [this message]
2023-12-14 23:11           ` Spencer Baugh
2024-05-11  9:41   ` [PATCH] Add new option 'org-imenu-flatten' Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm52HqdmQc5pxJ6Njb14Csw6zMx_vY+ti9QBQOK-MH24WGA@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=58131@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=juri@linkov.net \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).